You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ruansheng8 (via GitHub)" <gi...@apache.org> on 2024/05/24 08:58:23 UTC
[PR] Update DefaultRocketMQListenerContainer#getMessageType to protected [rocketmq-spring]
ruansheng8 opened a new pull request, #662:
URL: https://github.com/apache/rocketmq-spring/pull/662
## What is the purpose of the change
```
public interface IMessageConsumer<T> extends RocketMQListener<T> {
}
```
Due to project needs, some personalized business operations need to extend the `RocketMQListener` interface.
I need to override the `DefaultRocketMQListenerContainer#getMessageType()` method to complete my custom extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DefaultRocketMQListenerContainer#getMessageType to protected [rocketmq-spring]
Posted by "ruansheng8 (via GitHub)" <gi...@apache.org>.
ruansheng8 commented on PR #662:
URL: https://github.com/apache/rocketmq-spring/pull/662#issuecomment-2137216669
@RongtongJin cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DefaultRocketMQListenerContainer#getMessageType to protected [rocketmq-spring]
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #662:
URL: https://github.com/apache/rocketmq-spring/pull/662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update DefaultRocketMQListenerContainer#getMessageType to protected [rocketmq-spring]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #662:
URL: https://github.com/apache/rocketmq-spring/pull/662#issuecomment-5771472001
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Assessment:**
The request is to change `DefaultRocketMQListenerContainer#getMessageType()` from `private` to `protected` to allow subclass customization of message type resolution.
**Feasibility:** Feasible — simple visibility modifier change with no behavioral impact.
**Scope:** Single method in `DefaultRocketMQListenerContainer`.
**Compatibility:** No breaking changes — widening visibility from `private` to `protected` is backward compatible.
**Risk:** Low — subclasses can override type resolution, which is a reasonable extension point for custom business logic.
This is a reasonable extensibility improvement. A PR would be welcome.
---
*Automated evaluation by github-manager*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org