You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2025/01/10 19:39:43 UTC
[PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
potiuk opened a new pull request, #45564:
URL: https://github.com/apache/airflow/pull/45564
While backorting the "pull_request_target" removal to v2-10-test branches it turned out that there is not enough disk space on Public runner to load all 5 images and keep the file dump at the same time in the same filesystem. This PR allows to choose where the load/save files will be stored and in the github runner environment we store the files in "/mnt" wnich is a separate folder with 40GB free.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911771655
##########
dev/breeze/src/airflow_breeze/commands/production_image_commands.py:
##########
@@ -663,42 +673,48 @@ def load(
github_repository: str,
github_token: str,
image_file: Path | None,
+ image_file_dir: Path,
Review Comment:
ah got it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911463786
##########
dev/breeze/src/airflow_breeze/commands/production_image_commands.py:
##########
@@ -663,42 +673,48 @@ def load(
github_repository: str,
github_token: str,
image_file: Path | None,
+ image_file_dir: Path,
Review Comment:
should we add default `image_file_dir ` to `/tmp` ?, in this we no need to specific in local when we wanted to load ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911524501
##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -46,17 +46,19 @@ runs:
with:
use-uv: ${{ inputs.use-uv }}
id: breeze
+ - name: Make /mnt/ directory writeable
+ run: sudo chown -R ${USER} /mnt
Review Comment:
Might be a good idea :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911523800
##########
dev/breeze/src/airflow_breeze/commands/production_image_commands.py:
##########
@@ -663,42 +673,48 @@ def load(
github_repository: str,
github_token: str,
image_file: Path | None,
+ image_file_dir: Path,
Review Comment:
That's already done in click.option https://github.com/apache/airflow/pull/45564/files#diff-0c13a24dc14b590d6d34dc75b79213a0b571c0bfb29ea28febbdb2fd251a80cdR230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #45564:
URL: https://github.com/apache/airflow/pull/45564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911477127
##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -46,17 +46,19 @@ runs:
with:
use-uv: ${{ inputs.use-uv }}
id: breeze
+ - name: Make /mnt/ directory writeable
+ run: sudo chown -R ${USER} /mnt
Review Comment:
One more step to check how much space available, that helps to debug ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add optional --image-file-dir to store loaded files elsewhere [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #45564:
URL: https://github.com/apache/airflow/pull/45564#discussion_r1911530027
##########
.github/actions/prepare_breeze_and_image/action.yml:
##########
@@ -46,17 +46,19 @@ runs:
with:
use-uv: ${{ inputs.use-uv }}
id: breeze
+ - name: Make /mnt/ directory writeable
+ run: sudo chown -R ${USER} /mnt
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org