[hbase] branch branch-2.4 updated: HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)

[ap...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

apurtell pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new 37d62aabbd2 HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)
37d62aabbd2 is described below

commit 37d62aabbd2ae2eb8cf80b024fc4f4a9dbaec2f1
Author: Andrew Purtell <ap...@apache.org>
AuthorDate: Wed Jun 28 12:07:55 2023 -0700

    HBASE-27951 Use ADMIN_QOS in MasterRpcServices for regionserver operational dependencies (#5309)
    
    It seems not correct to have the MasterRpcServices methods for direct
    regionserver<->master communication (regionServerStartup, regionServerReport,
    and reportFatalRSError) contending with normal priority requests. They
    should be made ADMIN_QOS priority to avoid potential operational deadlocks.
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
    Signed-off-by: Viraj Jasani <vj...@apache.org>
    Reviewed-by: Aman Poonia <am...@gmail.com>
---
 .../main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java    | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
index ca3b36d6d18..996580c1bf0 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
@@ -539,6 +539,7 @@ public class MasterRpcServices extends RSRpcServices implements MasterService.Bl
   }
 
   @Override
+  @QosPriority(priority = HConstants.ADMIN_QOS)
   public RegionServerReportResponse regionServerReport(RpcController controller,
     RegionServerReportRequest request) throws ServiceException {
     try {
@@ -570,6 +571,7 @@ public class MasterRpcServices extends RSRpcServices implements MasterService.Bl
   }
 
   @Override
+  @QosPriority(priority = HConstants.ADMIN_QOS)
   public RegionServerStartupResponse regionServerStartup(RpcController controller,
     RegionServerStartupRequest request) throws ServiceException {
     // Register with server manager
@@ -601,6 +603,7 @@ public class MasterRpcServices extends RSRpcServices implements MasterService.Bl
   }
 
   @Override
+  @QosPriority(priority = HConstants.ADMIN_QOS)
   public ReportRSFatalErrorResponse reportRSFatalError(RpcController controller,
     ReportRSFatalErrorRequest request) throws ServiceException {
     String errorText = request.getErrorMessage();