You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "KnightChess (via GitHub)" <gi...@apache.org> on 2023/06/01 01:02:39 UTC
[GitHub] [hudi] KnightChess commented on a diff in pull request #8856: [HUDI-6300] fix file size parallelism not work when init metadata table
KnightChess commented on code in PR #8856:
URL: https://github.com/apache/hudi/pull/8856#discussion_r1212457103
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -842,7 +842,8 @@ public static HoodieData<HoodieRecord> convertFilesToBloomFilterRecords(HoodieEn
List<Pair<String, List<String>>> partitionToDeletedFilesList = partitionToDeletedFiles.entrySet()
.stream().map(e -> Pair.of(e.getKey(), e.getValue())).collect(Collectors.toList());
- int parallelism = Math.max(Math.min(partitionToDeletedFilesList.size(), recordsGenerationParams.getBloomIndexParallelism()), 1);
+ int totalDeleteFileSize = partitionToDeletedFilesList.stream().mapToInt(p -> p.getValue().size()).sum();
+ int parallelism = Math.max(Math.min(totalDeleteFileSize, recordsGenerationParams.getBloomIndexParallelism()), 1);
Review Comment:
oh, I got it. I mistakenly think that the later processing logic is the same as the update, I will try fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org