You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/08/26 15:55:53 UTC
[2/3] groovy git commit: Trivial refactoring: Move condition to loop
Trivial refactoring: Move condition to loop
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/255b94d9
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/255b94d9
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/255b94d9
Branch: refs/heads/master
Commit: 255b94d9aed81e76c1270df5db871c5bd22586be
Parents: a1c3584
Author: Daniel Sun <su...@apache.org>
Authored: Sun Aug 26 23:51:05 2018 +0800
Committer: Daniel Sun <su...@apache.org>
Committed: Sun Aug 26 23:51:05 2018 +0800
----------------------------------------------------------------------
src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/255b94d9/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
index b7fa503..4c7230e 100644
--- a/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
+++ b/src/main/java/org/codehaus/groovy/control/OptimizerVisitor.java
@@ -110,10 +110,9 @@ public class OptimizerVisitor extends ClassCodeExpressionTransformer {
return;
}
String name;
- while (true) {
+ do {
name = "$const$" + index++;
- if (currentClass.getDeclaredField(name) == null) break;
- }
+ } while (currentClass.getDeclaredField(name) != null);
field = new FieldNode(name,
Opcodes.ACC_PRIVATE | Opcodes.ACC_STATIC | Opcodes.ACC_SYNTHETIC | Opcodes.ACC_FINAL,
constantExpression.getType(),