You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2018/08/08 16:33:12 UTC

[arrow] branch master updated: ARROW-3019: [Packaging] Use Bundler to verify Arrow GLib

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new c114783  ARROW-3019: [Packaging] Use Bundler to verify Arrow GLib
c114783 is described below

commit c114783d5cfe4380de28ddbae83d24cc1f13afda
Author: Kouhei Sutou <ko...@clear-code.com>
AuthorDate: Wed Aug 8 12:33:08 2018 -0400

    ARROW-3019: [Packaging] Use Bundler to verify Arrow GLib
    
    Author: Kouhei Sutou <ko...@clear-code.com>
    
    Closes #2401 from kou/release-verify-use-bundler and squashes the following commits:
    
    7c5cb111 <Kouhei Sutou>  Use Bundler to verify Arrow GLib
---
 c_glib/Gemfile                          | 23 +++++++++++++++++++++++
 dev/release/verify-release-candidate.sh | 16 +++++++++-------
 2 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/c_glib/Gemfile b/c_glib/Gemfile
new file mode 100644
index 0000000..4b57090
--- /dev/null
+++ b/c_glib/Gemfile
@@ -0,0 +1,23 @@
+# -*- ruby -*-
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+source "https://rubygems.org/"
+
+gem "test-unit"
+gem "gobject-introspection"
diff --git a/dev/release/verify-release-candidate.sh b/dev/release/verify-release-candidate.sh
index a08657b..8787e8f 100755
--- a/dev/release/verify-release-candidate.sh
+++ b/dev/release/verify-release-candidate.sh
@@ -19,8 +19,7 @@
 #
 
 # Requirements
-# - Ruby 2.x
-#   - Plus gem dependencies, see c_glib/README
+# - Ruby >= 2.3
 # - Maven >= 3.3.9
 # - JDK >=7
 # - gcc >= 4.8
@@ -217,9 +216,14 @@ test_glib() {
   make -j$NPROC
   make install
 
-  GI_TYPELIB_PATH=$ARROW_HOME/lib/girepository-1.0 \
-                 NO_MAKE=yes \
-                 test/run-test.sh
+  export GI_TYPELIB_PATH=$ARROW_HOME/lib/girepository-1.0:$GI_TYPELIB_PATH
+
+  if ! bundle --version; then
+    gem install bundler
+  fi
+
+  bundle install --path vendor/bundle
+  bundle exec ruby test/run-test.rb
 
   popd
 }
@@ -243,8 +247,6 @@ test_js() {
 }
 
 test_ruby() {
-  export GI_TYPELIB_PATH=$ARROW_HOME/lib/girepository-1.0:$GI_TYPELIB_PATH
-
   pushd ruby
 
   pushd red-arrow