You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/05 05:59:28 UTC

[GitHub] [dubbo-go-hessian2] zonghaishang commented on a change in pull request #197: More unit tests

zonghaishang commented on a change in pull request #197:
URL: https://github.com/apache/dubbo-go-hessian2/pull/197#discussion_r435705574



##########
File path: string_test.go
##########
@@ -158,17 +159,29 @@ func TestStringEncode(t *testing.T) {
 	testJavaDecode(t, "argString_65536", s65560[:65536])
 }
 
-func BenchmarkDecodeStringOptimized(t *testing.B) {
+var decodePool = &sync.Pool{

Review comment:
       This is used to test pooling decoding and improve code coverage




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org