You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtadepalli (via GitHub)" <gi...@apache.org> on 2024/01/01 21:07:43 UTC
[PR] Fix connection leak in `JdbcDataSourceDatabase` constructor and pass in username/pass while getting connection [arrow-adbc]
rtadepalli opened a new pull request, #1418:
URL: https://github.com/apache/arrow-adbc/pull/1418
I think there is a connection leak in the constructor for `JdbcDataSourceDatabase` where we're obtaining a connection in the constructor but we're obtaining another one in the `connect` method using the appropriate username/password. We can remove this and also test the
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(java/driver/jdbc): fix connection leak in `JdbcDataSourceDatabase` constructor [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1418:
URL: https://github.com/apache/arrow-adbc/pull/1418#issuecomment-1874223774
Can we add a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(java/driver/jdbc): fix connection leak in `JdbcDataSourceDatabase` constructor [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1418:
URL: https://github.com/apache/arrow-adbc/pull/1418#issuecomment-1875381407
I've merged this for now, we can follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(java/driver/jdbc): fix connection leak in `JdbcDataSourceDatabase` constructor [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1418:
URL: https://github.com/apache/arrow-adbc/pull/1418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection leak in `JdbcDataSourceDatabase` constructor and pass in username/pass while getting connection [arrow-adbc]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1418:
URL: https://github.com/apache/arrow-adbc/pull/1418#issuecomment-1873480631
:warning: Please follow the [Conventional Commits format in CONTRIBUTING.md](https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md) for PR titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org