You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/04/27 19:09:43 UTC
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15820
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Don't filter maven messages about banned dependencies
The frontend build uses the maven-enforcer-plugin to ban
some dependencies or require specific versions of dependencies.
The messages look like:
Found Banned Dependency: foo.bar.baz:1.2.3
These are currently filtered by bin/mvn-quiet.sh. This adds
an exception for "Found Banned" so they are not filtered.
Testing:
- Ran on a branch with a known banned dependency and verified
the output
Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
---
M bin/mvn-quiet.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/15820/1
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15820 )
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Patch Set 1: Code-Review+2
Great, this very helpful.
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 02:19:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15820 )
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5888/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 19:54:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15820 )
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 01:49:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15820 )
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5712/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Apr 2020 20:42:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Don't filter maven messages about banned dependencies
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15820 )
Change subject: Don't filter maven messages about banned dependencies
......................................................................
Don't filter maven messages about banned dependencies
The frontend build uses the maven-enforcer-plugin to ban
some dependencies or require specific versions of dependencies.
The messages look like:
Found Banned Dependency: foo.bar.baz:1.2.3
These are currently filtered by bin/mvn-quiet.sh. This adds
an exception for "Found Banned" so they are not filtered.
Testing:
- Ran on a branch with a known banned dependency and verified
the output
Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Reviewed-on: http://gerrit.cloudera.org:8080/15820
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: David Knupp <dk...@cloudera.com>
---
M bin/mvn-quiet.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
David Knupp: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I24abe59ad6bffb28ac63d014aa0ec7388ef5478f
Gerrit-Change-Number: 15820
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>