You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2021/04/08 08:08:45 UTC
[GitHub] [incubator-pegasus] neverchanje opened a new pull request #717: fix(shell): update help to claim that policy in restore_app is optional
neverchanje opened a new pull request #717:
URL: https://github.com/apache/incubator-pegasus/pull/717
### What problem does this PR solve? <!--add issue link with summary if exists-->
```
>>> restore_app
USAGE: restore_app <-c|--old_cluster_name str> <-p|--old_policy_name str>
<-a|--old_app_name str> <-i|--old_app_id id>
<-t|--timestamp/backup_id timestamp> <-b|--backup_provider_type str>
[-n|--new_app_name str] [-s|--skip_bad_partition]
```
`<-p|--old_policy_name str>` is required at least in the help info of `restore_app` command.
Users are prone to make mistakes to add this argument when they restore a table.
What it is now:
```
>>> restore_app
invalid parameter
USAGE: restore_app <-c|--old_cluster_name str> <-a|--old_app_name str>
<-i|--old_app_id id> <-t|--timestamp/backup_id timestamp>
<-b|--backup_provider_type str> [-p|--old_policy_name str]
[-n|--new_app_name str] [-s|--skip_bad_partition]
```
`--old_policy_name` is not required anymore.
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Manual test (add detailed scripts or steps below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #717: fix(shell): update help to claim that policy in restore_app is optional
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #717:
URL: https://github.com/apache/incubator-pegasus/pull/717#issuecomment-841794835
@neverchanje rdsn need update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #717: fix(shell): update help to claim that policy in restore_app is optional
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #717:
URL: https://github.com/apache/incubator-pegasus/pull/717#issuecomment-841794835
@neverchanje rdsn need update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org