[jira] Resolved: (JCR-1091) more lenient behavior of Node#addMixin if mixin is already present

["Jukka Zitting (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCR-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1091.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5.0

Implemented the jcr2spi change in revision 705961.

My previous patch modified the canAddMixin() method that was used by addMixin() to validate the request to add the mixin. However, since the TCK uses the same canAddMixin() method to find new mixins (i.e. ones that are not already included in a node) to add to a node, the tests would always fail.

The committed resolution adds the "succeed if the mixin is already set" test directly in the addMixin() method.

> more lenient behavior of Node#addMixin if mixin is already present 
> -------------------------------------------------------------------
>
>                 Key: JCR-1091
>                 URL: https://issues.apache.org/jira/browse/JCR-1091
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr-tests, jackrabbit-jcr2spi, JCR 2.0, nodetype
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.5.0
>
>         Attachments: JCR-1091.patch
>
>
> Change implementation of addMixin() so that it doesn't fail when the mixin is already present.
> See also:
> jackrabbit core change: <http://svn.apache.org/viewvc?view=rev&revision=570149>
> JSR-283 issue: <https://jsr-283.dev.java.net/issues/show_bug.cgi?id=353>
> (this affects both the TCK and JCR2SPI, so I didn't specify a component)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.