You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/07/26 01:34:58 UTC

[GitHub] spark pull request #18725: [SPARK-21520][SQL]Hivetable scan for all the colu...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18725#discussion_r129465387
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ---
    @@ -49,6 +49,8 @@ abstract class RDG extends UnaryExpression with ExpectsInputTypes with Nondeterm
           s"Input argument to $prettyName must be an integer, long or null literal.")
       }
     
    +  override def deterministic: Boolean = true
    --- End diff --
    
    This is totally wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org