You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/24 07:18:42 UTC

[GitHub] [activemq-artemis] fvaleri commented on a change in pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties conversion

fvaleri commented on a change in pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties conversion
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396942510
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
 ##########
 @@ -477,7 +477,7 @@ private static void setProperty(javax.jms.Message msg, String key, Object value)
       } else if (value instanceof Decimal32) {
          msg.setFloatProperty(key, ((Decimal32) value).floatValue());
       } else if (value instanceof Binary) {
-         msg.setStringProperty(key, value.toString());
+         msg.setObjectProperty(key, ((Binary) value).getArray());
 
 Review comment:
   Hi @tabish121 , thank you for this note. I fixed this, please let me know if it's fine now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services