[GitHub] [pulsar] merlimat commented on a change in pull request #5440: [pulsar-perf] Add batching max message into perf-producer

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #5440: [pulsar-perf] Add batching max message into perf-producer
URL: https://github.com/apache/pulsar/pull/5440#discussion_r338194389
 
 

 ##########
 File path: pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceProducer.java
 ##########
 @@ -156,6 +156,10 @@
         @Parameter(names = { "-b",
                 "--batch-time-window" }, description = "Batch messages in 'x' ms window (Default: 1ms)")
         public double batchTimeMillis = 1.0;
+        
+        @Parameter(names = { "-bn",
+                "--batch-max-msgs" }, description = "Number of max messages in batch. (Default: 0 (disable))")
+        public int batchMaxMsgs = 0;
 
 Review comment:
   Leaving the default to 0 is a bit confusing since it will not "disabling" the batching, nor the default max batch size of 1000 messages. Should we instead use 1000 as default here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services