You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/27 12:13:53 UTC
[GitHub] [dolphinscheduler] JinyLeeChina opened a new pull request, #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
JinyLeeChina opened a new pull request, #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570
closed by #12568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#issuecomment-1293533474
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12570)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL) [1035 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_coverage&view=list) [17.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_duplicated_lines_density&view=list) [5.5% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on code in PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007713223
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1472,6 +1473,8 @@ private void submitStandByTask() {
long failedTimeInterval = DateUtils.differSec(new Date(), retryTask.getEndTime());
if ((long) retryTask.getRetryInterval() * SEC_2_MINUTES_TIME_UNIT > failedTimeInterval) {
logger.info("task name: {} retry waiting has not exceeded the interval time, and skip submission this time, task id:{}", task.getName(), task.getId());
+ readyToSubmitTaskQueue.remove(task);
Review Comment:
No, there is no need to print the log when removing, otherwise it is easy to cause confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007706860
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1512,6 +1515,10 @@ private void submitStandByTask() {
logger.info("remove task {},id:{} , because depend result : {}", task.getName(), task.getId(), dependResult);
}
}
+ for (TaskInstance task : skipSubmitInstances) {
+ readyToSubmitTaskQueue.put(task);
Review Comment:
Why need to add back these skip task instances ?
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1472,6 +1473,8 @@ private void submitStandByTask() {
long failedTimeInterval = DateUtils.differSec(new Date(), retryTask.getEndTime());
if ((long) retryTask.getRetryInterval() * SEC_2_MINUTES_TIME_UNIT > failedTimeInterval) {
logger.info("task name: {} retry waiting has not exceeded the interval time, and skip submission this time, task id:{}", task.getName(), task.getId());
+ readyToSubmitTaskQueue.remove(task);
Review Comment:
```suggestion
removeTaskFromStandbyList(task);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina merged pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
JinyLeeChina merged PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on code in PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007713223
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1472,6 +1473,8 @@ private void submitStandByTask() {
long failedTimeInterval = DateUtils.differSec(new Date(), retryTask.getEndTime());
if ((long) retryTask.getRetryInterval() * SEC_2_MINUTES_TIME_UNIT > failedTimeInterval) {
logger.info("task name: {} retry waiting has not exceeded the interval time, and skip submission this time, task id:{}", task.getName(), task.getId());
+ readyToSubmitTaskQueue.remove(task);
Review Comment:
No，here not need logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on a diff in pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on code in PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#discussion_r1007713527
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1512,6 +1515,10 @@ private void submitStandByTask() {
logger.info("remove task {},id:{} , because depend result : {}", task.getName(), task.getId(), dependResult);
}
}
+ for (TaskInstance task : skipSubmitInstances) {
+ readyToSubmitTaskQueue.put(task);
Review Comment:
Please see #12291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#issuecomment-1294335771
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12570)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG) [62 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY) [10 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL) [1035 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12570&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_coverage&view=list) [17.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_duplicated_lines_density&view=list) [5.5% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12570&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#issuecomment-1294322736
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/12570?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`2.0.8-prepare@0f8689f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 2.0.8-prepare #12570 +/- ##
================================================
Coverage ? 20.78%
Complexity ? 1603
================================================
Files ? 540
Lines ? 22991
Branches ? 2744
================================================
Hits ? 4779
Misses ? 17723
Partials ? 489
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] JinyLeeChina commented on pull request #12570: [Bugfix-12568] [Master] The retry task was submitted in advance will block other task
Posted by GitBox <gi...@apache.org>.
JinyLeeChina commented on PR #12570:
URL: https://github.com/apache/dolphinscheduler/pull/12570#issuecomment-1294313589
> I think it's better to change skipSubmitInstance to skipSubmitInstances
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org