You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Lavkesh Lahngir <la...@gmail.com> on 2016/08/04 18:10:47 UTC
Review Request 50814: Various Bug fixes and log messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, line 88
> > <https://reviews.apache.org/r/50814/diff/1/?file=1463268#file1463268line88>
> >
> > This would require changes in specs.
> >
> > ```<xs:element type="xs:string" name="resource_path" minOccurs="0" maxOccurs="unbounded">
> > <xs:annotation>
> > <xs:documentation>
> > Path for resources like jars etc. e.g. /path/to/my/jar
> > </xs:documentation>
> > </xs:annotation>
> > </xs:element>
> > ```
> >
> > Followed by changes in test cases, regression tests and clients using the REST API.
> >
> > So either let's make those changes right now to minimize trickle down effect, or let's decide that we'll infer type from the file's extension.
Yeah. It's easy to do right now.
> On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java, lines 216-218
> > <https://reviews.apache.org/r/50814/diff/1/?file=1463266#file1463266line216>
> >
> > Shouldn't be needed. `GenericExceptionMapper` will take care to ruturn the correct `APIResult`. Can you verify through test cases?
I am thinking to fix all the API things in separate JIRA. Lots of message formatting has to be done.
> On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java, lines 156-183
> > <https://reviews.apache.org/r/50814/diff/1/?file=1463266#file1463266line156>
> >
> > Can we add documentations for all these functions so that they can be reflected in http://lens.apache.org/resource_ScheduleResource.html
Yes. We will do. Just after bug fixes.
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review144898
-----------------------------------------------------------
On Aug. 4, 2016, 6:10 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review144898
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (lines 156 - 183)
<https://reviews.apache.org/r/50814/#comment211063>
Can we add documentations for all these functions so that they can be reflected in http://lens.apache.org/resource_ScheduleResource.html
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (lines 214 - 216)
<https://reviews.apache.org/r/50814/#comment211055>
Shouldn't be needed. `GenericExceptionMapper` will take care to ruturn the correct `APIResult`. Can you verify through test cases?
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 88)
<https://reviews.apache.org/r/50814/#comment211058>
This would require changes in specs.
```<xs:element type="xs:string" name="resource_path" minOccurs="0" maxOccurs="unbounded">
<xs:annotation>
<xs:documentation>
Path for resources like jars etc. e.g. /path/to/my/jar
</xs:documentation>
</xs:annotation>
</xs:element>
```
Followed by changes in test cases, regression tests and clients using the REST API.
So either let's make those changes right now to minimize trickle down effect, or let's decide that we'll infer type from the file's extension.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 118)
<https://reviews.apache.org/r/50814/#comment211059>
Let's use log statements like this: `log.info("Expiring job with handle {}", jobHandle);`
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (lines 194 - 195)
<https://reviews.apache.org/r/50814/#comment211062>
Let's close the session through SessionService interface. Seeing as it'll be needed at multiple places, let's keep a class-level variable initialized at construction.
`SessionService sessionService = LensServices.get().getService(SessionService.NAME);`
- Rajat Khandelwal
On Aug. 4, 2016, 11:40 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 11:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
> On Aug. 5, 2016, 5:51 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, line 71
> > <https://reviews.apache.org/r/50814/diff/1/?file=1463268#file1463268line71>
> >
> > we should call sessionService.openSession instead of queryService.openSession
Okay. That makes sense.
On Aug. 5, 2016, 5:51 a.m., Lavkesh Lahngir wrote:
> > No tests are updated or added. Can we add tests?
There are no addiotional functionalities in this change.
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review144875
-----------------------------------------------------------
On Aug. 4, 2016, 6:10 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
On Aug. 5, 2016, 5:51 a.m., Lavkesh Lahngir wrote:
> > No tests are updated or added. Can we add tests?
>
> Lavkesh Lahngir wrote:
> There are no addiotional functionalities in this change.
I think we can add tests for session conf.
- Lavkesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review144875
-----------------------------------------------------------
On Aug. 4, 2016, 6:10 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review144875
-----------------------------------------------------------
No tes
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 71)
<https://reviews.apache.org/r/50814/#comment211004>
we should call sessionService.openSession instead of queryService.openSession
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java (line 340)
<https://reviews.apache.org/r/50814/#comment211005>
Can you follow slf4j logging convention to pass params for logging, instead of string concatenation ?
No tests are updated or added. Can we add tests?
- Amareshwari Sriramadasu
On Aug. 4, 2016, 6:10 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2016, 6:10 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review145072
-----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java (line 83)
<https://reviews.apache.org/r/50814/#comment211256>
Can you change log to parameterized logging?
- Amareshwari Sriramadasu
On Aug. 8, 2016, 8:31 a.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 8:31 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review145313
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Aug. 9, 2016, 5:46 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 5:46 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
> 5. Alarm service will launch misfired events as soon as it gets them.
> 6. Added user varification when updating a job.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
> lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java c7f73eb
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 12:16 p.m.)
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description (updated)
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfired events as soon as it gets them.
6. Added user varification when updating a job.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java c7f73eb
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 12:15 p.m.)
Review request for lens.
Changes
-------
Clean up session apis.
Added session user validation
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfired events as soon as it gets them.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java c7f73eb
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/#review145181
-----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java (lines 60 - 62)
<https://reviews.apache.org/r/50814/#comment211337>
Shouldn't be needed. Adding this removes the usefulness of the other `openSession` method. Besides, we should try to not expose `auth` on interface level.
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (lines 216 - 218)
<https://reviews.apache.org/r/50814/#comment211338>
Shouldn't be needed.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 40)
<https://reviews.apache.org/r/50814/#comment211339>
Let's use service instead of impl.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 75)
<https://reviews.apache.org/r/50814/#comment211340>
We can probably remove the `"dummy"` argument.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (lines 80 - 81)
<https://reviews.apache.org/r/50814/#comment211343>
Directly use `BaseLensService.getSession`. Might have to make that static.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 81)
<https://reviews.apache.org/r/50814/#comment211341>
We can move `getSession` to `SessionValidator` and then we'll not have to cast to `BaseLensService`.
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (lines 92 - 97)
<https://reviews.apache.org/r/50814/#comment211344>
Can we directly use `sessionService.addResource` instead of making those calls here.
- Rajat Khandelwal
On Aug. 8, 2016, 6:12 p.m., Lavkesh Lahngir wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50814/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2016, 6:12 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1265
> https://issues.apache.org/jira/browse/LENS-1265
>
>
> Repository: lens
>
>
> Description
> -------
>
> 1. Scheduler's submit job is not setting db and session config passed
> 2. Scheduler's getJobDefinition api is giving response status 500
> 3. Instance run result path is set NULL in job_instance_run_table
> 4. Delete on scheduler job is failing with NPE
> 5. Alarm service will launch misfired events as soon as it gets them.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
> lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
> lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
> lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
> lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
> lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
>
> Diff: https://reviews.apache.org/r/50814/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lavkesh Lahngir
>
>
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 12:42 p.m.)
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfired events as soon as it gets them.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 12:16 p.m.)
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfired events as soon as it gets them.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
lens-server/src/test/java/org/apache/lens/server/scheduler/AlarmServiceTest.java 7b610de
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 9:51 a.m.)
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description (updated)
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfired events as soon as it gets them.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 9:51 a.m.)
Review request for lens.
Changes
-------
review comments
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description (updated)
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
5. Alarm service will launch misfire events as soon as it gets them.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir
Re: Review Request 50814: Various Bug fixes and log messages.
Posted by Lavkesh Lahngir <la...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50814/
-----------------------------------------------------------
(Updated Aug. 8, 2016, 8:31 a.m.)
Review request for lens.
Bugs: LENS-1265
https://issues.apache.org/jira/browse/LENS-1265
Repository: lens
Description
-------
1. Scheduler's submit job is not setting db and session config passed
2. Scheduler's getJobDefinition api is giving response status 500
3. Instance run result path is set NULL in job_instance_run_table
4. Delete on scheduler job is failing with NPE
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java b19248f
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java 52b56ca
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java e6c1571
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java 93d3d7e
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java ffaae6c
lens-api/src/main/resources/scheduler-job-0.1.xsd 4e6c68b
lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java 027a32b
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java 8603edf
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 7a2b06a
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java 7323add
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java 5b12720
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java 14ca32d
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 8909098
lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java ce744af
Diff: https://reviews.apache.org/r/50814/diff/
Testing
-------
Thanks,
Lavkesh Lahngir