[GitHub] [incubator-yunikorn-core] wilfred-s edited a comment on pull request #197: [YUNIKORN-369] Set default go version to 1.15.

[GitBox <gi...@apache.org>]

wilfred-s edited a comment on pull request #197:
URL: https://github.com/apache/incubator-yunikorn-core/pull/197#issuecomment-686369075


   > Since go 1.12 is EOL, I think we should update the version to 1.15.
   
   The `go.mod` version has nothing to do with being EOL or not. It is purely about what we allow at a language level and the way the compile fails.
   
   > We do not rely on any of 1.15 features directly today, but that doesn't mean we cannot (or not need) to include some new features moving forward. So today, we are most likely in your `case 3`.
   
   Yes but it does not enforce anything. That is why I have a change for the Makefile that will enforce the `go.mod` version as a minimum go version for the build. I think that is far more important and we can change the mod file when we really leverage the new language functionality.
   
   > We need to be careful to define what version of go can be supported, today we are saying 1.11+. But if someday we added some necessary changes that only supported by later go versions, we will need to visit our dependency check and doc, we can make decision later if we need to include that change or not.
   
   I have a change ready to go that will make sure the `go.mod` version is the same as we check in the Makefile. It will also make sure that the installed version that is used is at _least_ the version we define in `go.mod`. If it is not lining up we fail the build. (YUNIKORN-397)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org