You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/29 22:31:43 UTC

[GitHub] [spark] zero323 opened a new pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

zero323 opened a new pull request #34146:
URL: https://github.com/apache/spark/pull/34146


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   This pull request adds support for `str` schema in PySpark `RDD.toDF` method.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   `str` is not only supported, but also mentioned in the method documentation.
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   Type checker only. The following, will be now accepted as a valid `toDF` call:
   
   ```python
   sc.parallelize([("a", 1)]).toDF(schema="foo string, bar int")
   ```
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   Existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932736036


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48314/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931123108


   **[Test build #143766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143766/testReport)** for PR 34146 at commit [`253e801`](https://github.com/apache/spark/commit/253e801a9377a52320bbce82034584129536685e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421


   **[Test build #144817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144817/testReport)** for PR 34146 at commit [`72ead5b`](https://github.com/apache/spark/commit/72ead5b768bd57922c5aaae9a1497c89edf002eb).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948023307


   **[Test build #144473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144473/testReport)** for PR 34146 at commit [`f7dcc02`](https://github.com/apache/spark/commit/f7dcc0271cc8d4975b68ef9c7d54165a6be0ae8d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948057689


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144473/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932728312


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48314/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956575667


   **[Test build #144818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144818/testReport)** for PR 34146 at commit [`679aea8`](https://github.com/apache/spark/commit/679aea8bc0bcae5eed5884b2438bcb093e07408f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636251






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636253






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932494596


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48302/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932488126


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48302/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956592018


   **[Test build #144817 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144817/testReport)** for PR 34146 at commit [`72ead5b`](https://github.com/apache/spark/commit/72ead5b768bd57922c5aaae9a1497c89edf002eb).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-958971964


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #34146:
URL: https://github.com/apache/spark/pull/34146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932736036


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48314/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932458433


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143790/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932728895


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143802/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930615033


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48243/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930615884


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143732/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636251






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636251






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-959136935






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956761532






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944505729






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956718939


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49288/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956761532






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-959411333


   Thanks @sarutak,  on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-959136935


   @zero323 Sorry but I'll revert this because of Python linter failure on GA.
   I've retried but it still failed.
   Could you check it out?
   https://github.com/apache/spark/runs/4093063784?check_suite_focus=true#step:14:50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932735710


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48314/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931231398


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48277/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930615884






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-958971964






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930595745






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932721989


   **[Test build #143802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143802/testReport)** for PR 34146 at commit [`2cd905c`](https://github.com/apache/spark/commit/2cd905c704fae6436be339ba9cb52c1b898fd6aa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on a change in pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34146:
URL: https://github.com/apache/spark/pull/34146#discussion_r730054319



##########
File path: python/pyspark/sql/session.py
##########
@@ -646,23 +647,14 @@ def createDataFrame(
     def createDataFrame(
         self,
         data: Union[
-            "RDD[Union[DateTimeLiteral, LiteralType, DecimalLiteral]]",
-            Iterable[Union["DateTimeLiteral", "LiteralType", "DecimalLiteral"]],
+            "RDD[AtomicValue]",
+            Iterable[AtomicValue],
         ],
         schema: Union[AtomicType, str],
         verifySchema: bool = ...,
     ) -> DataFrame:
         ...
 
-    @overload
-    def createDataFrame(
-        self,
-        data: Union["RDD[RowLike]", Iterable["RowLike"]],
-        schema: Union[StructType, str],
-        verifySchema: bool = ...,
-    ) -> DataFrame:
-        ...

Review comment:
       This is not an applicable variant ‒ if schema is `Union[StructType, str]` schema is inferred and only the names are used. 

##########
File path: python/pyspark/sql/_typing.pyi
##########
@@ -42,6 +42,8 @@ AtomicDataTypeOrString = Union[pyspark.sql.types.AtomicType, str]
 DataTypeOrString = Union[pyspark.sql.types.DataType, str]
 OptionalPrimitiveType = Optional[PrimitiveType]
 
+AtomicValue = TypeVar("AtomicValue", datetime.datetime, datetime.date, decimal.Decimal, bool, str, int, float)

Review comment:
       Should it be covariant?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944469587






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944572307


   __Note__:
   
   This variant is dropped, because it is non-functional:
   
   https://github.com/apache/spark/blob/722ac1b8b7f86fdeedf20cc11c7f547e7038029c/python/pyspark/sql/session.py#L636-L642
   
   If only names are provided, we infer schema and there is no verification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956620055


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49287/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930606459






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930595745


   **[Test build #143732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143732/testReport)** for PR 34146 at commit [`5173da9`](https://github.com/apache/spark/commit/5173da9afa7e0232bfc7b2ff3442f1c048703b6a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948023307


   **[Test build #144473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144473/testReport)** for PR 34146 at commit [`f7dcc02`](https://github.com/apache/spark/commit/f7dcc0271cc8d4975b68ef9c7d54165a6be0ae8d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948040947


   **[Test build #144473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144473/testReport)** for PR 34146 at commit [`f7dcc02`](https://github.com/apache/spark/commit/f7dcc0271cc8d4975b68ef9c7d54165a6be0ae8d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956600946


   **[Test build #144818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144818/testReport)** for PR 34146 at commit [`679aea8`](https://github.com/apache/spark/commit/679aea8bc0bcae5eed5884b2438bcb093e07408f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #34146:
URL: https://github.com/apache/spark/pull/34146






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932725011


   **[Test build #143802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143802/testReport)** for PR 34146 at commit [`2cd905c`](https://github.com/apache/spark/commit/2cd905c704fae6436be339ba9cb52c1b898fd6aa).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 edited a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 edited a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944572307


   __Note__:
   
   This variant is dropped, because it is not functional:
   
   https://github.com/apache/spark/blob/722ac1b8b7f86fdeedf20cc11c7f547e7038029c/python/pyspark/sql/session.py#L636-L642
   
   If only names are provided, we infer schema and there is no verification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931169052


   **[Test build #143766 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143766/testReport)** for PR 34146 at commit [`253e801`](https://github.com/apache/spark/commit/253e801a9377a52320bbce82034584129536685e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931231398


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48277/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930606459


   FYI @ueshin 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930607007


   __Note__
   
   I am going to keep it as draft for now, because I realized we prefer to extend the scope of the ticket to synchronize `RDD.toDF` with `SparkSession.createDataFrame`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932458433


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143790/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931191522


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143766/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930595745


   **[Test build #143732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143732/testReport)** for PR 34146 at commit [`5173da9`](https://github.com/apache/spark/commit/5173da9afa7e0232bfc7b2ff3442f1c048703b6a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930633465


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48243/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930607708


   **[Test build #143732 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143732/testReport)** for PR 34146 at commit [`5173da9`](https://github.com/apache/spark/commit/5173da9afa7e0232bfc7b2ff3442f1c048703b6a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932728895


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143802/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on a change in pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #34146:
URL: https://github.com/apache/spark/pull/34146#discussion_r719235781



##########
File path: python/pyspark/rdd.pyi
##########
@@ -445,11 +445,18 @@ class RDD(Generic[T]):
     @overload
     def toDF(
         self: RDD[RowLike],
-        schema: Optional[List[str]] = ...,
+        schema: Optional[Union[List[str], Tuple[str, ...]]] = ...,
         sampleRatio: Optional[float] = ...,
     ) -> DataFrame: ...
     @overload
-    def toDF(self: RDD[RowLike], schema: Optional[StructType] = ...) -> DataFrame: ...
+    def toDF(
+        self: RDD[RowLike], schema: Optional[Union[StructType, str]] = ...
+    ) -> DataFrame: ...
+    @overload
+    def toDF(
+        self: RDD[Union[DateTimeLiteral, LiteralType, DecimalLiteral]],

Review comment:
       It seems like this part will requires some changes (switch to `TypeVar`). I'll investigate this and provide an update.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931123108


   **[Test build #143766 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143766/testReport)** for PR 34146 at commit [`253e801`](https://github.com/apache/spark/commit/253e801a9377a52320bbce82034584129536685e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932431510


   **[Test build #143790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143790/testReport)** for PR 34146 at commit [`ad9c070`](https://github.com/apache/spark/commit/ad9c070c92f64918e0028b206e9b2b046f453dba).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932494596


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48302/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944469587






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930595745


   **[Test build #143732 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143732/testReport)** for PR 34146 at commit [`5173da9`](https://github.com/apache/spark/commit/5173da9afa7e0232bfc7b2ff3442f1c048703b6a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-944505729






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931191522


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143766/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931228684


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48277/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-958971964






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956627906


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49288/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-960368386


   Thanks guys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948050967


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48946/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948090656


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48946/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948057689


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144473/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932448496


   **[Test build #143790 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143790/testReport)** for PR 34146 at commit [`ad9c070`](https://github.com/apache/spark/commit/ad9c070c92f64918e0028b206e9b2b046f453dba).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930615884


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143732/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-931189432


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48277/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932721989


   **[Test build #143802 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143802/testReport)** for PR 34146 at commit [`2cd905c`](https://github.com/apache/spark/commit/2cd905c704fae6436be339ba9cb52c1b898fd6aa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][PYTHON] Synchronize RDD.toDF annotations with SparkSession.createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932461750


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48302/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-932431510


   **[Test build #143790 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143790/testReport)** for PR 34146 at commit [`ad9c070`](https://github.com/apache/spark/commit/ad9c070c92f64918e0028b206e9b2b046f453dba).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][PYTHON] Support str schema in RDD.toDF annotations

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-930615884






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948085673


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48946/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-948090656


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48946/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956743757


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49287/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] sarutak commented on pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-959136935


   @zero323 Sorry but I'll revert this because of Python linter failure on GA.
   I've retried but it still failed.
   Could you check it out?
   https://github.com/apache/spark/runs/4093063784?check_suite_focus=true#step:14:50


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636253






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956573421






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #34146: [SPARK-36894][SPARK-37077[PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34146:
URL: https://github.com/apache/spark/pull/34146#issuecomment-956636253






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zero323 closed pull request #34146: [SPARK-36894][SPARK-37077][PYTHON] Synchronize RDD.toDF annotations with SparkSession and SQLContext .createDataFrame variants.

Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #34146:
URL: https://github.com/apache/spark/pull/34146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org