[jira] [Commented] (S2GRAPH-38) Transform option gives wrong result since it transform degree edge too.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153878#comment-15153878 ] 

ASF GitHub Bot commented on S2GRAPH-38:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/21

    [S2GRAPH-38] Transform option gives wrong result since it transform degree edge too.

    + skip convertEdges on degreeEdge.
    + not include degreeEdge to exclude/include edges in filterEdges logic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-38

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
    
----
commit 4bc26ff3aba3ba08d2db0b65558da6d2c4620fb1
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-19T07:58:31Z

    S2GRAPH-38 skip convertEdges when current edge is degree edge.

----


> Transform option gives wrong result since it transform degree edge too.
> -----------------------------------------------------------------------
>
>                 Key: S2GRAPH-38
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-38
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Minor
>              Labels: easyfix
>
> There is no check if edge is {{degreeEdge}} or normal {{indexEdge}} when we transform fetched edges using EdgeTransformer on QueryParam. 
> I think it is necessary to skip {{Graph.convertEdges}} when edge is {{degreeEdge}}
> ex) there is no edges exist from srcVertex "a". if we query with "transform": [["from"]], then now query result has one edge {"from": "a", "to": "a"}. this is an edge that transformed from degreeEdge {"from": "a", "to": "0"}. 
> I think using special target vertex id "0" in degree edge yield this problem and buggy, but for now transforming edge based on queryParam's EdgeTransformer can skip transform if considering edge is {{degreeEdge}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)