You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/14 10:48:57 UTC

[GitHub] [pulsar] ZhuJiang121 opened a new issue #8262: The REST API to create source is not correct

ZhuJiang121 opened a new issue #8262:
URL: https://github.com/apache/pulsar/issues/8262


   I found params it need is "sourceConfig" and "url" ,but the REST API documents is not true,
   
   [https://pulsar.apache.org/source-rest-api/?version=2.6.1&apiversion=v3#operation/registerSource](https://pulsar.apache.org/source-rest-api/?version=2.6.1&apiversion=v3#operation/registerSource)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jennifer88huang commented on issue #8262: The REST API to create source is not correct

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on issue #8262:
URL: https://github.com/apache/pulsar/issues/8262#issuecomment-709981904


   @tuteng @zymap could you please help check it? Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower commented on issue #8262: The REST API to create source is not correct

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on issue #8262:
URL: https://github.com/apache/pulsar/issues/8262#issuecomment-710865672


   You're right, I've opened the similar issue before, see #7625 . The REST API to create or update a source/sink is `multipart/form-data`.
   
   `url` is not the only undocumented params, see  https://github.com/apache/pulsar/blob/9c821cf940d422d2ea3d47687bd309fe698ab84e/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java#L79-L81
   
   I've seen many people being confused with these REST APIs, but it's hard to document `uploadedInputStream` and `fileDetail`. Also I'm not sure how to use other languages to construct the HTTP body, because `uploadedInputStream` and `fileDetail` are Java classes.
   
   Therefore, the only way I can think of is just using the `pulsar-admin` to create/update source/sink.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower edited a comment on issue #8262: The REST API to create source is not correct

Posted by GitBox <gi...@apache.org>.
BewareMyPower edited a comment on issue #8262:
URL: https://github.com/apache/pulsar/issues/8262#issuecomment-710865672


   You're right, I've opened the similar issue before, see #7625 . The REST API to create or update a source/sink is `multipart/form-data`.
   
   `url` is not the only undocumented params, see  https://github.com/apache/pulsar/blob/9c821cf940d422d2ea3d47687bd309fe698ab84e/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinksBase.java#L79-L81
   
   I've seen many people being confused with these REST APIs, but it's hard to document `uploadedInputStream` and `fileDetail`. Also I don't know how to use other languages to construct the HTTP body, because `uploadedInputStream` and `fileDetail` are Java classes.
   
   Therefore, the only way I can think of is just using the `pulsar-admin` to create/update source/sink.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org