You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2011/04/10 12:29:48 UTC
svn commit: r1090761 -
/commons/proper/discovery/trunk/findbugs-exclude-filter.xml
Author: sebb
Date: Sun Apr 10 10:29:48 2011
New Revision: 1090761
URL: http://svn.apache.org/viewvc?rev=1090761&view=rev
Log:
Remove settings which only apply to LANG3
Modified:
commons/proper/discovery/trunk/findbugs-exclude-filter.xml
Modified: commons/proper/discovery/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/discovery/trunk/findbugs-exclude-filter.xml?rev=1090761&r1=1090760&r2=1090761&view=diff
==============================================================================
--- commons/proper/discovery/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/discovery/trunk/findbugs-exclude-filter.xml Sun Apr 10 10:29:48 2011
@@ -23,76 +23,6 @@
-->
<FindBugsFilter>
- <!-- Reason: Optimization to use == -->
- <Match>
- <Class name="org.apache.commons.lang3.BooleanUtils" />
- <Method name="toBoolean" />
- <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
- </Match>
-
- <!-- Reason: Optimization to use == -->
- <Match>
- <Class name="org.apache.commons.lang3.StringUtils" />
- <Method name="indexOfDifference"/>
- <Bug pattern="ES_COMPARING_PARAMETER_STRING_WITH_EQ" />
- </Match>
-
- <!-- Reason: Very much intended to do a fall through on the switch -->
- <Match>
- <Class name="org.apache.commons.lang3.math.NumberUtils" />
- <Method name="createNumber"/>
- <Bug pattern="SF_SWITCH_FALLTHROUGH" />
- </Match>
-
- <!-- Reason: Very much intended to do a fall through on the switch -->
- <Match>
- <Class name="org.apache.commons.lang3.time.DateUtils" />
- <Method name="getFragment"/>
- <Bug pattern="SF_SWITCH_FALLTHROUGH" />
- </Match>
-
- <!-- Reason: hashCode is lazily loaded in Range classes -->
- <!-- TODO: Work out why regex didn't work here -->
- <Match>
- <Class name="org.apache.commons.lang3.math.DoubleRange" />
- <Field name="hashCode" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
- <Match>
- <Class name="org.apache.commons.lang3.math.FloatRange" />
- <Field name="hashCode" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
- <Match>
- <Class name="org.apache.commons.lang3.math.IntRange" />
- <Field name="hashCode" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
- <Match>
- <Class name="org.apache.commons.lang3.math.LongRange" />
- <Field name="hashCode" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
- <Match>
- <Class name="org.apache.commons.lang3.math.NumberRange" />
- <Field name="hashCode" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
-
- <!-- Reason: toProperString is lazily loaded -->
- <Match>
- <Class name="org.apache.commons.lang3.math.Fraction" />
- <Field name="toProperString" />
- <Bug pattern="SE_TRANSIENT_FIELD_NOT_RESTORED" />
- </Match>
-
- <!-- Reason: It does call super.clone(), but via a subsequent method -->
- <Match>
- <Class name="org.apache.commons.lang3.text.StrTokenizer" />
- <Method name="clone"/>
- <Bug pattern="CN_IDIOM_NO_SUPER_CALL" />
- </Match>
-
<!-- Reason: Testing shows that new Integer(...) etc is quicker than Integer.valueOf -->
<Match>
<Bug pattern="DM_NUMBER_CTOR" />