You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "AngersZhuuuu (via GitHub)" <gi...@apache.org> on 2023/04/17 03:35:39 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1433: [CELEBORN-528][REFACTOR] limitZeroInFlight should show inflight target

AngersZhuuuu opened a new pull request, #1433:
URL: https://github.com/apache/incubator-celeborn/pull/1433

   ### What changes were proposed in this pull request?
   Currently exceed limitZeroInFlight didn't show the target ip, hard to found out unhealthy worker. This pr make it show the target IP
   ```
   23/04/13 15:41:21 ERROR Executor: Exception in task 31906.0 in stage 8.0 (TID 30304)
   com.aliyun.emr.rss.common.exception.RssIOException: wait timeout for task 14-31906-0
   	at com.aliyun.emr.rss.client.ShuffleClientImpl.limitZeroInFlight(ShuffleClientImpl.java:371)
   	at com.aliyun.emr.rss.client.ShuffleClientImpl.mapperEnd(ShuffleClientImpl.java:969)
   	at org.apache.spark.shuffle.rss.SortBasedShuffleWriter.close(SortBasedShuffleWriter.java:269)
   	at org.apache.spark.shuffle.rss.SortBasedShuffleWriter.write(SortBasedShuffleWriter.java:166)
   	at org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)
   	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
   	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52)
   	at org.apache.spark.scheduler.Task.run(Task.scala:131)
   	at org.apache.spark.executor.Executor$TaskRunner.$anonfun$run$3(Executor.scala:497)
   	at org.apache.spark.util.Utils$.tryWithSafeFinally(Utils.scala:1509)
   	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:500)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   	at java.lang.Thread.run(Thread.java:748) 
   ```
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1433: [CELEBORN-528][REFACTOR] limitZeroInFlight should show inflight target

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1433:
URL: https://github.com/apache/incubator-celeborn/pull/1433#issuecomment-1510652377

   ## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1433?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1433](https://codecov.io/gh/apache/incubator-celeborn/pull/1433?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (04155ea) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/ecafbf41fc215b0f351aed0f7587e31e5fd749e6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecafbf4) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1433      +/-   ##
   ==========================================
   - Coverage   45.75%   45.59%   -0.15%     
   ==========================================
     Files         167      167              
     Lines       10507    10508       +1     
     Branches     1047     1047              
   ==========================================
   - Hits         4806     4790      -16     
   - Misses       5368     5382      +14     
   - Partials      333      336       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../celeborn/common/write/InFlightRequestTracker.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1433?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vd3JpdGUvSW5GbGlnaHRSZXF1ZXN0VHJhY2tlci5qYXZh) | `29.12% <0.00%> (-0.37%)` | :arrow_down: |
   
   ... and [3 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1433/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1433: [CELEBORN-528][REFACTOR] limitZeroInFlight should show inflight target

Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu merged PR #1433:
URL: https://github.com/apache/incubator-celeborn/pull/1433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org