You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/28 06:41:15 UTC

[GitHub] [apisix] membphis opened a new pull request #2337: change(hmac-auth): update the organization of `signing_string` .

membphis opened a new pull request #2337:
URL: https://github.com/apache/apisix/pull/2337


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   fix #2336 .
   
   ref:
   https://help.aliyun.com/document_detail/29475.html?spm=a2c4g.11186623.2.15.62c73e789LVg02
   https://docs.aws.amazon.com/AmazonS3/latest/dev/RESTAuthentication.html#RESTAuthenticationConstructingCanonicalizedAmzHeaders
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2337: change(hmac-auth): update the organization of `signing_string` .

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2337:
URL: https://github.com/apache/apisix/pull/2337#issuecomment-699851922


   > need to update test cases in `custom_hmac_auth.t` and `consumer-restriction.t` too
   
   fixed right now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #2337: change(hmac-auth): update the organization of `signing_string` .

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2337:
URL: https://github.com/apache/apisix/pull/2337


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on pull request #2337: change(hmac-auth): update the organization of `signing_string` .

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2337:
URL: https://github.com/apache/apisix/pull/2337#issuecomment-699845218


   need to update test cases in `custom_hmac_auth.t` and `consumer-restriction.t` too


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org