You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/27 02:34:28 UTC
[GitHub] [skywalking] wankai123 opened a new pull request #7586: Reorganize dynamic configuration doc
wankai123 opened a new pull request #7586:
URL: https://github.com/apache/skywalking/pull/7586
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
Since dynamic configuration getting more complex, the current doc is too simple, we need to reorganize it to make end-users easier to read and use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7586: Doc: Reorganize dynamic configuration doc
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7586:
URL: https://github.com/apache/skywalking/pull/7586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7586: Doc: Reorganize dynamic configuration doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7586:
URL: https://github.com/apache/skywalking/pull/7586#discussion_r697110494
##########
File path: docs/en/setup/backend/dynamic-config-zookeeper.md
##########
@@ -0,0 +1,61 @@
+# Dynamic Configuration Zookeeper Implementation
+[Zookeeper](https://github.com/apache/zookeeper) is also supported as Dynamic Configuration Center (DCC). To use it, please configure as follows:
+
+```yaml
+configuration:
+ selector: ${SW_CONFIGURATION:zookeeper}
+ zookeeper:
+ period: ${SW_CONFIG_ZK_PERIOD:60} # Unit seconds, sync period. Default fetch every 60 seconds.
+ nameSpace: ${SW_CONFIG_ZK_NAMESPACE:/default}
+ hostPort: ${SW_CONFIG_ZK_HOST_PORT:localhost:2181}
+ # Retry Policy
+ baseSleepTimeMs: ${SW_CONFIG_ZK_BASE_SLEEP_TIME_MS:1000} # initial amount of time to wait between retries
+ maxRetries: ${SW_CONFIG_ZK_MAX_RETRIES:3} # max number of times to retry
+```
+
+The **nameSpace** is the ZooKeeper path. The config key and value are the properties of the `namespace` folder.
+
+## Config Storage
+### Single Config
+```
+znode.path = {nameSpace}/configKey
+configVaule = znode.data
Review comment:
```suggestion
configValue = znode.data
```
Typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7586: Doc: Reorganize dynamic configuration doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7586:
URL: https://github.com/apache/skywalking/pull/7586#discussion_r697110341
##########
File path: CHANGES.md
##########
@@ -63,7 +63,7 @@ Release Notes.
* Add a section in `Log Collecting And Analysis` doc, introducing the new Python agent log reporter.
* Add one missing step in `otel-receiver` doc about how to activate the default receiver.
-
+* Reorganize dynamic configuration doc.
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/96?closed=1)
Review comment:
```suggestion
* Reorganize dynamic configuration doc.
All issues and pull requests are [here](https://github.com/apache/skywalking/milestone/96?closed=1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7586: Doc: Reorganize dynamic configuration doc
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7586:
URL: https://github.com/apache/skywalking/pull/7586#discussion_r697111163
##########
File path: docs/en/setup/backend/dynamic-config-zookeeper.md
##########
@@ -0,0 +1,61 @@
+# Dynamic Configuration Zookeeper Implementation
+[Zookeeper](https://github.com/apache/zookeeper) is also supported as Dynamic Configuration Center (DCC). To use it, please configure as follows:
+
+```yaml
+configuration:
+ selector: ${SW_CONFIGURATION:zookeeper}
+ zookeeper:
+ period: ${SW_CONFIG_ZK_PERIOD:60} # Unit seconds, sync period. Default fetch every 60 seconds.
+ nameSpace: ${SW_CONFIG_ZK_NAMESPACE:/default}
+ hostPort: ${SW_CONFIG_ZK_HOST_PORT:localhost:2181}
+ # Retry Policy
+ baseSleepTimeMs: ${SW_CONFIG_ZK_BASE_SLEEP_TIME_MS:1000} # initial amount of time to wait between retries
+ maxRetries: ${SW_CONFIG_ZK_MAX_RETRIES:3} # max number of times to retry
+```
+
+The **nameSpace** is the ZooKeeper path. The config key and value are the properties of the `namespace` folder.
+
+## Config Storage
+### Single Config
+```
+znode.path = {nameSpace}/configKey
+configVaule = znode.data
+```
+e.g. The config is:
+```
+{agent-analyzer.default.slowDBAccessThreshold}:{default:200,mongodb:50}
+```
+If `nameSpace = /default` the config in zookeeper is:
+```
+znode.path = /default/agent-analyzer.default.slowDBAccessThreshold
+znode.data = default:200,mongodb:50
+```
+
+### Group Config
+```
+znode.path = {nameSpace}/configKey
+znode.child1.path = znode.path/subItemkey1
Review comment:
```suggestion
znode.child1.path = {znode.path}/subItemkey1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org