You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@livy.apache.org by mgaido91 <gi...@git.apache.org> on 2018/09/27 10:21:30 UTC
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
GitHub user mgaido91 opened a pull request:
https://github.com/apache/incubator-livy/pull/116
[LIVY-520] Add log when session is GC-ed
## What changes were proposed in this pull request?
When a session is inactive for a long time, it is GC-ed, ie. it is closed. Currently this operation is not logged, so it is not easy to understand why a session was closed.
The PR proposes to add a log in order to explain what happened.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/incubator-livy LIVY-520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 8a11292cbed0c96bb4b3f7e5906a03d3d479d2b0
Author: Marco Gaido <mg...@...>
Date: 2018-09-27T10:14:52Z
[LIVY-520] Add log when session is GC-ed
----
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 closed the pull request at:
https://github.com/apache/incubator-livy/pull/116
---
[GitHub] incubator-livy issue #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/incubator-livy/pull/116
cc @alex-the-man @jerryshao @vanzin
---
[GitHub] incubator-livy issue #116: [LIVY-520] Add log when session is GC-ed
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-livy/pull/116
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=h1) Report
> Merging [#116](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/134713d705a8de555bed912ac84f5214d7bddc30?src=pr&el=desc) will **increase** coverage by `1.35%`.
> The diff coverage is `33.33%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #116 +/- ##
============================================
+ Coverage 71.07% 72.43% +1.35%
- Complexity 797 868 +71
============================================
Files 99 100 +1
Lines 5515 5877 +362
Branches 828 917 +89
============================================
+ Hits 3920 4257 +337
- Misses 1064 1071 +7
- Partials 531 549 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...cala/org/apache/livy/sessions/SessionManager.scala](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXNzaW9ucy9TZXNzaW9uTWFuYWdlci5zY2FsYQ==) | `82.71% <33.33%> (-0.83%)` | `23 <1> (ø)` | |
| [rsc/src/main/java/org/apache/livy/rsc/Utils.java](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9VdGlscy5qYXZh) | `85.36% <0%> (-2.44%)` | `16% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.08% <0%> (-0.85%)` | `43% <0%> (ø)` | |
| [rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjLmphdmE=) | `79.28% <0%> (-0.6%)` | `12% <0%> (ø)` | |
| [.../scala/org/apache/livy/repl/SparkInterpreter.scala](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cmVwbC9zY2FsYS0yLjExL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9yZXBsL1NwYXJrSW50ZXJwcmV0ZXIuc2NhbGE=) | `82.97% <0%> (ø)` | `10% <0%> (?)` | |
| [...in/scala/org/apache/livy/repl/SQLInterpreter.scala](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9TUUxJbnRlcnByZXRlci5zY2FsYQ==) | `74% <0%> (+1.02%)` | `6% <0%> (+5%)` | :arrow_up: |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `95.16% <0%> (+1.31%)` | `40% <0%> (+19%)` | :arrow_up: |
| [...main/java/org/apache/livy/rsc/ContextLauncher.java](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Db250ZXh0TGF1bmNoZXIuamF2YQ==) | `87.69% <0%> (+3.77%)` | `24% <0%> (+6%)` | :arrow_up: |
| [...n/scala/org/apache/livy/utils/LivySparkUtils.scala](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9MaXZ5U3BhcmtVdGlscy5zY2FsYQ==) | `75.63% <0%> (+4%)` | `0% <0%> (ø)` | :arrow_down: |
| [...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9ycGMvUnBjRGlzcGF0Y2hlci5qYXZh) | `67.34% <0%> (+4.08%)` | `20% <0%> (+1%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-livy/pull/116/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=footer). Last update [134713d...8a11292](https://codecov.io/gh/apache/incubator-livy/pull/116?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 closed the pull request at:
https://github.com/apache/incubator-livy/pull/116
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 closed the pull request at:
https://github.com/apache/incubator-livy/pull/116
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-livy/pull/116
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
GitHub user mgaido91 reopened a pull request:
https://github.com/apache/incubator-livy/pull/116
[LIVY-520] Add log when session is GC-ed
## What changes were proposed in this pull request?
When a session is inactive for a long time, it is GC-ed, ie. it is closed. Currently this operation is not logged, so it is not easy to understand why a session was closed.
The PR proposes to add a log in order to explain what happened.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/incubator-livy LIVY-520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 8a11292cbed0c96bb4b3f7e5906a03d3d479d2b0
Author: Marco Gaido <mg...@...>
Date: 2018-09-27T10:14:52Z
[LIVY-520] Add log when session is GC-ed
----
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
GitHub user mgaido91 reopened a pull request:
https://github.com/apache/incubator-livy/pull/116
[LIVY-520] Add log when session is GC-ed
## What changes were proposed in this pull request?
When a session is inactive for a long time, it is GC-ed, ie. it is closed. Currently this operation is not logged, so it is not easy to understand why a session was closed.
The PR proposes to add a log in order to explain what happened.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/incubator-livy LIVY-520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 8a11292cbed0c96bb4b3f7e5906a03d3d479d2b0
Author: Marco Gaido <mg...@...>
Date: 2018-09-27T10:14:52Z
[LIVY-520] Add log when session is GC-ed
----
---
[GitHub] incubator-livy issue #116: [LIVY-520] Add log when session is GC-ed
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/incubator-livy/pull/116
Merging to master.
---
[GitHub] incubator-livy pull request #116: [LIVY-520] Add log when session is GC-ed
Posted by mgaido91 <gi...@git.apache.org>.
GitHub user mgaido91 reopened a pull request:
https://github.com/apache/incubator-livy/pull/116
[LIVY-520] Add log when session is GC-ed
## What changes were proposed in this pull request?
When a session is inactive for a long time, it is GC-ed, ie. it is closed. Currently this operation is not logged, so it is not easy to understand why a session was closed.
The PR proposes to add a log in order to explain what happened.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/incubator-livy LIVY-520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit 8a11292cbed0c96bb4b3f7e5906a03d3d479d2b0
Author: Marco Gaido <mg...@...>
Date: 2018-09-27T10:14:52Z
[LIVY-520] Add log when session is GC-ed
----
---