You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Alexander Rukletsov (JIRA)" <ji...@apache.org> on 2016/11/01 12:56:59 UTC

[jira] [Commented] (MESOS-6494) Clean up the flags parsing in the executors.

    [ https://issues.apache.org/jira/browse/MESOS-6494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625362#comment-15625362 ] 

Alexander Rukletsov commented on MESOS-6494:
--------------------------------------------

{noformat}
commit e802760c932e766775eba481d890d43232693815
Author: Gastón Kleiman gaston@mesosphere.com
Date:   Mon Oct 31 16:07:42 2016 -0700

Removed outdated TODO in stout::flags.

Review: https://reviews.apache.org/r/52878/
{noformat}
{noformat}
commit 0d116e099b6568dd0b99a973df57f3581b81a8a4
Author: Gastón Kleiman gaston@mesosphere.com
Date:   Mon Oct 31 16:09:04 2016 -0700

Added parsers for 'SlaveID', 'ExecutorID' and 'FrameworkID'.

Review: https://reviews.apache.org/r/53197/
{noformat}

> Clean up the flags parsing in the executors.
> --------------------------------------------
>
>                 Key: MESOS-6494
>                 URL: https://issues.apache.org/jira/browse/MESOS-6494
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Gastón Kleiman
>            Assignee: Gastón Kleiman
>              Labels: mesosphere
>
> The current executors and the executor libraries use a mix of `stout::flags` and `os::getenv` to parse flags, leading to a lot of unnecessary and sometimes duplicated code.
> This should be cleaned up, using only {{stout::flags}} to parse flags.
> Environment variables should be used for the flags that are common to ALL the executors (listed in the Executor HTTP API doc).
> Command line parameters should be used for flags that apply only to individual executors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)