Re: [PR] MINOR: Cleanup the storage module unit tests [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #16202:
URL: https://github.com/apache/kafka/pull/16202#discussion_r1627800722


##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataFormatterTest.java:
##########
@@ -35,28 +34,29 @@
 import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.apache.kafka.server.log.remote.storage.RemoteLogSegmentState.COPY_SEGMENT_STARTED;
 
 public class RemoteLogMetadataFormatterTest {
-    private static final Uuid TOPIC_ID = Uuid.randomUuid();

Review Comment:
   Those changes are a kind of "code style". I guess there is no strict rules in our code base. However, I prefer to reduce the code changes if we don't have strong reason.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org