Re: [PR] KAFKA-20089 : clients - update javadocs -- while topic being created in background [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #21959:
URL: https://github.com/apache/kafka/pull/21959#discussion_r3055108680


##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1425,7 +1425,10 @@ public Uuid clientInstanceId(Duration timeout) {
      *
      * @param topic The topic to get partition metadata for
      *
-     * @return The list of partitions, which will be empty when the given topic is not found
+     * @return The list of partitions, which will be empty when the given topic is not found.
+     *         Note: when {@code auto.create.topics.enable} is {@code true}, this method may

Review Comment:
   Should it mention `allow.auto.create.topics` as well?



##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1448,7 +1451,10 @@ public List<PartitionInfo> partitionsFor(String topic) {
      * @param topic The topic to get partition metadata for
      * @param timeout The maximum of time to await topic metadata
      *
-     * @return The list of partitions, which will be empty when the given topic is not found
+     * @return The list of partitions, which will be empty when the given topic is not found.
+     *         Note: when {@code auto.create.topics.enable} is {@code true}, this method may

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org