You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by ni...@apache.org on 2019/06/07 15:49:47 UTC
[ignite] branch master updated: IGNITE-11899: fix code style issues
(#6597)
This is an automated email from the ASF dual-hosted git repository.
nizhikov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite.git
The following commit(s) were added to refs/heads/master by this push:
new 14ac88d IGNITE-11899: fix code style issues (#6597)
14ac88d is described below
commit 14ac88dcc76aca735f50ebe7e7e6ae2f8584a2ba
Author: Maxim Muzafarov <ma...@gmail.com>
AuthorDate: Fri Jun 7 18:49:33 2019 +0300
IGNITE-11899: fix code style issues (#6597)
---
.../commandline/diagnostic/PageLocksCommand.java | 5 +++++
.../processors/cache/persistence/DataStructure.java | 1 +
.../diagnostic/pagelocktracker/InvalidContext.java | 1 +
.../diagnostic/pagelocktracker/LockTrackerFactory.java | 4 ++++
.../diagnostic/pagelocktracker/PageLockTracker.java | 17 +++++++++++++++++
.../pagelocktracker/PageLockTrackerManager.java | 5 ++++-
.../pagelocktracker/SharedPageLockTracker.java | 11 +++++++++++
.../pagelocktracker/ThreadPageLocksDumpLock.java | 4 ++++
.../dumpprocessors/ToStringDumpProcessor.java | 4 ++++
.../pagelocktracker/log/PageLockLogSnapshot.java | 14 ++++++++++++--
.../pagelocktracker/stack/PageLockStackSnapshot.java | 6 ++++++
.../pagelocktracker/store/HeapPageMetaInfoStore.java | 12 +++++++++++-
.../pagelocktracker/store/OffHeapPageMetaInfoStore.java | 11 ++++++++++-
.../processors/diagnostic/DiagnosticProcessor.java | 2 ++
.../visor/diagnostic/VisorPageLocksTrackerArgs.java | 12 ++++++++++++
.../pagelocktracker/SharedPageLockTrackerTest.java | 4 ++++
.../pagelocktracker/stack/PageLockStackTest.java | 1 +
17 files changed, 109 insertions(+), 5 deletions(-)
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java b/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java
index e6e6e1f..c89c8c2 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/commandline/diagnostic/PageLocksCommand.java
@@ -44,6 +44,7 @@ public class PageLocksCommand implements Command<PageLocksCommand.Args> {
*
*/
public static final String DUMP = "dump";
+
/**
*
*/
@@ -177,18 +178,22 @@ public class PageLocksCommand implements Command<PageLocksCommand.Args> {
*
*/
private final String op;
+
/**
*
*/
private final String type;
+
/**
*
*/
private final String filePath;
+
/**
*
*/
private final boolean allNodes;
+
/**
*
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStructure.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStructure.java
index c020f7d..e3c7eff 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStructure.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/DataStructure.java
@@ -40,6 +40,7 @@ import static org.apache.ignite.internal.pagemem.PageIdAllocator.FLAG_IDX;
import static org.apache.ignite.internal.pagemem.PageIdAllocator.INDEX_PARTITION;
import static org.apache.ignite.internal.pagemem.PageIdAllocator.MAX_PARTITION_ID;
import static org.apache.ignite.internal.pagemem.PageIdUtils.MAX_ITEMID_NUM;
+
/**
* Base class for all the data structures based on {@link PageMemory}.
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/InvalidContext.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/InvalidContext.java
index fd5a880..a0fb735 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/InvalidContext.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/InvalidContext.java
@@ -23,6 +23,7 @@ package org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagel
public class InvalidContext<T extends PageLockDump> {
/** */
public final String msg;
+
/** */
public final T dump;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/LockTrackerFactory.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/LockTrackerFactory.java
index bb9410f..ba97d86 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/LockTrackerFactory.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/LockTrackerFactory.java
@@ -41,14 +41,17 @@ public final class LockTrackerFactory {
*
*/
public static final int HEAP_STACK = 1;
+
/**
*
*/
public static final int HEAP_LOG = 2;
+
/**
*
*/
public static final int OFF_HEAP_STACK = 3;
+
/**
*
*/
@@ -58,6 +61,7 @@ public final class LockTrackerFactory {
*
*/
public static volatile int DEFAULT_CAPACITY = getInteger(IGNITE_PAGE_LOCK_TRACKER_CAPACITY, 512);
+
/**
*
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTracker.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTracker.java
index b8445f1..827f3c9 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTracker.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTracker.java
@@ -33,44 +33,61 @@ import static org.apache.ignite.internal.util.IgniteUtils.hexLong;
public abstract class PageLockTracker<T extends PageLockDump> implements PageLockListener, DumpSupported<T> {
/** */
private static final long OVERHEAD_SIZE = 16 + 8 + 8 + 4 + 4 + 4 + 8 + 8 + 4 + 4 + 8;
+
/** */
public static final int OP_OFFSET = 16;
+
/** */
public static final int LOCK_IDX_MASK = 0xFFFF0000;
+
/** */
public static final int LOCK_OP_MASK = 0x000000000000FF;
/** Page read lock operation id. */
public static final int READ_LOCK = 1;
+
/** Page read unlock operation id. */
public static final int READ_UNLOCK = 2;
+
/** Page write lock operation id. */
public static final int WRITE_LOCK = 3;
+
/** Page write unlock operation id. */
public static final int WRITE_UNLOCK = 4;
+
/** Page read before lock operation id. */
public static final int BEFORE_READ_LOCK = 5;
+
/** Page write before lock operation id. */
public static final int BEFORE_WRITE_LOCK = 6;
/** */
protected final String name;
+
/** */
protected final PageMetaInfoStore pages;
+
/** Counter for track lock/unlock operations. */
protected int heldLockCnt;
+
/** */
protected int nextOp;
+
/** */
protected int nextOpStructureId;
+
/** */
protected long nextOpPageId;
+
/** */
private long opCntr;
+
/** */
private volatile boolean dump;
+
/** */
private volatile boolean locked;
+
/** */
private volatile InvalidContext<T> invalidCtx;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTrackerManager.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTrackerManager.java
index ad186ae..ff2faa5 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTrackerManager.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/PageLockTrackerManager.java
@@ -62,6 +62,7 @@ public class PageLockTrackerManager implements LifecycleAware {
/** */
private final String managerNameId;
+ /** */
private final boolean trackingEnable;
@@ -73,7 +74,8 @@ public class PageLockTrackerManager implements LifecycleAware {
}
/**
- * Default constructor.
+ * @param log Ignite logger.
+ * @param managerNameId Manager name.
*/
public PageLockTrackerManager(IgniteLogger log, String managerNameId) {
this.trackingEnable = !(getInteger(IGNITE_PAGE_LOCK_TRACKER_TYPE, HEAP_LOG) == -1);
@@ -235,6 +237,7 @@ public class PageLockTrackerManager implements LifecycleAware {
public static class MemoryCalculator {
/** */
private final AtomicLong heapUsed = new AtomicLong();
+
/** */
private final AtomicLong offHeapUsed = new AtomicLong();
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java
index 3133311..679c230 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTracker.java
@@ -63,36 +63,45 @@ public class SharedPageLockTracker implements LifecycleAware, PageLockListener,
*
*/
public final int threadLimits;
+
/**
*
*/
public final int timeOutWorkerInterval;
+
/**
*
*/
private final Map<Long, PageLockTracker<? extends PageLockDump>> threadStacks = new HashMap<>();
+
/**
*
*/
private final Map<Long, Thread> threadIdToThreadRef = new HashMap<>();
+
/**
*
*/
private final Map<String, Integer> structureNameToId = new HashMap<>();
+
/** Thread for clean terminated threads from map. */
private final TimeOutWorker timeOutWorker = new TimeOutWorker();
+
/**
*
*/
private Map<Long, SharedPageLockTracker.State> prevThreadsState = new HashMap<>();
+
/**
*
*/
private int idGen;
+
/**
*
*/
private final Consumer<Set<SharedPageLockTracker.State>> hangThreadsCallBack;
+
/**
*
*/
@@ -392,10 +401,12 @@ public class SharedPageLockTracker implements LifecycleAware, PageLockListener,
*
*/
final long threadOpCnt;
+
/**
*
*/
final long heldLockCnt;
+
/**
*
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/ThreadPageLocksDumpLock.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/ThreadPageLocksDumpLock.java
index 1309cbe..01a5e6b 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/ThreadPageLocksDumpLock.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/ThreadPageLocksDumpLock.java
@@ -50,12 +50,16 @@ public class ThreadPageLocksDumpLock implements PageLockDump {
public static class ThreadState {
/** */
public final long threadId;
+
/** */
public final String threadName;
+
/** */
public final Thread.State state;
+
/** */
public final PageLockDump pageLockDump;
+
/** */
public final InvalidContext<? extends PageLockDump> invalidContext;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/dumpprocessors/ToStringDumpProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/dumpprocessors/ToStringDumpProcessor.java
index d26b66b..84e729f 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/dumpprocessors/ToStringDumpProcessor.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/dumpprocessors/ToStringDumpProcessor.java
@@ -84,6 +84,7 @@ public class ToStringDumpProcessor {
private static class ToStringHelper implements DumpProcessor {
/** */
private final Function<Integer, String> strucutreIdMapFunc;
+
/** */
private final StringBuilder sb;
@@ -95,7 +96,10 @@ public class ToStringDumpProcessor {
/** Helper class for track lock/unlock count. */
class LockState {
+ /** */
int readlock;
+
+ /** */
int writelock;
}
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/log/PageLockLogSnapshot.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/log/PageLockLogSnapshot.java
index 16c676d..c470285 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/log/PageLockLogSnapshot.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/log/PageLockLogSnapshot.java
@@ -19,11 +19,10 @@ package org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagel
import java.util.ArrayList;
import java.util.List;
-import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockDump;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.DumpProcessor;
+import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockDump;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageMetaInfoStore;
-import static org.apache.ignite.internal.pagemem.PageIdUtils.pageId;
import static org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTracker.LOCK_IDX_MASK;
import static org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTracker.LOCK_OP_MASK;
import static org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTracker.OP_OFFSET;
@@ -35,18 +34,25 @@ import static org.apache.ignite.internal.processors.cache.persistence.diagnostic
public class PageLockLogSnapshot implements PageLockDump {
/** Page lock log name. */
public final String name;
+
/** Creation time. */
public final long time;
+
/** Head position. */
public final int headIdx;
+
/** List of log entries. */
public final List<LogEntry> locklog;
+
/** */
public final PageMetaInfoStore log;
+
/** Next operation. */
public final int nextOp;
+
/** Next data structure. */
public final int nextOpStructureId;
+
/** Next page id. */
public final long nextOpPageId;
@@ -107,12 +113,16 @@ public class PageLockLogSnapshot implements PageLockDump {
public static class LogEntry {
/** */
public final long pageId;
+
/** */
public final int structureId;
+
/** */
public final int operation;
+
/** */
public final int holdedLocks;
+
/** */
public LogEntry(long pageId, int structureId, int operation, int holdedLock) {
this.pageId = pageId;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackSnapshot.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackSnapshot.java
index d4ff35e..9df3b3f 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackSnapshot.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackSnapshot.java
@@ -29,16 +29,22 @@ import static org.apache.ignite.internal.processors.cache.persistence.diagnostic
public class PageLockStackSnapshot implements PageLockDump {
/** */
public final String name;
+
/** */
public final long time;
+
/** */
public final int headIdx;
+
/** */
public final PageMetaInfoStore pageIdLocksStack;
+
/** */
public final int nextOp;
+
/** */
public final int nextOpStructureId;
+
/** */
public final long nextOpPageId;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/HeapPageMetaInfoStore.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/HeapPageMetaInfoStore.java
index 3cd6227..dc4d883 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/HeapPageMetaInfoStore.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/HeapPageMetaInfoStore.java
@@ -17,8 +17,8 @@
package org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.store;
-import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageMetaInfoStore;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTrackerManager.MemoryCalculator;
+import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageMetaInfoStore;
import org.jetbrains.annotations.Nullable;
/**
@@ -29,30 +29,37 @@ public class HeapPageMetaInfoStore implements PageMetaInfoStore {
*
*/
private static final int OVERHEAD_SIZE = 8 + 16 + 8 + 8;
+
/**
*
*/
private static final int PAGE_ID_OFFSET = 0;
+
/**
*
*/
private static final int PAGE_HEADER_ADDRESS_OFFSET = 1;
+
/**
*
*/
private static final int PAGE_ADDRESS_OFFSET = 2;
+
/**
*
*/
private static final int PAGE_META_OFFSET = 3;
+
/**
*
*/
private static final int ITEM_SIZE = 4;
+
/**
*
*/
private long[] arr;
+
/**
*
*/
@@ -69,6 +76,9 @@ public class HeapPageMetaInfoStore implements PageMetaInfoStore {
memoryCalc.onHeapAllocated(arr.length * 8 + OVERHEAD_SIZE);
}
+ /**
+ * @param arr Input array.
+ */
HeapPageMetaInfoStore(long[] arr) {
this.arr = arr;
memoryCalc = null;
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/OffHeapPageMetaInfoStore.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/OffHeapPageMetaInfoStore.java
index 6f7104f..4882daf 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/OffHeapPageMetaInfoStore.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/store/OffHeapPageMetaInfoStore.java
@@ -17,8 +17,8 @@
package org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.store;
-import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageMetaInfoStore;
import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageLockTrackerManager.MemoryCalculator;
+import org.apache.ignite.internal.processors.cache.persistence.diagnostic.pagelocktracker.PageMetaInfoStore;
import org.apache.ignite.internal.util.GridUnsafe;
import org.jetbrains.annotations.Nullable;
@@ -32,38 +32,47 @@ public class OffHeapPageMetaInfoStore implements PageMetaInfoStore {
*
*/
private static final long OVERHEAD_SIZE = 16 + 4 + 4 + 8 + 8;
+
/**
*
*/
private static final int PAGE_ID_OFFSET = 0;
+
/**
*
*/
private static final int PAGE_HEADER_ADDRESS_OFFSET = 8;
+
/**
*
*/
private static final int PAGE_ADDRESS_OFFSET = 16;
+
/**
*
*/
private static final int PAGE_META_OFFSET = 24;
+
/**
*
*/
private static final int ITEM_SIZE = 4;
+
/**
*
*/
private final int size;
+
/**
*
*/
private final int capacity;
+
/**
*
*/
private final long ptr;
+
/**
*
*/
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/processors/diagnostic/DiagnosticProcessor.java b/modules/core/src/main/java/org/apache/ignite/internal/processors/diagnostic/DiagnosticProcessor.java
index 07670f0..c8d143b 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/processors/diagnostic/DiagnosticProcessor.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/processors/diagnostic/DiagnosticProcessor.java
@@ -46,6 +46,7 @@ public class DiagnosticProcessor extends GridProcessorAdapter {
/** Value of the system property that enables page locks dumping on failure. */
private static final boolean IGNITE_DUMP_PAGE_LOCK_ON_FAILURE =
IgniteSystemProperties.getBoolean(IgniteSystemProperties.IGNITE_DUMP_PAGE_LOCK_ON_FAILURE, true);
+
/** Time formatter for dump file name. */
private static final DateTimeFormatter TIME_FORMATTER = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH-mm-ss_SSS");
@@ -61,6 +62,7 @@ public class DiagnosticProcessor extends GridProcessorAdapter {
/** Full path for store dubug info. */
private final Path diagnosticPath;
+ /** */
private final PageHistoryDiagnoster pageHistoryDiagnoster;
/**
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/visor/diagnostic/VisorPageLocksTrackerArgs.java b/modules/core/src/main/java/org/apache/ignite/internal/visor/diagnostic/VisorPageLocksTrackerArgs.java
index c394480..9478291 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/visor/diagnostic/VisorPageLocksTrackerArgs.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/visor/diagnostic/VisorPageLocksTrackerArgs.java
@@ -35,17 +35,29 @@ public class VisorPageLocksTrackerArgs extends IgniteDataTransferObject {
/** */
private String op;
+
/** */
private String type;
+
/** */
private String filePath;
+
/** */
@Nullable private Set<String> consistentIds;
+ /**
+ * Default constructor.
+ */
public VisorPageLocksTrackerArgs() {
}
+ /**
+ * @param op Operation.
+ * @param type Type.
+ * @param filePath File path.
+ * @param consistentIds Consistend id.
+ */
public VisorPageLocksTrackerArgs(String op, String type, String filePath, Set<String> consistentIds) {
this.op = op;
this.type = type;
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTrackerTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTrackerTest.java
index 2b92e5b..49869f7 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTrackerTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/SharedPageLockTrackerTest.java
@@ -502,14 +502,17 @@ public class SharedPageLockTrackerTest extends AbstractPageLockTest {
*
*/
final int structureId;
+
/**
*
*/
final long pageId;
+
/**
*
*/
final long page;
+
/**
*
*/
@@ -530,6 +533,7 @@ public class SharedPageLockTrackerTest extends AbstractPageLockTest {
this.pageAddr = pageAddr;
}
+ /** {@inheritDoc} */
@Override public String toString() {
return "PageMeta{" +
"structureId=" + structureId +
diff --git a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackTest.java b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackTest.java
index c89b352..397cfaa 100644
--- a/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackTest.java
+++ b/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/diagnostic/pagelocktracker/stack/PageLockStackTest.java
@@ -35,6 +35,7 @@ import static org.apache.ignite.internal.processors.cache.persistence.diagnostic
public abstract class PageLockStackTest extends AbstractPageLockTest {
/** */
protected static final int STRUCTURE_ID = 123;
+
/** */
protected abstract LockStack createLockStackTracer(String name);