You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2017/06/01 13:32:14 UTC

[1/2] commons-numbers git commit: Javadoc.

Repository: commons-numbers
Updated Branches:
  refs/heads/master c8e0a34f7 -> 40fd2b4eb


Javadoc.


Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/129df233
Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/129df233
Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/129df233

Branch: refs/heads/master
Commit: 129df233f4474b1fe114f4f91a67a56080b6efbf
Parents: c8e0a34
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
Authored: Thu Jun 1 15:30:39 2017 +0200
Committer: Gilles Sadowski <gi...@harfang.homelinux.org>
Committed: Thu Jun 1 15:30:39 2017 +0200

----------------------------------------------------------------------
 .../main/java/org/apache/commons/numbers/angle/PlaneAngle.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/129df233/commons-numbers-angle/src/main/java/org/apache/commons/numbers/angle/PlaneAngle.java
----------------------------------------------------------------------
diff --git a/commons-numbers-angle/src/main/java/org/apache/commons/numbers/angle/PlaneAngle.java b/commons-numbers-angle/src/main/java/org/apache/commons/numbers/angle/PlaneAngle.java
index cb8a637..b2ae51a 100644
--- a/commons-numbers-angle/src/main/java/org/apache/commons/numbers/angle/PlaneAngle.java
+++ b/commons-numbers-angle/src/main/java/org/apache/commons/numbers/angle/PlaneAngle.java
@@ -90,8 +90,8 @@ public class PlaneAngle {
      * center value.
      *
      * @param center Center of the desired interval for the result.
-     * @return {@code a - 2 * k} with integer {@code k} such that
-     * {@code center - 0.5 <= a - 2 * k <= center + 0.5} (in turns).
+     * @return {@code a - k} with integer {@code k} such that
+     * {@code center - 0.5 <= a - k <= center + 0.5} (in turns).
      */
     public PlaneAngle normalize(PlaneAngle center) {
         return new PlaneAngle(value - Math.floor(value + HALF_TURN - center.value));


[2/2] commons-numbers git commit: Cleanup (unit tests).

Posted by er...@apache.org.
Cleanup (unit tests).


Project: http://git-wip-us.apache.org/repos/asf/commons-numbers/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-numbers/commit/40fd2b4e
Tree: http://git-wip-us.apache.org/repos/asf/commons-numbers/tree/40fd2b4e
Diff: http://git-wip-us.apache.org/repos/asf/commons-numbers/diff/40fd2b4e

Branch: refs/heads/master
Commit: 40fd2b4eb86b2f29e8141e08bd4f6338c79a4743
Parents: 129df23
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
Authored: Thu Jun 1 15:31:03 2017 +0200
Committer: Gilles Sadowski <gi...@harfang.homelinux.org>
Committed: Thu Jun 1 15:31:03 2017 +0200

----------------------------------------------------------------------
 .../apache/commons/numbers/angle/PlaneAngleTest.java    | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-numbers/blob/40fd2b4e/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
----------------------------------------------------------------------
diff --git a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
index ca23e48..564190c 100644
--- a/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
+++ b/commons-numbers-angle/src/test/java/org/apache/commons/numbers/angle/PlaneAngleTest.java
@@ -24,21 +24,23 @@ public class PlaneAngleTest {
     public void testConversionTurns() {
         final double value = 12.3456;
         final PlaneAngle a = PlaneAngle.ofTurns(value);
-        Assert.assertEquals(value, a.toTurns(), Math.ulp(value));
+        Assert.assertEquals(value, a.toTurns(), 0d);
     }
 
     @Test
     public void testConversionRadians() {
-        final double value = 12.3456;
+        final double one = 2 * Math.PI;
+        final double value = 12.3456 * one;
         final PlaneAngle a = PlaneAngle.ofRadians(value);
-        Assert.assertEquals(value, a.toRadians(), Math.ulp(value));
+        Assert.assertEquals(value, a.toRadians(), 0d);
     }
 
     @Test
     public void testConversionDegrees() {
-        final double value = 12.3456;
+        final double one = 360;
+        final double value = 12.3456 * one;
         final PlaneAngle a = PlaneAngle.ofDegrees(value);
-        Assert.assertEquals(value, a.toDegrees(), Math.ulp(value));
+        Assert.assertEquals(value, a.toDegrees(), 0d);
     }
 
     @Test