[GitHub] [fineract] ptuomola commented on a change in pull request #1883: FINERACT-982 - Completely ditch use of Drizzle JDBC Driver after all

[GitBox <gi...@apache.org>]

ptuomola commented on a change in pull request #1883:
URL: https://github.com/apache/fineract/pull/1883#discussion_r741542754



##########
File path: build.gradle
##########
@@ -115,7 +115,7 @@ allprojects  {
             dependency 'com.google.truth.extensions:truth-java8-extension:1.1.3'
             dependency 'org.apache.commons:commons-email:1.5'
             dependency 'commons-io:commons-io:2.11.0'
-            dependency 'org.drizzle.jdbc:drizzle-jdbc:1.4'
+            dependency 'org.mariadb.jdbc:mariadb-java-client:2.7.3'
             dependency 'com.github.librepdf:openpdf:1.3.26'

Review comment:
       @IOhacker @avikganguly01 I wonder if we need the equivalent code if we are using MariaDB? A lot of the code is to handle Drizzle's peculiarities re return types. Now OpenJPA supports MariaDB "out of the box" so there may not be any need to customise the JDBC behaviour. 
   
   Also interesting... if we've dropped all dependencies to Drizzle but the code is doing casting based on the Drizzle classes, how does this still compile? I'd expect to get a compilation error. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org