You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/22 09:35:27 UTC
[GitHub] [arrow] AlenkaF opened a new pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
AlenkaF opened a new pull request #12485:
URL: https://github.com/apache/arrow/pull/12485
This PR updates the _developers/python.rst_ page with:
- use of console blocks instead of shell (when selecting the code text prompts are excluded),
- adding "" to the archery install comand,
It also adds `sphinx-copybutton` extension enabling the user to copy the content of the `code-block` with a copy button.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#issuecomment-1077510911
Benchmark runs are scheduled for baseline = fcf5c2ea42f9f479409fbd5c44c5c476b0ef9625 and contender = 864b54d5f317c046af3b8a6d58514853a465be8c. 864b54d5f317c046af3b8a6d58514853a465be8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22706d6312624329af0baac154b0e7f7...87305bb1b6c54821b849b226cfb95caf/)
[Finished :arrow_down:0.54% :arrow_up:1.47%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c34f957b1b4f48a3a7f33270a4029938...e4a5c0fb6991435ab8f5e2d304d74924/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ca2e02e2f96c465f8b86d7b3a3656ed5...24a937a8b47f4a27b597eeb49c4c62ef/)
[Finished :arrow_down:0.17% :arrow_up:0.26%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e2f179ac197940ecb4dec646800572d2...404f593bef7342f0a98b159de95fd32d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#issuecomment-1077510911
Benchmark runs are scheduled for baseline = fcf5c2ea42f9f479409fbd5c44c5c476b0ef9625 and contender = 864b54d5f317c046af3b8a6d58514853a465be8c. 864b54d5f317c046af3b8a6d58514853a465be8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22706d6312624329af0baac154b0e7f7...87305bb1b6c54821b849b226cfb95caf/)
[Finished :arrow_down:0.54% :arrow_up:1.47%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c34f957b1b4f48a3a7f33270a4029938...e4a5c0fb6991435ab8f5e2d304d74924/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ca2e02e2f96c465f8b86d7b3a3656ed5...24a937a8b47f4a27b597eeb49c4c62ef/)
[Finished :arrow_down:0.17% :arrow_up:0.26%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e2f179ac197940ecb4dec646800572d2...404f593bef7342f0a98b159de95fd32d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#discussion_r817528958
##########
File path: docs/source/developers/python.rst
##########
@@ -120,37 +121,37 @@ Xcode Command Line Tools (``xcode-select --install``) are sufficient.
On Linux, for this guide, we require a minimum of gcc 4.8, or clang 3.7 or
higher. You can check your version by running
-.. code-block:: console
+.. code-block::
Review comment:
It is because it is set to default ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#issuecomment-1077510911
Benchmark runs are scheduled for baseline = fcf5c2ea42f9f479409fbd5c44c5c476b0ef9625 and contender = 864b54d5f317c046af3b8a6d58514853a465be8c. 864b54d5f317c046af3b8a6d58514853a465be8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22706d6312624329af0baac154b0e7f7...87305bb1b6c54821b849b226cfb95caf/)
[Finished :arrow_down:0.54% :arrow_up:1.47%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c34f957b1b4f48a3a7f33270a4029938...e4a5c0fb6991435ab8f5e2d304d74924/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ca2e02e2f96c465f8b86d7b3a3656ed5...24a937a8b47f4a27b597eeb49c4c62ef/)
[Finished :arrow_down:0.17% :arrow_up:0.26%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e2f179ac197940ecb4dec646800572d2...404f593bef7342f0a98b159de95fd32d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #12485:
URL: https://github.com/apache/arrow/pull/12485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#issuecomment-1077510911
Benchmark runs are scheduled for baseline = fcf5c2ea42f9f479409fbd5c44c5c476b0ef9625 and contender = 864b54d5f317c046af3b8a6d58514853a465be8c. 864b54d5f317c046af3b8a6d58514853a465be8c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/22706d6312624329af0baac154b0e7f7...87305bb1b6c54821b849b226cfb95caf/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c34f957b1b4f48a3a7f33270a4029938...e4a5c0fb6991435ab8f5e2d304d74924/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ca2e02e2f96c465f8b86d7b3a3656ed5...24a937a8b47f4a27b597eeb49c4c62ef/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e2f179ac197940ecb4dec646800572d2...404f593bef7342f0a98b159de95fd32d/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#discussion_r816824877
##########
File path: docs/source/developers/python.rst
##########
@@ -120,37 +121,37 @@ Xcode Command Line Tools (``xcode-select --install``) are sufficient.
On Linux, for this guide, we require a minimum of gcc 4.8, or clang 3.7 or
higher. You can check your version by running
-.. code-block:: console
+.. code-block::
Review comment:
In the PR description, you mention "use of console blocks instead of shell", but this is actually removing "concole" as well. Is this because it is the default? Or because the sphinx-copybutton will ensure that the $ is not copy-able?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#issuecomment-1047599684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #12485: ARROW-15623: [C++][Python] Update developers/python.rst (console blocks + "" in archery install)
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #12485:
URL: https://github.com/apache/arrow/pull/12485#discussion_r817528958
##########
File path: docs/source/developers/python.rst
##########
@@ -120,37 +121,37 @@ Xcode Command Line Tools (``xcode-select --install``) are sufficient.
On Linux, for this guide, we require a minimum of gcc 4.8, or clang 3.7 or
higher. You can check your version by running
-.. code-block:: console
+.. code-block::
Review comment:
Hm, I think this is a mistake on my side (leftover before I set the default). Will delete and build the docs again to be sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org