[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6934: core: add JSON parser for ContentFile and FileScanTask

["RussellSpitzer (via GitHub)" <gi...@apache.org>]

RussellSpitzer commented on code in PR #6934:
URL: https://github.com/apache/iceberg/pull/6934#discussion_r1175466470


##########
core/src/main/java/org/apache/iceberg/BaseContentScanTask.java:
##########
@@ -52,12 +53,24 @@ public F file() {
     return file;
   }
 
+  protected Schema schema() {

Review Comment:
   Little odd that we reverse engineer the schema from the string here, but seems like the most backwards compatible thing we can do here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org