[GitHub] [incubator-kyuubi] jiaoqingbo commented on a diff in pull request #2286: [KYUUBI #2281] renewalExecutor should be stopped when Engine's side Delegation token is not supported

[GitBox <gi...@apache.org>]

jiaoqingbo commented on code in PR #2286:
URL: https://github.com/apache/incubator-kyuubi/pull/2286#discussion_r844558647


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -500,7 +500,7 @@ abstract class TFrontendService(name: String)
 
   private def notSupportTokenErrorStatus = {
     val errorStatus = new TStatus(TStatusCode.ERROR_STATUS)
-    errorStatus.setErrorMessage("Delegation token is not supported")
+    errorStatus.setErrorMessage(DELEGATION_TOKEN_IS_NOT_SUPPORTED)

Review Comment:
   > Is this change necessary? Or you can define it at test side
   
   I need to judge whether the Delegation token is not supported in the sendCredentials method of KyuubiSyncThriftClient.scala, if not set I need to use this string multiple times



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org