[jira] [Commented] (OPENNLP-963) Both AbstractTrainer and AbstractEventTrainer defined a reportMap

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838342#comment-15838342 ] 

ASF GitHub Bot commented on OPENNLP-963:
----------------------------------------

GitHub user danielruss opened a pull request:

    https://github.com/apache/opennlp/pull/89

    OPENNLP-963: Removed shadowing Map<> reportMap from AbstractEventTrainer

    Both the AbstractTrainer and AbstractEventTrainer have a reportMap.  The AbstractTrainer reportMap is shadowed and can throw a NullPointerException when the addToReport method is called.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danielruss/opennlp OpenNLP-963

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit efc82067fc38ee7ae47a66d36740a56d3c8224d5
Author: Daniel Russ <dr...@mail.nih.gov>
Date:   2017-01-25T18:38:05Z

    OPENNLP-963: Removed shadowing Map<> reportMap from AbstractEventTrainer

----


> Both AbstractTrainer and AbstractEventTrainer defined a reportMap
> -----------------------------------------------------------------
>
>                 Key: OPENNLP-963
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-963
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Machine Learning
>    Affects Versions: 1.7.1
>            Reporter: Russ, Daniel (NIH/CIT) [E]
>            Priority: Minor
>
> Both AbstractEventTrainer and AbstractTrainer hold a references to different reportMaps. This can cause a NullPointerException when addToReport is called. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)