You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/26 16:21:59 UTC

[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3248: Support set local region for RegionAwareEnsemblePlacementPolicy

StevenLuMT commented on code in PR #3248:
URL: https://github.com/apache/bookkeeper/pull/3248#discussion_r930175105


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RegionAwareEnsemblePlacementPolicy.java:
##########
@@ -173,6 +174,10 @@ public RegionAwareEnsemblePlacementPolicy initialize(ClientConfiguration conf,
         super.initialize(conf, optionalDnsResolver, timer, featureProvider, statsLogger, bookieAddressResolver)
                 .withDefaultRack(NetworkTopology.DEFAULT_REGION_AND_RACK);
         myRegion = getLocalRegion(localNode);
+        String localRegion = conf.getString(REPP_LOCAL_REGION, null);

Review Comment:
   simple code 
   `String localRegion = conf.getString(REPP_LOCAL_REGION);`
   instead of
   `String localRegion = conf.getString(REPP_LOCAL_REGION, null);`
   
   <img width="703" alt="image" src="https://user-images.githubusercontent.com/42990025/181058870-f6bc2165-ee33-494a-8a89-2afd88dcb60a.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org