You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/07 09:11:26 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5079: vxlan: Fix failure to delete vxlan
Pearl1594 opened a new pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
1. On a zone with VXLAN isolation type:
- Created an Isolated network
- Created a VM
- Deleted the VM - successfully deletes the Vxlan
```
2021-06-07 09:03:11,042 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-4:null) (logid:6f469f8f) Executing: /usr/share/cloudstack-common/scripts/vm/network/vnet/modifyvxlan.sh -o delete -v 1850 -p vx -b brvx-1850
2021-06-07 09:03:11,043 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-4:null) (logid:6f469f8f) Executing while with timeout : 1800000
2021-06-07 09:03:11,094 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-4:null) (logid:6f469f8f) Execution is successful.
```
2. Verified with VLAN isolation type to ensure no regression:
```
2021-06-07 08:59:12,143 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-1:null) (logid:4bd5fcfd) Executing: /usr/share/cloudstack-common/scripts/vm/network/vnet/modifyvlan.sh -o delete -v 1409 -p eth1 -b breth1-1409 -d true
2021-06-07 08:59:12,144 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-1:null) (logid:4bd5fcfd) Executing while with timeout : 1800000
2021-06-07 08:59:12,184 DEBUG [kvm.resource.BridgeVifDriver] (agentRequest-Handler-1:null) (logid:4bd5fcfd) Execution is successful.
```
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-864361741
<b>Trillian test result (tid-1012)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34024 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5079-t1012-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#discussion_r647414707
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
##########
@@ -376,7 +376,9 @@ private void deleteVnetBr(String brName, boolean deleteBr) {
command.add("-v", vNetId);
command.add("-p", pName);
command.add("-b", brName);
- command.add("-d", String.valueOf(deleteBr));
+ if (cmdout != null && !cmdout.contains("vxlan")) {
Review comment:
@Pearl1594 to be consistent with line 368, should it be the following here ?
```
if (cmdout == null || ! cmdout.contains("vxlan")) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855768936
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855795529
No @rhtyd - this was introduced with the persistent L2 network PR https://github.com/apache/cloudstack/pull/4561 - which was merged to master (4.16)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855788257
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855769772
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855787226
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855789084
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-867910408
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-867934720
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-867910195
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-863661469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-867934111
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-868256717
<b>Trillian test result (tid-1095)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33301 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5079-t1095-kvm-centos7.zip
Smoke tests completed. 88 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
weizhouapache merged pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-863661339
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-855790611
@Pearl1594 does this affect 4.15? Should the PR be accepted for 4.15.1.0 RC2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-864249755
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-867934227
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-856207592
<b>Trillian test result (tid-884)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33559 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5079-t884-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.17 | test_primary_storage.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#issuecomment-863726627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5079: vxlan: Fix failure to delete vxlan
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org