[GitHub] [doris] englefly commented on a diff in pull request #15326: [fix](nereids) fix some arrgregate bugs in Nereids

[GitBox <gi...@apache.org>]

englefly commented on code in PR #15326:
URL: https://github.com/apache/doris/pull/15326#discussion_r1057418856


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/PushdownExpressionsInHashCondition.java:
##########
@@ -79,7 +79,9 @@ public Rule build() {
                         exprsOfHashConjuncts.get(0).add(conjunct.child(0));
                         exprsOfHashConjuncts.get(1).add(conjunct.child(1));
                         conjunct.children().forEach(expr ->
-                                exprMap.put(expr, new Alias(expr, "expr_" + expr.toSql())));
+                                exprMap.put(expr,
+                                        expr instanceof Slot ? new Alias(((Slot) expr).getExprId(), expr, expr.toSql())

Review Comment:
   make this logical into Alias constructor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org