You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/18 15:15:47 UTC
[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull
request #3029: ARTEMIS-2664 Fix the delivered acks decrement.
michaelandrepearce commented on a change in pull request #3029: ARTEMIS-2664 Fix the delivered acks decrement.
URL: https://github.com/apache/activemq-artemis/pull/3029#discussion_r394424651
##########
File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
##########
@@ -68,7 +68,7 @@
private int prefetchSize;
private final AtomicInteger currentWindow;
- private final AtomicInteger deliveredAcks;
+ private int deliveredAcks;
Review comment:
please leave this atomic, to avoid concurrency visibility issues with different threads.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services