You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Øyvind A. Holm" <su...@sunbase.org> on 2004/07/02 06:26:05 UTC

[PATCH] Directory name missing on svn propset

When performing a "svn propset foo bar .", this happens:

$ svn ps foo bar .
property 'foo' set on ''

The ''’s are empty only when the file name is ".". The following patch
should fix it.


[[[
Print property name as '.' instead of '' when specifying . to
svn propset.

* subversion/clients/cmdline/propset-cmd.c
  (svn_cl__propset): Use svn_path_local_style() when printing the
    message.
]]]


Index: subversion/clients/cmdline/propset-cmd.c
===================================================================
--- subversion/clients/cmdline/propset-cmd.c	(revision 10122)
+++ subversion/clients/cmdline/propset-cmd.c	(working copy)
@@ -195,7 +195,7 @@
                  (pool, opt_state->recursive
                   ? _("property '%s' set (recursively) on '%s'\n")
                   : _("property '%s' set on '%s'\n"),
-                  pname, target));
+                  pname, svn_path_local_style (target, pool)));
             }
         }
       svn_pool_destroy (subpool);


Regards,
Øyvind A. Holm
---------------------
cat /dev/urandom >SCO

Re: [PATCH] Directory name missing on svn propset

Posted by "Øyvind A. Holm" <su...@sunbase.org>.
On 2004-07-02 08:26+0200 Øyvind A. Holm wrote:

> [[[
> Print property name as '.' instead of '' when specifying . to
> svn propset.
> 
> * subversion/clients/cmdline/propset-cmd.c
>   (svn_cl__propset): Use svn_path_local_style() when printing the
>     message.
> ]]]

Should of course be this:

[[[
Print directory name as '.' instead of '' when specifying . to
svn propset.

* subversion/clients/cmdline/propset-cmd.c
  (svn_cl__propset): Use svn_path_local_style() when printing the
    message.
]]]

Mvh,
Øyvind A. Holm
---------------------
cat /dev/urandom >SCO

Re: [PATCH] Directory name missing on svn propset

Posted by Branko Čibej <br...@xbc.nu>.
Thanks. Committed in r10125.

Øyvind A. Holm wrote:

>When performing a "svn propset foo bar .", this happens:
>
>$ svn ps foo bar .
>property 'foo' set on ''
>
>The ''’s are empty only when the file name is ".". The following patch
>should fix it.
>
>
>[[[
>Print property name as '.' instead of '' when specifying . to
>svn propset.
>
>* subversion/clients/cmdline/propset-cmd.c
>  (svn_cl__propset): Use svn_path_local_style() when printing the
>    message.
>]]]
>
>
>Index: subversion/clients/cmdline/propset-cmd.c
>===================================================================
>--- subversion/clients/cmdline/propset-cmd.c	(revision 10122)
>+++ subversion/clients/cmdline/propset-cmd.c	(working copy)
>@@ -195,7 +195,7 @@
>                  (pool, opt_state->recursive
>                   ? _("property '%s' set (recursively) on '%s'\n")
>                   : _("property '%s' set on '%s'\n"),
>-                  pname, target));
>+                  pname, svn_path_local_style (target, pool)));
>             }
>         }
>       svn_pool_destroy (subpool);
>
>
>Regards,
>Øyvind A. Holm
>---------------------
>cat /dev/urandom >SCO
>  
>
-- Brane


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org