You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/15 18:50:49 UTC
[GitHub] [superset] Antonio-RiveroMartnez opened a new pull request, #21922: feat: CSV File Upload form updates
Antonio-RiveroMartnez opened a new pull request, #21922:
URL: https://github.com/apache/superset/pull/21922
### SUMMARY
This is going to be the first of a set of PRs to improve the experience for our users in the CSV file upload form. Here we are reordering some fields of the form and changing their Name and descriptions.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/38889534/198689750-2996d449-af67-43f6-b75f-94c79c913960.mov
After:
https://user-images.githubusercontent.com/38889534/198690113-03a711d0-f903-484e-a844-cae9fda8a8eb.mov
### TESTING INSTRUCTIONS
1. Open the CSV file upload form
2. Check the form matches the proposed changes
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21922: [Draft] feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1289355406
# [Codecov](https://codecov.io/gh/apache/superset/pull/21922?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21922](https://codecov.io/gh/apache/superset/pull/21922?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ec1f525) into [master](https://codecov.io/gh/apache/superset/commit/a36ab71a2793bd9dc51f3234b502ab43b0d304a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a36ab71) will **decrease** coverage by `1.22%`.
> The diff coverage is `70.58%`.
```diff
@@ Coverage Diff @@
## master #21922 +/- ##
==========================================
- Coverage 66.87% 65.65% -1.23%
==========================================
Files 1807 1807
Lines 69142 69142
Branches 7394 7394
==========================================
- Hits 46237 45393 -844
- Misses 20995 21839 +844
Partials 1910 1910
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.92% <70.58%> (ø)` | |
| postgres | `78.40% <70.58%> (-0.01%)` | :arrow_down: |
| presto | `52.82% <70.58%> (ø)` | |
| python | `78.84% <70.58%> (-2.53%)` | :arrow_down: |
| sqlite | `76.90% <70.58%> (?)` | |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21922?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `31.36% <0.00%> (ø)` | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `85.71% <100.00%> (ø)` | |
| [superset/tables/schemas.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFibGVzL3NjaGVtYXMucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/columns/schemas.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29sdW1ucy9zY2hlbWFzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/advanced\_data\_type/plugins/internet\_address.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfYWRkcmVzcy5weQ==) | `16.32% <0.00%> (-79.60%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/boxplot.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2JveHBsb3QucHk=) | `20.51% <0.00%> (-79.49%)` | :arrow_down: |
| [superset/charts/post\_processing.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3Bvc3RfcHJvY2Vzc2luZy5weQ==) | `11.76% <0.00%> (-77.95%)` | :arrow_down: |
| [...perset/advanced\_data\_type/plugins/internet\_port.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYWR2YW5jZWRfZGF0YV90eXBlL3BsdWdpbnMvaW50ZXJuZXRfcG9ydC5weQ==) | `18.75% <0.00%> (-77.09%)` | :arrow_down: |
| [superset/utils/pandas\_postprocessing/rolling.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL3JvbGxpbmcucHk=) | `21.87% <0.00%> (-68.75%)` | :arrow_down: |
| [...perset/utils/pandas\_postprocessing/contribution.py](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2NvbnRyaWJ1dGlvbi5weQ==) | `34.61% <0.00%> (-65.39%)` | :arrow_down: |
| ... and [56 more](https://codecov.io/gh/apache/superset/pull/21922/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1298824618
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1315926835
@jinghua-qa Ephemeral environment spinning up at http://34.217.78.232:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1298887624
@eschutho Ephemeral environment spinning up at http://35.90.79.196:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez closed pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez closed pull request #21922: feat: CSV File Upload form updates
URL: https://github.com/apache/superset/pull/21922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #21922:
URL: https://github.com/apache/superset/pull/21922#discussion_r1010807662
##########
superset/views/database/forms.py:
##########
@@ -133,129 +124,136 @@ class CsvToDatabaseForm(UploadToDatabaseForm):
),
],
)
- con = QuerySelectField(
+ table_name = StringField(
+ _("Table Name"),
+ description=_("Name of table to be created with CSV file"),
+ validators=[
+ DataRequired(),
+ Regexp(r"^[^\.]+$", message=_("Table name cannot contain a schema")),
+ ],
+ widget=BS3TextFieldWidget(),
+ )
+ database = QuerySelectField(
_("Database"),
+ description=_("Select a database to upload the file to"),
query_factory=UploadToDatabaseForm.file_allowed_dbs,
get_pk=lambda a: a.id,
get_label=lambda a: a.database_name,
)
schema = StringField(
_("Schema"),
- description=_("Specify a schema (if database flavor supports this)."),
+ description=_("Select a schema if the database supports this"),
validators=[Optional()],
widget=BS3TextFieldWidget(),
)
- sep = StringField(
+ delimiter = StringField(
_("Delimiter"),
- description=_("Delimiter used by CSV file (for whitespace use \\s+)."),
+ description=_("Enter a delimiter for this data"),
validators=[DataRequired()],
widget=BS3TextFieldWidget(),
)
if_exists = SelectField(
- _("Table Exists"),
- description=_(
- "If table exists do one of the following: "
- "Fail (do nothing), Replace (drop and recreate table) "
- "or Append (insert data)."
- ),
+ _("If Table Already Exists"),
+ description=_("What should happen if the table already exists"),
choices=[
("fail", _("Fail")),
("replace", _("Replace")),
("append", _("Append")),
],
validators=[DataRequired()],
)
- header = IntegerField(
- _("Header Row"),
- description=_(
- "Row containing the headers to use as "
- "column names (0 is first line of data). "
- "Leave empty if there is no header row."
- ),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- index_col = IntegerField(
- _("Index Column"),
- description=_(
- "Column to use as the row labels of the "
- "dataframe. Leave empty if no index column."
- ),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- mangle_dupe_cols = BooleanField(
- _("Mangle Duplicate Columns"),
- description=_('Specify duplicate columns as "X.0, X.1".'),
- )
- usecols = JsonListField(
- _("Use Columns"),
- default=None,
- description=_(
- "Json list of the column names that should be read. "
- "If not None, only these columns will be read from the file."
- ),
- validators=[Optional()],
- )
- skipinitialspace = BooleanField(
- _("Skip Initial Space"), description=_("Skip spaces after delimiter.")
- )
- skiprows = IntegerField(
- _("Skip Rows"),
- description=_("Number of rows to skip at start of file."),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- nrows = IntegerField(
- _("Rows to Read"),
- description=_("Number of rows of file to read."),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
+ skip_initial_space = BooleanField(
+ _("Skip Initial Space"), description=_("Skip spaces after delimiter")
)
skip_blank_lines = BooleanField(
_("Skip Blank Lines"),
- description=_("Skip blank lines rather than interpreting them as NaN values."),
+ description=_(
+ "Skip blank lines rather than interpreting them as Not A Number values"
+ ),
)
parse_dates = CommaSeparatedListField(
- _("Parse Dates"),
+ _("Columns To Be Parsed as Dates"),
description=_(
- "A comma separated list of columns that should be parsed as dates."
+ "A comma separated list of columns that should be parsed as dates"
),
filters=[filter_not_empty_values],
)
infer_datetime_format = BooleanField(
- _("Infer Datetime Format"),
- description=_("Use Pandas to interpret the datetime format automatically."),
+ _("Interpret Datetime Format Automatically"),
+ description=_("Interpret the datetime format automatically"),
)
decimal = StringField(
_("Decimal Character"),
default=".",
- description=_("Character to interpret as decimal point."),
+ description=_("Character to interpret as decimal point"),
validators=[Optional(), Length(min=1, max=1)],
widget=BS3TextFieldWidget(),
)
- index = BooleanField(
- _("Dataframe Index"), description=_("Write dataframe index as a column.")
+ null_values = JsonListField(
+ _("Null Values"),
+ default=config["CSV_DEFAULT_NA_NAMES"],
+ description=_(
+ "Json list of the values that should be treated as null. "
+ 'Examples: [""], ["None", "N/A"], ["nan", "null"]. '
+ "Warning: Hive database supports only single value"
Review Comment:
Oh Thanks! Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1315922338
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
hughhhh merged PR #21922:
URL: https://github.com/apache/superset/pull/21922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1322270458
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] andrey-zayats commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
andrey-zayats commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1322149657
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #21922:
URL: https://github.com/apache/superset/pull/21922#discussion_r1010661982
##########
superset/views/database/forms.py:
##########
@@ -133,129 +124,136 @@ class CsvToDatabaseForm(UploadToDatabaseForm):
),
],
)
- con = QuerySelectField(
+ table_name = StringField(
+ _("Table Name"),
+ description=_("Name of table to be created with CSV file"),
+ validators=[
+ DataRequired(),
+ Regexp(r"^[^\.]+$", message=_("Table name cannot contain a schema")),
+ ],
+ widget=BS3TextFieldWidget(),
+ )
+ database = QuerySelectField(
_("Database"),
+ description=_("Select a database to upload the file to"),
query_factory=UploadToDatabaseForm.file_allowed_dbs,
get_pk=lambda a: a.id,
get_label=lambda a: a.database_name,
)
schema = StringField(
_("Schema"),
- description=_("Specify a schema (if database flavor supports this)."),
+ description=_("Select a schema if the database supports this"),
validators=[Optional()],
widget=BS3TextFieldWidget(),
)
- sep = StringField(
+ delimiter = StringField(
_("Delimiter"),
- description=_("Delimiter used by CSV file (for whitespace use \\s+)."),
+ description=_("Enter a delimiter for this data"),
validators=[DataRequired()],
widget=BS3TextFieldWidget(),
)
if_exists = SelectField(
- _("Table Exists"),
- description=_(
- "If table exists do one of the following: "
- "Fail (do nothing), Replace (drop and recreate table) "
- "or Append (insert data)."
- ),
+ _("If Table Already Exists"),
+ description=_("What should happen if the table already exists"),
choices=[
("fail", _("Fail")),
("replace", _("Replace")),
("append", _("Append")),
],
validators=[DataRequired()],
)
- header = IntegerField(
- _("Header Row"),
- description=_(
- "Row containing the headers to use as "
- "column names (0 is first line of data). "
- "Leave empty if there is no header row."
- ),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- index_col = IntegerField(
- _("Index Column"),
- description=_(
- "Column to use as the row labels of the "
- "dataframe. Leave empty if no index column."
- ),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- mangle_dupe_cols = BooleanField(
- _("Mangle Duplicate Columns"),
- description=_('Specify duplicate columns as "X.0, X.1".'),
- )
- usecols = JsonListField(
- _("Use Columns"),
- default=None,
- description=_(
- "Json list of the column names that should be read. "
- "If not None, only these columns will be read from the file."
- ),
- validators=[Optional()],
- )
- skipinitialspace = BooleanField(
- _("Skip Initial Space"), description=_("Skip spaces after delimiter.")
- )
- skiprows = IntegerField(
- _("Skip Rows"),
- description=_("Number of rows to skip at start of file."),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
- )
- nrows = IntegerField(
- _("Rows to Read"),
- description=_("Number of rows of file to read."),
- validators=[Optional(), NumberRange(min=0)],
- widget=BS3TextFieldWidget(),
+ skip_initial_space = BooleanField(
+ _("Skip Initial Space"), description=_("Skip spaces after delimiter")
)
skip_blank_lines = BooleanField(
_("Skip Blank Lines"),
- description=_("Skip blank lines rather than interpreting them as NaN values."),
+ description=_(
+ "Skip blank lines rather than interpreting them as Not A Number values"
+ ),
)
parse_dates = CommaSeparatedListField(
- _("Parse Dates"),
+ _("Columns To Be Parsed as Dates"),
description=_(
- "A comma separated list of columns that should be parsed as dates."
+ "A comma separated list of columns that should be parsed as dates"
),
filters=[filter_not_empty_values],
)
infer_datetime_format = BooleanField(
- _("Infer Datetime Format"),
- description=_("Use Pandas to interpret the datetime format automatically."),
+ _("Interpret Datetime Format Automatically"),
+ description=_("Interpret the datetime format automatically"),
)
decimal = StringField(
_("Decimal Character"),
default=".",
- description=_("Character to interpret as decimal point."),
+ description=_("Character to interpret as decimal point"),
validators=[Optional(), Length(min=1, max=1)],
widget=BS3TextFieldWidget(),
)
- index = BooleanField(
- _("Dataframe Index"), description=_("Write dataframe index as a column.")
+ null_values = JsonListField(
+ _("Null Values"),
+ default=config["CSV_DEFAULT_NA_NAMES"],
+ description=_(
+ "Json list of the values that should be treated as null. "
+ 'Examples: [""], ["None", "N/A"], ["nan", "null"]. '
+ "Warning: Hive database supports only single value"
Review Comment:
nit typo in existing text.. should this be "only a single value"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21922:
URL: https://github.com/apache/superset/pull/21922#issuecomment-1315728865
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez closed pull request #21922: feat: CSV File Upload form updates
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez closed pull request #21922: feat: CSV File Upload form updates
URL: https://github.com/apache/superset/pull/21922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org