You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/25 22:01:24 UTC

[GitHub] [beam] shehzaadn-vd commented on a change in pull request #13660: [BEAM-10961] Enable strict dependency on Google Cloud Dataflow runner

shehzaadn-vd commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r583232558



##########
File path: runners/google-cloud-dataflow-java/build.gradle
##########
@@ -78,18 +79,25 @@ dependencies {
   compile library.java.google_api_client
   compile library.java.google_api_services_clouddebugger
   compile library.java.google_api_services_dataflow
-  compile library.java.google_api_services_storage
+  testImplementation 'com.google.apis:google-api-services-storage:v1-rev20200611-1.30.10'
   compile library.java.google_auth_library_credentials
   compile library.java.google_auth_library_oauth2_http
   compile library.java.google_http_client
-  compile library.java.google_http_client_jackson2
+  testImplementation 'com.google.http-client:google-http-client-jackson2:1.34.0'
   compile library.java.jackson_annotations
   compile library.java.jackson_core
   compile library.java.jackson_databind
   compile library.java.joda_time
   compile library.java.slf4j_api
   compile library.java.vendored_grpc_1_26_0
-  testCompile library.java.hamcrest_core
+  compile "org.checkerframework:checker-qual:2.0.0"
+  compile "org.hamcrest:hamcrest:2.1"
+  compile "com.google.auth:google-auth-library-credentials:0.19.0"
+  permitUnusedDeclared "com.google.guava:guava:25.1-jre"
+  permitUnusedDeclared "io.opencensus:opencensus-api:0.24.0"
+  compile "org.checkerframework:checker-qual:2.0.0"

Review comment:
       @ibzib this change block is outdated (there's no checker-qual declaration anymore)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org