You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/10/24 14:55:16 UTC
[42/51] [partial] hbase-site git commit: Published site at
3fe8649b2c9ba1271c25e8f476548907e4c7a90d.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/8f09a71d/devapidocs/src-html/org/apache/hadoop/hbase/master/CatalogJanitor.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/master/CatalogJanitor.html b/devapidocs/src-html/org/apache/hadoop/hbase/master/CatalogJanitor.html
index 1814633..02f25e8 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/master/CatalogJanitor.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/master/CatalogJanitor.html
@@ -119,355 +119,357 @@
<span class="sourceLineNo">111</span> protected void chore() {<a name="line.111"></a>
<span class="sourceLineNo">112</span> try {<a name="line.112"></a>
<span class="sourceLineNo">113</span> AssignmentManager am = this.services.getAssignmentManager();<a name="line.113"></a>
-<span class="sourceLineNo">114</span> if (this.enabled.get() && !this.services.isInMaintenanceMode() && am != null &&<a name="line.114"></a>
-<span class="sourceLineNo">115</span> am.isMetaLoaded() && !am.hasRegionsInTransition()) {<a name="line.115"></a>
-<span class="sourceLineNo">116</span> scan();<a name="line.116"></a>
-<span class="sourceLineNo">117</span> } else {<a name="line.117"></a>
-<span class="sourceLineNo">118</span> LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +<a name="line.118"></a>
-<span class="sourceLineNo">119</span> ", maintenanceMode=" + this.services.isInMaintenanceMode() + ", am=" + am +<a name="line.119"></a>
-<span class="sourceLineNo">120</span> ", metaLoaded=" + (am != null && am.isMetaLoaded()) + ", hasRIT=" +<a name="line.120"></a>
-<span class="sourceLineNo">121</span> (am != null && am.hasRegionsInTransition()));<a name="line.121"></a>
-<span class="sourceLineNo">122</span> }<a name="line.122"></a>
-<span class="sourceLineNo">123</span> } catch (IOException e) {<a name="line.123"></a>
-<span class="sourceLineNo">124</span> LOG.warn("Failed scan of catalog table", e);<a name="line.124"></a>
-<span class="sourceLineNo">125</span> }<a name="line.125"></a>
-<span class="sourceLineNo">126</span> }<a name="line.126"></a>
-<span class="sourceLineNo">127</span><a name="line.127"></a>
-<span class="sourceLineNo">128</span> /**<a name="line.128"></a>
-<span class="sourceLineNo">129</span> * Scans hbase:meta and returns a number of scanned rows, and a map of merged<a name="line.129"></a>
-<span class="sourceLineNo">130</span> * regions, and an ordered map of split parents.<a name="line.130"></a>
-<span class="sourceLineNo">131</span> * @return triple of scanned rows, map of merged regions and map of split<a name="line.131"></a>
-<span class="sourceLineNo">132</span> * parent regioninfos<a name="line.132"></a>
-<span class="sourceLineNo">133</span> * @throws IOException<a name="line.133"></a>
-<span class="sourceLineNo">134</span> */<a name="line.134"></a>
-<span class="sourceLineNo">135</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>><a name="line.135"></a>
-<span class="sourceLineNo">136</span> getMergedRegionsAndSplitParents() throws IOException {<a name="line.136"></a>
-<span class="sourceLineNo">137</span> return getMergedRegionsAndSplitParents(null);<a name="line.137"></a>
-<span class="sourceLineNo">138</span> }<a name="line.138"></a>
-<span class="sourceLineNo">139</span><a name="line.139"></a>
-<span class="sourceLineNo">140</span> /**<a name="line.140"></a>
-<span class="sourceLineNo">141</span> * Scans hbase:meta and returns a number of scanned rows, and a map of merged<a name="line.141"></a>
-<span class="sourceLineNo">142</span> * regions, and an ordered map of split parents. if the given table name is<a name="line.142"></a>
-<span class="sourceLineNo">143</span> * null, return merged regions and split parents of all tables, else only the<a name="line.143"></a>
-<span class="sourceLineNo">144</span> * specified table<a name="line.144"></a>
-<span class="sourceLineNo">145</span> * @param tableName null represents all tables<a name="line.145"></a>
-<span class="sourceLineNo">146</span> * @return triple of scanned rows, and map of merged regions, and map of split<a name="line.146"></a>
-<span class="sourceLineNo">147</span> * parent regioninfos<a name="line.147"></a>
-<span class="sourceLineNo">148</span> * @throws IOException<a name="line.148"></a>
-<span class="sourceLineNo">149</span> */<a name="line.149"></a>
-<span class="sourceLineNo">150</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>><a name="line.150"></a>
-<span class="sourceLineNo">151</span> getMergedRegionsAndSplitParents(final TableName tableName) throws IOException {<a name="line.151"></a>
-<span class="sourceLineNo">152</span> final boolean isTableSpecified = (tableName != null);<a name="line.152"></a>
-<span class="sourceLineNo">153</span> // TODO: Only works with single hbase:meta region currently. Fix.<a name="line.153"></a>
-<span class="sourceLineNo">154</span> final AtomicInteger count = new AtomicInteger(0);<a name="line.154"></a>
-<span class="sourceLineNo">155</span> // Keep Map of found split parents. There are candidates for cleanup.<a name="line.155"></a>
-<span class="sourceLineNo">156</span> // Use a comparator that has split parents come before its daughters.<a name="line.156"></a>
-<span class="sourceLineNo">157</span> final Map<RegionInfo, Result> splitParents = new TreeMap<>(new SplitParentFirstComparator());<a name="line.157"></a>
-<span class="sourceLineNo">158</span> final Map<RegionInfo, Result> mergedRegions = new TreeMap<>(RegionInfo.COMPARATOR);<a name="line.158"></a>
-<span class="sourceLineNo">159</span> // This visitor collects split parents and counts rows in the hbase:meta table<a name="line.159"></a>
-<span class="sourceLineNo">160</span><a name="line.160"></a>
-<span class="sourceLineNo">161</span> MetaTableAccessor.Visitor visitor = new MetaTableAccessor.Visitor() {<a name="line.161"></a>
-<span class="sourceLineNo">162</span> @Override<a name="line.162"></a>
-<span class="sourceLineNo">163</span> public boolean visit(Result r) throws IOException {<a name="line.163"></a>
-<span class="sourceLineNo">164</span> if (r == null || r.isEmpty()) return true;<a name="line.164"></a>
-<span class="sourceLineNo">165</span> count.incrementAndGet();<a name="line.165"></a>
-<span class="sourceLineNo">166</span> RegionInfo info = MetaTableAccessor.getRegionInfo(r);<a name="line.166"></a>
-<span class="sourceLineNo">167</span> if (info == null) return true; // Keep scanning<a name="line.167"></a>
-<span class="sourceLineNo">168</span> if (isTableSpecified<a name="line.168"></a>
-<span class="sourceLineNo">169</span> && info.getTable().compareTo(tableName) > 0) {<a name="line.169"></a>
-<span class="sourceLineNo">170</span> // Another table, stop scanning<a name="line.170"></a>
-<span class="sourceLineNo">171</span> return false;<a name="line.171"></a>
-<span class="sourceLineNo">172</span> }<a name="line.172"></a>
-<span class="sourceLineNo">173</span> if (LOG.isTraceEnabled()) LOG.trace("" + info + " IS-SPLIT_PARENT=" + info.isSplitParent());<a name="line.173"></a>
-<span class="sourceLineNo">174</span> if (info.isSplitParent()) splitParents.put(info, r);<a name="line.174"></a>
-<span class="sourceLineNo">175</span> if (r.getValue(HConstants.CATALOG_FAMILY, HConstants.MERGEA_QUALIFIER) != null) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> mergedRegions.put(info, r);<a name="line.176"></a>
-<span class="sourceLineNo">177</span> }<a name="line.177"></a>
-<span class="sourceLineNo">178</span> // Returning true means "keep scanning"<a name="line.178"></a>
-<span class="sourceLineNo">179</span> return true;<a name="line.179"></a>
-<span class="sourceLineNo">180</span> }<a name="line.180"></a>
-<span class="sourceLineNo">181</span> };<a name="line.181"></a>
-<span class="sourceLineNo">182</span><a name="line.182"></a>
-<span class="sourceLineNo">183</span> // Run full scan of hbase:meta catalog table passing in our custom visitor with<a name="line.183"></a>
-<span class="sourceLineNo">184</span> // the start row<a name="line.184"></a>
-<span class="sourceLineNo">185</span> MetaTableAccessor.scanMetaForTableRegions(this.connection, visitor, tableName);<a name="line.185"></a>
-<span class="sourceLineNo">186</span><a name="line.186"></a>
-<span class="sourceLineNo">187</span> return new Triple<>(count.get(), mergedRegions, splitParents);<a name="line.187"></a>
-<span class="sourceLineNo">188</span> }<a name="line.188"></a>
-<span class="sourceLineNo">189</span><a name="line.189"></a>
-<span class="sourceLineNo">190</span> /**<a name="line.190"></a>
-<span class="sourceLineNo">191</span> * If merged region no longer holds reference to the merge regions, archive<a name="line.191"></a>
-<span class="sourceLineNo">192</span> * merge region on hdfs and perform deleting references in hbase:meta<a name="line.192"></a>
-<span class="sourceLineNo">193</span> * @param mergedRegion<a name="line.193"></a>
-<span class="sourceLineNo">194</span> * @return true if we delete references in merged region on hbase:meta and archive<a name="line.194"></a>
-<span class="sourceLineNo">195</span> * the files on the file system<a name="line.195"></a>
-<span class="sourceLineNo">196</span> * @throws IOException<a name="line.196"></a>
-<span class="sourceLineNo">197</span> */<a name="line.197"></a>
-<span class="sourceLineNo">198</span> boolean cleanMergeRegion(final RegionInfo mergedRegion,<a name="line.198"></a>
-<span class="sourceLineNo">199</span> final RegionInfo regionA, final RegionInfo regionB) throws IOException {<a name="line.199"></a>
-<span class="sourceLineNo">200</span> FileSystem fs = this.services.getMasterFileSystem().getFileSystem();<a name="line.200"></a>
-<span class="sourceLineNo">201</span> Path rootdir = this.services.getMasterFileSystem().getRootDir();<a name="line.201"></a>
-<span class="sourceLineNo">202</span> Path tabledir = FSUtils.getTableDir(rootdir, mergedRegion.getTable());<a name="line.202"></a>
-<span class="sourceLineNo">203</span> TableDescriptor htd = getTableDescriptor(mergedRegion.getTable());<a name="line.203"></a>
-<span class="sourceLineNo">204</span> HRegionFileSystem regionFs = null;<a name="line.204"></a>
-<span class="sourceLineNo">205</span> try {<a name="line.205"></a>
-<span class="sourceLineNo">206</span> regionFs = HRegionFileSystem.openRegionFromFileSystem(<a name="line.206"></a>
-<span class="sourceLineNo">207</span> this.services.getConfiguration(), fs, tabledir, mergedRegion, true);<a name="line.207"></a>
-<span class="sourceLineNo">208</span> } catch (IOException e) {<a name="line.208"></a>
-<span class="sourceLineNo">209</span> LOG.warn("Merged region does not exist: " + mergedRegion.getEncodedName());<a name="line.209"></a>
-<span class="sourceLineNo">210</span> }<a name="line.210"></a>
-<span class="sourceLineNo">211</span> if (regionFs == null || !regionFs.hasReferences(htd)) {<a name="line.211"></a>
-<span class="sourceLineNo">212</span> LOG.debug("Deleting region " + regionA.getShortNameToLog() + " and "<a name="line.212"></a>
-<span class="sourceLineNo">213</span> + regionB.getShortNameToLog()<a name="line.213"></a>
-<span class="sourceLineNo">214</span> + " from fs because merged region no longer holds references");<a name="line.214"></a>
-<span class="sourceLineNo">215</span> ProcedureExecutor<MasterProcedureEnv> pe = this.services.getMasterProcedureExecutor();<a name="line.215"></a>
-<span class="sourceLineNo">216</span> pe.submitProcedure(new GCMergedRegionsProcedure(pe.getEnvironment(),<a name="line.216"></a>
-<span class="sourceLineNo">217</span> mergedRegion, regionA, regionB));<a name="line.217"></a>
-<span class="sourceLineNo">218</span> // Remove from in-memory states<a name="line.218"></a>
-<span class="sourceLineNo">219</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(regionA);<a name="line.219"></a>
-<span class="sourceLineNo">220</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(regionB);<a name="line.220"></a>
-<span class="sourceLineNo">221</span> this.services.getServerManager().removeRegion(regionA);<a name="line.221"></a>
-<span class="sourceLineNo">222</span> this.services.getServerManager().removeRegion(regionB);<a name="line.222"></a>
-<span class="sourceLineNo">223</span> return true;<a name="line.223"></a>
-<span class="sourceLineNo">224</span> }<a name="line.224"></a>
-<span class="sourceLineNo">225</span> return false;<a name="line.225"></a>
-<span class="sourceLineNo">226</span> }<a name="line.226"></a>
-<span class="sourceLineNo">227</span><a name="line.227"></a>
-<span class="sourceLineNo">228</span> /**<a name="line.228"></a>
-<span class="sourceLineNo">229</span> * Run janitorial scan of catalog <code>hbase:meta</code> table looking for<a name="line.229"></a>
-<span class="sourceLineNo">230</span> * garbage to collect.<a name="line.230"></a>
-<span class="sourceLineNo">231</span> * @return number of archiving jobs started.<a name="line.231"></a>
-<span class="sourceLineNo">232</span> * @throws IOException<a name="line.232"></a>
-<span class="sourceLineNo">233</span> */<a name="line.233"></a>
-<span class="sourceLineNo">234</span> int scan() throws IOException {<a name="line.234"></a>
-<span class="sourceLineNo">235</span> int result = 0;<a name="line.235"></a>
-<span class="sourceLineNo">236</span><a name="line.236"></a>
-<span class="sourceLineNo">237</span> try {<a name="line.237"></a>
-<span class="sourceLineNo">238</span> if (!alreadyRunning.compareAndSet(false, true)) {<a name="line.238"></a>
-<span class="sourceLineNo">239</span> LOG.debug("CatalogJanitor already running");<a name="line.239"></a>
-<span class="sourceLineNo">240</span> return result;<a name="line.240"></a>
-<span class="sourceLineNo">241</span> }<a name="line.241"></a>
-<span class="sourceLineNo">242</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>> scanTriple =<a name="line.242"></a>
-<span class="sourceLineNo">243</span> getMergedRegionsAndSplitParents();<a name="line.243"></a>
-<span class="sourceLineNo">244</span> /**<a name="line.244"></a>
-<span class="sourceLineNo">245</span> * clean merge regions first<a name="line.245"></a>
-<span class="sourceLineNo">246</span> */<a name="line.246"></a>
-<span class="sourceLineNo">247</span> Map<RegionInfo, Result> mergedRegions = scanTriple.getSecond();<a name="line.247"></a>
-<span class="sourceLineNo">248</span> for (Map.Entry<RegionInfo, Result> e : mergedRegions.entrySet()) {<a name="line.248"></a>
-<span class="sourceLineNo">249</span> if (this.services.isInMaintenanceMode()) {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> // Stop cleaning if the master is in maintenance mode<a name="line.250"></a>
-<span class="sourceLineNo">251</span> break;<a name="line.251"></a>
-<span class="sourceLineNo">252</span> }<a name="line.252"></a>
-<span class="sourceLineNo">253</span><a name="line.253"></a>
-<span class="sourceLineNo">254</span> PairOfSameType<RegionInfo> p = MetaTableAccessor.getMergeRegions(e.getValue());<a name="line.254"></a>
-<span class="sourceLineNo">255</span> RegionInfo regionA = p.getFirst();<a name="line.255"></a>
-<span class="sourceLineNo">256</span> RegionInfo regionB = p.getSecond();<a name="line.256"></a>
-<span class="sourceLineNo">257</span> if (regionA == null || regionB == null) {<a name="line.257"></a>
-<span class="sourceLineNo">258</span> LOG.warn("Unexpected references regionA="<a name="line.258"></a>
-<span class="sourceLineNo">259</span> + (regionA == null ? "null" : regionA.getShortNameToLog())<a name="line.259"></a>
-<span class="sourceLineNo">260</span> + ",regionB="<a name="line.260"></a>
-<span class="sourceLineNo">261</span> + (regionB == null ? "null" : regionB.getShortNameToLog())<a name="line.261"></a>
-<span class="sourceLineNo">262</span> + " in merged region " + e.getKey().getShortNameToLog());<a name="line.262"></a>
-<span class="sourceLineNo">263</span> } else {<a name="line.263"></a>
-<span class="sourceLineNo">264</span> if (cleanMergeRegion(e.getKey(), regionA, regionB)) {<a name="line.264"></a>
-<span class="sourceLineNo">265</span> result++;<a name="line.265"></a>
-<span class="sourceLineNo">266</span> }<a name="line.266"></a>
-<span class="sourceLineNo">267</span> }<a name="line.267"></a>
-<span class="sourceLineNo">268</span> }<a name="line.268"></a>
-<span class="sourceLineNo">269</span> /**<a name="line.269"></a>
-<span class="sourceLineNo">270</span> * clean split parents<a name="line.270"></a>
-<span class="sourceLineNo">271</span> */<a name="line.271"></a>
-<span class="sourceLineNo">272</span> Map<RegionInfo, Result> splitParents = scanTriple.getThird();<a name="line.272"></a>
-<span class="sourceLineNo">273</span><a name="line.273"></a>
-<span class="sourceLineNo">274</span> // Now work on our list of found parents. See if any we can clean up.<a name="line.274"></a>
-<span class="sourceLineNo">275</span> // regions whose parents are still around<a name="line.275"></a>
-<span class="sourceLineNo">276</span> HashSet<String> parentNotCleaned = new HashSet<>();<a name="line.276"></a>
-<span class="sourceLineNo">277</span> for (Map.Entry<RegionInfo, Result> e : splitParents.entrySet()) {<a name="line.277"></a>
-<span class="sourceLineNo">278</span> if (this.services.isInMaintenanceMode()) {<a name="line.278"></a>
-<span class="sourceLineNo">279</span> // Stop cleaning if the master is in maintenance mode<a name="line.279"></a>
-<span class="sourceLineNo">280</span> break;<a name="line.280"></a>
-<span class="sourceLineNo">281</span> }<a name="line.281"></a>
-<span class="sourceLineNo">282</span><a name="line.282"></a>
-<span class="sourceLineNo">283</span> if (!parentNotCleaned.contains(e.getKey().getEncodedName()) &&<a name="line.283"></a>
-<span class="sourceLineNo">284</span> cleanParent(e.getKey(), e.getValue())) {<a name="line.284"></a>
-<span class="sourceLineNo">285</span> result++;<a name="line.285"></a>
-<span class="sourceLineNo">286</span> } else {<a name="line.286"></a>
-<span class="sourceLineNo">287</span> // We could not clean the parent, so it's daughters should not be<a name="line.287"></a>
-<span class="sourceLineNo">288</span> // cleaned either (HBASE-6160)<a name="line.288"></a>
-<span class="sourceLineNo">289</span> PairOfSameType<RegionInfo> daughters =<a name="line.289"></a>
-<span class="sourceLineNo">290</span> MetaTableAccessor.getDaughterRegions(e.getValue());<a name="line.290"></a>
-<span class="sourceLineNo">291</span> parentNotCleaned.add(daughters.getFirst().getEncodedName());<a name="line.291"></a>
-<span class="sourceLineNo">292</span> parentNotCleaned.add(daughters.getSecond().getEncodedName());<a name="line.292"></a>
-<span class="sourceLineNo">293</span> }<a name="line.293"></a>
-<span class="sourceLineNo">294</span> }<a name="line.294"></a>
-<span class="sourceLineNo">295</span> return result;<a name="line.295"></a>
-<span class="sourceLineNo">296</span> } finally {<a name="line.296"></a>
-<span class="sourceLineNo">297</span> alreadyRunning.set(false);<a name="line.297"></a>
-<span class="sourceLineNo">298</span> }<a name="line.298"></a>
-<span class="sourceLineNo">299</span> }<a name="line.299"></a>
-<span class="sourceLineNo">300</span><a name="line.300"></a>
-<span class="sourceLineNo">301</span> /**<a name="line.301"></a>
-<span class="sourceLineNo">302</span> * Compare HRegionInfos in a way that has split parents sort BEFORE their<a name="line.302"></a>
-<span class="sourceLineNo">303</span> * daughters.<a name="line.303"></a>
-<span class="sourceLineNo">304</span> */<a name="line.304"></a>
-<span class="sourceLineNo">305</span> static class SplitParentFirstComparator implements Comparator<RegionInfo> {<a name="line.305"></a>
-<span class="sourceLineNo">306</span> Comparator<byte[]> rowEndKeyComparator = new Bytes.RowEndKeyComparator();<a name="line.306"></a>
-<span class="sourceLineNo">307</span> @Override<a name="line.307"></a>
-<span class="sourceLineNo">308</span> public int compare(RegionInfo left, RegionInfo right) {<a name="line.308"></a>
-<span class="sourceLineNo">309</span> // This comparator differs from the one RegionInfo in that it sorts<a name="line.309"></a>
-<span class="sourceLineNo">310</span> // parent before daughters.<a name="line.310"></a>
-<span class="sourceLineNo">311</span> if (left == null) return -1;<a name="line.311"></a>
-<span class="sourceLineNo">312</span> if (right == null) return 1;<a name="line.312"></a>
-<span class="sourceLineNo">313</span> // Same table name.<a name="line.313"></a>
-<span class="sourceLineNo">314</span> int result = left.getTable().compareTo(right.getTable());<a name="line.314"></a>
-<span class="sourceLineNo">315</span> if (result != 0) return result;<a name="line.315"></a>
-<span class="sourceLineNo">316</span> // Compare start keys.<a name="line.316"></a>
-<span class="sourceLineNo">317</span> result = Bytes.compareTo(left.getStartKey(), right.getStartKey());<a name="line.317"></a>
-<span class="sourceLineNo">318</span> if (result != 0) return result;<a name="line.318"></a>
-<span class="sourceLineNo">319</span> // Compare end keys, but flip the operands so parent comes first<a name="line.319"></a>
-<span class="sourceLineNo">320</span> result = rowEndKeyComparator.compare(right.getEndKey(), left.getEndKey());<a name="line.320"></a>
-<span class="sourceLineNo">321</span><a name="line.321"></a>
-<span class="sourceLineNo">322</span> return result;<a name="line.322"></a>
-<span class="sourceLineNo">323</span> }<a name="line.323"></a>
-<span class="sourceLineNo">324</span> }<a name="line.324"></a>
-<span class="sourceLineNo">325</span><a name="line.325"></a>
-<span class="sourceLineNo">326</span> /**<a name="line.326"></a>
-<span class="sourceLineNo">327</span> * If daughters no longer hold reference to the parents, delete the parent.<a name="line.327"></a>
-<span class="sourceLineNo">328</span> * @param parent RegionInfo of split offlined parent<a name="line.328"></a>
-<span class="sourceLineNo">329</span> * @param rowContent Content of <code>parent</code> row in<a name="line.329"></a>
-<span class="sourceLineNo">330</span> * <code>metaRegionName</code><a name="line.330"></a>
-<span class="sourceLineNo">331</span> * @return True if we removed <code>parent</code> from meta table and from<a name="line.331"></a>
-<span class="sourceLineNo">332</span> * the filesystem.<a name="line.332"></a>
-<span class="sourceLineNo">333</span> * @throws IOException<a name="line.333"></a>
-<span class="sourceLineNo">334</span> */<a name="line.334"></a>
-<span class="sourceLineNo">335</span> boolean cleanParent(final RegionInfo parent, Result rowContent)<a name="line.335"></a>
-<span class="sourceLineNo">336</span> throws IOException {<a name="line.336"></a>
-<span class="sourceLineNo">337</span> // Check whether it is a merged region and not clean reference<a name="line.337"></a>
-<span class="sourceLineNo">338</span> // No necessary to check MERGEB_QUALIFIER because these two qualifiers will<a name="line.338"></a>
-<span class="sourceLineNo">339</span> // be inserted/deleted together<a name="line.339"></a>
-<span class="sourceLineNo">340</span> if (rowContent.getValue(HConstants.CATALOG_FAMILY, HConstants.MERGEA_QUALIFIER) != null) {<a name="line.340"></a>
-<span class="sourceLineNo">341</span> // wait cleaning merge region first<a name="line.341"></a>
-<span class="sourceLineNo">342</span> return false;<a name="line.342"></a>
-<span class="sourceLineNo">343</span> }<a name="line.343"></a>
-<span class="sourceLineNo">344</span> // Run checks on each daughter split.<a name="line.344"></a>
-<span class="sourceLineNo">345</span> PairOfSameType<RegionInfo> daughters = MetaTableAccessor.getDaughterRegions(rowContent);<a name="line.345"></a>
-<span class="sourceLineNo">346</span> Pair<Boolean, Boolean> a = checkDaughterInFs(parent, daughters.getFirst());<a name="line.346"></a>
-<span class="sourceLineNo">347</span> Pair<Boolean, Boolean> b = checkDaughterInFs(parent, daughters.getSecond());<a name="line.347"></a>
-<span class="sourceLineNo">348</span> if (hasNoReferences(a) && hasNoReferences(b)) {<a name="line.348"></a>
-<span class="sourceLineNo">349</span> String daughterA = daughters.getFirst() != null?<a name="line.349"></a>
-<span class="sourceLineNo">350</span> daughters.getFirst().getShortNameToLog(): "null";<a name="line.350"></a>
-<span class="sourceLineNo">351</span> String daughterB = daughters.getSecond() != null?<a name="line.351"></a>
-<span class="sourceLineNo">352</span> daughters.getSecond().getShortNameToLog(): "null";<a name="line.352"></a>
-<span class="sourceLineNo">353</span> LOG.debug("Deleting region " + parent.getShortNameToLog() +<a name="line.353"></a>
-<span class="sourceLineNo">354</span> " because daughters -- " + daughterA + ", " + daughterB +<a name="line.354"></a>
-<span class="sourceLineNo">355</span> " -- no longer hold references");<a name="line.355"></a>
-<span class="sourceLineNo">356</span> ProcedureExecutor<MasterProcedureEnv> pe = this.services.getMasterProcedureExecutor();<a name="line.356"></a>
-<span class="sourceLineNo">357</span> pe.submitProcedure(new GCRegionProcedure(pe.getEnvironment(), parent));<a name="line.357"></a>
-<span class="sourceLineNo">358</span> // Remove from in-memory states<a name="line.358"></a>
-<span class="sourceLineNo">359</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(parent);<a name="line.359"></a>
-<span class="sourceLineNo">360</span> this.services.getServerManager().removeRegion(parent);<a name="line.360"></a>
-<span class="sourceLineNo">361</span> return true;<a name="line.361"></a>
-<span class="sourceLineNo">362</span> }<a name="line.362"></a>
-<span class="sourceLineNo">363</span> return false;<a name="line.363"></a>
-<span class="sourceLineNo">364</span> }<a name="line.364"></a>
-<span class="sourceLineNo">365</span><a name="line.365"></a>
-<span class="sourceLineNo">366</span> /**<a name="line.366"></a>
-<span class="sourceLineNo">367</span> * @param p A pair where the first boolean says whether or not the daughter<a name="line.367"></a>
-<span class="sourceLineNo">368</span> * region directory exists in the filesystem and then the second boolean says<a name="line.368"></a>
-<span class="sourceLineNo">369</span> * whether the daughter has references to the parent.<a name="line.369"></a>
-<span class="sourceLineNo">370</span> * @return True the passed <code>p</code> signifies no references.<a name="line.370"></a>
-<span class="sourceLineNo">371</span> */<a name="line.371"></a>
-<span class="sourceLineNo">372</span> private boolean hasNoReferences(final Pair<Boolean, Boolean> p) {<a name="line.372"></a>
-<span class="sourceLineNo">373</span> return !p.getFirst() || !p.getSecond();<a name="line.373"></a>
-<span class="sourceLineNo">374</span> }<a name="line.374"></a>
-<span class="sourceLineNo">375</span><a name="line.375"></a>
-<span class="sourceLineNo">376</span> /**<a name="line.376"></a>
-<span class="sourceLineNo">377</span> * Checks if a daughter region -- either splitA or splitB -- still holds<a name="line.377"></a>
-<span class="sourceLineNo">378</span> * references to parent.<a name="line.378"></a>
-<span class="sourceLineNo">379</span> * @param parent Parent region<a name="line.379"></a>
-<span class="sourceLineNo">380</span> * @param daughter Daughter region<a name="line.380"></a>
-<span class="sourceLineNo">381</span> * @return A pair where the first boolean says whether or not the daughter<a name="line.381"></a>
-<span class="sourceLineNo">382</span> * region directory exists in the filesystem and then the second boolean says<a name="line.382"></a>
-<span class="sourceLineNo">383</span> * whether the daughter has references to the parent.<a name="line.383"></a>
-<span class="sourceLineNo">384</span> * @throws IOException<a name="line.384"></a>
-<span class="sourceLineNo">385</span> */<a name="line.385"></a>
-<span class="sourceLineNo">386</span> Pair<Boolean, Boolean> checkDaughterInFs(final RegionInfo parent, final RegionInfo daughter)<a name="line.386"></a>
-<span class="sourceLineNo">387</span> throws IOException {<a name="line.387"></a>
-<span class="sourceLineNo">388</span> if (daughter == null) {<a name="line.388"></a>
-<span class="sourceLineNo">389</span> return new Pair<>(Boolean.FALSE, Boolean.FALSE);<a name="line.389"></a>
-<span class="sourceLineNo">390</span> }<a name="line.390"></a>
-<span class="sourceLineNo">391</span><a name="line.391"></a>
-<span class="sourceLineNo">392</span> FileSystem fs = this.services.getMasterFileSystem().getFileSystem();<a name="line.392"></a>
-<span class="sourceLineNo">393</span> Path rootdir = this.services.getMasterFileSystem().getRootDir();<a name="line.393"></a>
-<span class="sourceLineNo">394</span> Path tabledir = FSUtils.getTableDir(rootdir, daughter.getTable());<a name="line.394"></a>
-<span class="sourceLineNo">395</span><a name="line.395"></a>
-<span class="sourceLineNo">396</span> Path daughterRegionDir = new Path(tabledir, daughter.getEncodedName());<a name="line.396"></a>
+<span class="sourceLineNo">114</span> if (this.enabled.get() && !this.services.isInMaintenanceMode() &&<a name="line.114"></a>
+<span class="sourceLineNo">115</span> !this.services.getServerManager().isClusterShutdown() && am != null &&<a name="line.115"></a>
+<span class="sourceLineNo">116</span> am.isMetaLoaded() && !am.hasRegionsInTransition()) {<a name="line.116"></a>
+<span class="sourceLineNo">117</span> scan();<a name="line.117"></a>
+<span class="sourceLineNo">118</span> } else {<a name="line.118"></a>
+<span class="sourceLineNo">119</span> LOG.warn("CatalogJanitor is disabled! Enabled=" + this.enabled.get() +<a name="line.119"></a>
+<span class="sourceLineNo">120</span> ", maintenanceMode=" + this.services.isInMaintenanceMode() + ", am=" + am +<a name="line.120"></a>
+<span class="sourceLineNo">121</span> ", metaLoaded=" + (am != null && am.isMetaLoaded()) + ", hasRIT=" +<a name="line.121"></a>
+<span class="sourceLineNo">122</span> (am != null && am.hasRegionsInTransition()) + " clusterShutDown=" + this.services<a name="line.122"></a>
+<span class="sourceLineNo">123</span> .getServerManager().isClusterShutdown());<a name="line.123"></a>
+<span class="sourceLineNo">124</span> }<a name="line.124"></a>
+<span class="sourceLineNo">125</span> } catch (IOException e) {<a name="line.125"></a>
+<span class="sourceLineNo">126</span> LOG.warn("Failed scan of catalog table", e);<a name="line.126"></a>
+<span class="sourceLineNo">127</span> }<a name="line.127"></a>
+<span class="sourceLineNo">128</span> }<a name="line.128"></a>
+<span class="sourceLineNo">129</span><a name="line.129"></a>
+<span class="sourceLineNo">130</span> /**<a name="line.130"></a>
+<span class="sourceLineNo">131</span> * Scans hbase:meta and returns a number of scanned rows, and a map of merged<a name="line.131"></a>
+<span class="sourceLineNo">132</span> * regions, and an ordered map of split parents.<a name="line.132"></a>
+<span class="sourceLineNo">133</span> * @return triple of scanned rows, map of merged regions and map of split<a name="line.133"></a>
+<span class="sourceLineNo">134</span> * parent regioninfos<a name="line.134"></a>
+<span class="sourceLineNo">135</span> * @throws IOException<a name="line.135"></a>
+<span class="sourceLineNo">136</span> */<a name="line.136"></a>
+<span class="sourceLineNo">137</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>><a name="line.137"></a>
+<span class="sourceLineNo">138</span> getMergedRegionsAndSplitParents() throws IOException {<a name="line.138"></a>
+<span class="sourceLineNo">139</span> return getMergedRegionsAndSplitParents(null);<a name="line.139"></a>
+<span class="sourceLineNo">140</span> }<a name="line.140"></a>
+<span class="sourceLineNo">141</span><a name="line.141"></a>
+<span class="sourceLineNo">142</span> /**<a name="line.142"></a>
+<span class="sourceLineNo">143</span> * Scans hbase:meta and returns a number of scanned rows, and a map of merged<a name="line.143"></a>
+<span class="sourceLineNo">144</span> * regions, and an ordered map of split parents. if the given table name is<a name="line.144"></a>
+<span class="sourceLineNo">145</span> * null, return merged regions and split parents of all tables, else only the<a name="line.145"></a>
+<span class="sourceLineNo">146</span> * specified table<a name="line.146"></a>
+<span class="sourceLineNo">147</span> * @param tableName null represents all tables<a name="line.147"></a>
+<span class="sourceLineNo">148</span> * @return triple of scanned rows, and map of merged regions, and map of split<a name="line.148"></a>
+<span class="sourceLineNo">149</span> * parent regioninfos<a name="line.149"></a>
+<span class="sourceLineNo">150</span> * @throws IOException<a name="line.150"></a>
+<span class="sourceLineNo">151</span> */<a name="line.151"></a>
+<span class="sourceLineNo">152</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>><a name="line.152"></a>
+<span class="sourceLineNo">153</span> getMergedRegionsAndSplitParents(final TableName tableName) throws IOException {<a name="line.153"></a>
+<span class="sourceLineNo">154</span> final boolean isTableSpecified = (tableName != null);<a name="line.154"></a>
+<span class="sourceLineNo">155</span> // TODO: Only works with single hbase:meta region currently. Fix.<a name="line.155"></a>
+<span class="sourceLineNo">156</span> final AtomicInteger count = new AtomicInteger(0);<a name="line.156"></a>
+<span class="sourceLineNo">157</span> // Keep Map of found split parents. There are candidates for cleanup.<a name="line.157"></a>
+<span class="sourceLineNo">158</span> // Use a comparator that has split parents come before its daughters.<a name="line.158"></a>
+<span class="sourceLineNo">159</span> final Map<RegionInfo, Result> splitParents = new TreeMap<>(new SplitParentFirstComparator());<a name="line.159"></a>
+<span class="sourceLineNo">160</span> final Map<RegionInfo, Result> mergedRegions = new TreeMap<>(RegionInfo.COMPARATOR);<a name="line.160"></a>
+<span class="sourceLineNo">161</span> // This visitor collects split parents and counts rows in the hbase:meta table<a name="line.161"></a>
+<span class="sourceLineNo">162</span><a name="line.162"></a>
+<span class="sourceLineNo">163</span> MetaTableAccessor.Visitor visitor = new MetaTableAccessor.Visitor() {<a name="line.163"></a>
+<span class="sourceLineNo">164</span> @Override<a name="line.164"></a>
+<span class="sourceLineNo">165</span> public boolean visit(Result r) throws IOException {<a name="line.165"></a>
+<span class="sourceLineNo">166</span> if (r == null || r.isEmpty()) return true;<a name="line.166"></a>
+<span class="sourceLineNo">167</span> count.incrementAndGet();<a name="line.167"></a>
+<span class="sourceLineNo">168</span> RegionInfo info = MetaTableAccessor.getRegionInfo(r);<a name="line.168"></a>
+<span class="sourceLineNo">169</span> if (info == null) return true; // Keep scanning<a name="line.169"></a>
+<span class="sourceLineNo">170</span> if (isTableSpecified<a name="line.170"></a>
+<span class="sourceLineNo">171</span> && info.getTable().compareTo(tableName) > 0) {<a name="line.171"></a>
+<span class="sourceLineNo">172</span> // Another table, stop scanning<a name="line.172"></a>
+<span class="sourceLineNo">173</span> return false;<a name="line.173"></a>
+<span class="sourceLineNo">174</span> }<a name="line.174"></a>
+<span class="sourceLineNo">175</span> if (LOG.isTraceEnabled()) LOG.trace("" + info + " IS-SPLIT_PARENT=" + info.isSplitParent());<a name="line.175"></a>
+<span class="sourceLineNo">176</span> if (info.isSplitParent()) splitParents.put(info, r);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> if (r.getValue(HConstants.CATALOG_FAMILY, HConstants.MERGEA_QUALIFIER) != null) {<a name="line.177"></a>
+<span class="sourceLineNo">178</span> mergedRegions.put(info, r);<a name="line.178"></a>
+<span class="sourceLineNo">179</span> }<a name="line.179"></a>
+<span class="sourceLineNo">180</span> // Returning true means "keep scanning"<a name="line.180"></a>
+<span class="sourceLineNo">181</span> return true;<a name="line.181"></a>
+<span class="sourceLineNo">182</span> }<a name="line.182"></a>
+<span class="sourceLineNo">183</span> };<a name="line.183"></a>
+<span class="sourceLineNo">184</span><a name="line.184"></a>
+<span class="sourceLineNo">185</span> // Run full scan of hbase:meta catalog table passing in our custom visitor with<a name="line.185"></a>
+<span class="sourceLineNo">186</span> // the start row<a name="line.186"></a>
+<span class="sourceLineNo">187</span> MetaTableAccessor.scanMetaForTableRegions(this.connection, visitor, tableName);<a name="line.187"></a>
+<span class="sourceLineNo">188</span><a name="line.188"></a>
+<span class="sourceLineNo">189</span> return new Triple<>(count.get(), mergedRegions, splitParents);<a name="line.189"></a>
+<span class="sourceLineNo">190</span> }<a name="line.190"></a>
+<span class="sourceLineNo">191</span><a name="line.191"></a>
+<span class="sourceLineNo">192</span> /**<a name="line.192"></a>
+<span class="sourceLineNo">193</span> * If merged region no longer holds reference to the merge regions, archive<a name="line.193"></a>
+<span class="sourceLineNo">194</span> * merge region on hdfs and perform deleting references in hbase:meta<a name="line.194"></a>
+<span class="sourceLineNo">195</span> * @param mergedRegion<a name="line.195"></a>
+<span class="sourceLineNo">196</span> * @return true if we delete references in merged region on hbase:meta and archive<a name="line.196"></a>
+<span class="sourceLineNo">197</span> * the files on the file system<a name="line.197"></a>
+<span class="sourceLineNo">198</span> * @throws IOException<a name="line.198"></a>
+<span class="sourceLineNo">199</span> */<a name="line.199"></a>
+<span class="sourceLineNo">200</span> boolean cleanMergeRegion(final RegionInfo mergedRegion,<a name="line.200"></a>
+<span class="sourceLineNo">201</span> final RegionInfo regionA, final RegionInfo regionB) throws IOException {<a name="line.201"></a>
+<span class="sourceLineNo">202</span> FileSystem fs = this.services.getMasterFileSystem().getFileSystem();<a name="line.202"></a>
+<span class="sourceLineNo">203</span> Path rootdir = this.services.getMasterFileSystem().getRootDir();<a name="line.203"></a>
+<span class="sourceLineNo">204</span> Path tabledir = FSUtils.getTableDir(rootdir, mergedRegion.getTable());<a name="line.204"></a>
+<span class="sourceLineNo">205</span> TableDescriptor htd = getTableDescriptor(mergedRegion.getTable());<a name="line.205"></a>
+<span class="sourceLineNo">206</span> HRegionFileSystem regionFs = null;<a name="line.206"></a>
+<span class="sourceLineNo">207</span> try {<a name="line.207"></a>
+<span class="sourceLineNo">208</span> regionFs = HRegionFileSystem.openRegionFromFileSystem(<a name="line.208"></a>
+<span class="sourceLineNo">209</span> this.services.getConfiguration(), fs, tabledir, mergedRegion, true);<a name="line.209"></a>
+<span class="sourceLineNo">210</span> } catch (IOException e) {<a name="line.210"></a>
+<span class="sourceLineNo">211</span> LOG.warn("Merged region does not exist: " + mergedRegion.getEncodedName());<a name="line.211"></a>
+<span class="sourceLineNo">212</span> }<a name="line.212"></a>
+<span class="sourceLineNo">213</span> if (regionFs == null || !regionFs.hasReferences(htd)) {<a name="line.213"></a>
+<span class="sourceLineNo">214</span> LOG.debug("Deleting region " + regionA.getShortNameToLog() + " and "<a name="line.214"></a>
+<span class="sourceLineNo">215</span> + regionB.getShortNameToLog()<a name="line.215"></a>
+<span class="sourceLineNo">216</span> + " from fs because merged region no longer holds references");<a name="line.216"></a>
+<span class="sourceLineNo">217</span> ProcedureExecutor<MasterProcedureEnv> pe = this.services.getMasterProcedureExecutor();<a name="line.217"></a>
+<span class="sourceLineNo">218</span> pe.submitProcedure(new GCMergedRegionsProcedure(pe.getEnvironment(),<a name="line.218"></a>
+<span class="sourceLineNo">219</span> mergedRegion, regionA, regionB));<a name="line.219"></a>
+<span class="sourceLineNo">220</span> // Remove from in-memory states<a name="line.220"></a>
+<span class="sourceLineNo">221</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(regionA);<a name="line.221"></a>
+<span class="sourceLineNo">222</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(regionB);<a name="line.222"></a>
+<span class="sourceLineNo">223</span> this.services.getServerManager().removeRegion(regionA);<a name="line.223"></a>
+<span class="sourceLineNo">224</span> this.services.getServerManager().removeRegion(regionB);<a name="line.224"></a>
+<span class="sourceLineNo">225</span> return true;<a name="line.225"></a>
+<span class="sourceLineNo">226</span> }<a name="line.226"></a>
+<span class="sourceLineNo">227</span> return false;<a name="line.227"></a>
+<span class="sourceLineNo">228</span> }<a name="line.228"></a>
+<span class="sourceLineNo">229</span><a name="line.229"></a>
+<span class="sourceLineNo">230</span> /**<a name="line.230"></a>
+<span class="sourceLineNo">231</span> * Run janitorial scan of catalog <code>hbase:meta</code> table looking for<a name="line.231"></a>
+<span class="sourceLineNo">232</span> * garbage to collect.<a name="line.232"></a>
+<span class="sourceLineNo">233</span> * @return number of archiving jobs started.<a name="line.233"></a>
+<span class="sourceLineNo">234</span> * @throws IOException<a name="line.234"></a>
+<span class="sourceLineNo">235</span> */<a name="line.235"></a>
+<span class="sourceLineNo">236</span> int scan() throws IOException {<a name="line.236"></a>
+<span class="sourceLineNo">237</span> int result = 0;<a name="line.237"></a>
+<span class="sourceLineNo">238</span><a name="line.238"></a>
+<span class="sourceLineNo">239</span> try {<a name="line.239"></a>
+<span class="sourceLineNo">240</span> if (!alreadyRunning.compareAndSet(false, true)) {<a name="line.240"></a>
+<span class="sourceLineNo">241</span> LOG.debug("CatalogJanitor already running");<a name="line.241"></a>
+<span class="sourceLineNo">242</span> return result;<a name="line.242"></a>
+<span class="sourceLineNo">243</span> }<a name="line.243"></a>
+<span class="sourceLineNo">244</span> Triple<Integer, Map<RegionInfo, Result>, Map<RegionInfo, Result>> scanTriple =<a name="line.244"></a>
+<span class="sourceLineNo">245</span> getMergedRegionsAndSplitParents();<a name="line.245"></a>
+<span class="sourceLineNo">246</span> /**<a name="line.246"></a>
+<span class="sourceLineNo">247</span> * clean merge regions first<a name="line.247"></a>
+<span class="sourceLineNo">248</span> */<a name="line.248"></a>
+<span class="sourceLineNo">249</span> Map<RegionInfo, Result> mergedRegions = scanTriple.getSecond();<a name="line.249"></a>
+<span class="sourceLineNo">250</span> for (Map.Entry<RegionInfo, Result> e : mergedRegions.entrySet()) {<a name="line.250"></a>
+<span class="sourceLineNo">251</span> if (this.services.isInMaintenanceMode()) {<a name="line.251"></a>
+<span class="sourceLineNo">252</span> // Stop cleaning if the master is in maintenance mode<a name="line.252"></a>
+<span class="sourceLineNo">253</span> break;<a name="line.253"></a>
+<span class="sourceLineNo">254</span> }<a name="line.254"></a>
+<span class="sourceLineNo">255</span><a name="line.255"></a>
+<span class="sourceLineNo">256</span> PairOfSameType<RegionInfo> p = MetaTableAccessor.getMergeRegions(e.getValue());<a name="line.256"></a>
+<span class="sourceLineNo">257</span> RegionInfo regionA = p.getFirst();<a name="line.257"></a>
+<span class="sourceLineNo">258</span> RegionInfo regionB = p.getSecond();<a name="line.258"></a>
+<span class="sourceLineNo">259</span> if (regionA == null || regionB == null) {<a name="line.259"></a>
+<span class="sourceLineNo">260</span> LOG.warn("Unexpected references regionA="<a name="line.260"></a>
+<span class="sourceLineNo">261</span> + (regionA == null ? "null" : regionA.getShortNameToLog())<a name="line.261"></a>
+<span class="sourceLineNo">262</span> + ",regionB="<a name="line.262"></a>
+<span class="sourceLineNo">263</span> + (regionB == null ? "null" : regionB.getShortNameToLog())<a name="line.263"></a>
+<span class="sourceLineNo">264</span> + " in merged region " + e.getKey().getShortNameToLog());<a name="line.264"></a>
+<span class="sourceLineNo">265</span> } else {<a name="line.265"></a>
+<span class="sourceLineNo">266</span> if (cleanMergeRegion(e.getKey(), regionA, regionB)) {<a name="line.266"></a>
+<span class="sourceLineNo">267</span> result++;<a name="line.267"></a>
+<span class="sourceLineNo">268</span> }<a name="line.268"></a>
+<span class="sourceLineNo">269</span> }<a name="line.269"></a>
+<span class="sourceLineNo">270</span> }<a name="line.270"></a>
+<span class="sourceLineNo">271</span> /**<a name="line.271"></a>
+<span class="sourceLineNo">272</span> * clean split parents<a name="line.272"></a>
+<span class="sourceLineNo">273</span> */<a name="line.273"></a>
+<span class="sourceLineNo">274</span> Map<RegionInfo, Result> splitParents = scanTriple.getThird();<a name="line.274"></a>
+<span class="sourceLineNo">275</span><a name="line.275"></a>
+<span class="sourceLineNo">276</span> // Now work on our list of found parents. See if any we can clean up.<a name="line.276"></a>
+<span class="sourceLineNo">277</span> // regions whose parents are still around<a name="line.277"></a>
+<span class="sourceLineNo">278</span> HashSet<String> parentNotCleaned = new HashSet<>();<a name="line.278"></a>
+<span class="sourceLineNo">279</span> for (Map.Entry<RegionInfo, Result> e : splitParents.entrySet()) {<a name="line.279"></a>
+<span class="sourceLineNo">280</span> if (this.services.isInMaintenanceMode()) {<a name="line.280"></a>
+<span class="sourceLineNo">281</span> // Stop cleaning if the master is in maintenance mode<a name="line.281"></a>
+<span class="sourceLineNo">282</span> break;<a name="line.282"></a>
+<span class="sourceLineNo">283</span> }<a name="line.283"></a>
+<span class="sourceLineNo">284</span><a name="line.284"></a>
+<span class="sourceLineNo">285</span> if (!parentNotCleaned.contains(e.getKey().getEncodedName()) &&<a name="line.285"></a>
+<span class="sourceLineNo">286</span> cleanParent(e.getKey(), e.getValue())) {<a name="line.286"></a>
+<span class="sourceLineNo">287</span> result++;<a name="line.287"></a>
+<span class="sourceLineNo">288</span> } else {<a name="line.288"></a>
+<span class="sourceLineNo">289</span> // We could not clean the parent, so it's daughters should not be<a name="line.289"></a>
+<span class="sourceLineNo">290</span> // cleaned either (HBASE-6160)<a name="line.290"></a>
+<span class="sourceLineNo">291</span> PairOfSameType<RegionInfo> daughters =<a name="line.291"></a>
+<span class="sourceLineNo">292</span> MetaTableAccessor.getDaughterRegions(e.getValue());<a name="line.292"></a>
+<span class="sourceLineNo">293</span> parentNotCleaned.add(daughters.getFirst().getEncodedName());<a name="line.293"></a>
+<span class="sourceLineNo">294</span> parentNotCleaned.add(daughters.getSecond().getEncodedName());<a name="line.294"></a>
+<span class="sourceLineNo">295</span> }<a name="line.295"></a>
+<span class="sourceLineNo">296</span> }<a name="line.296"></a>
+<span class="sourceLineNo">297</span> return result;<a name="line.297"></a>
+<span class="sourceLineNo">298</span> } finally {<a name="line.298"></a>
+<span class="sourceLineNo">299</span> alreadyRunning.set(false);<a name="line.299"></a>
+<span class="sourceLineNo">300</span> }<a name="line.300"></a>
+<span class="sourceLineNo">301</span> }<a name="line.301"></a>
+<span class="sourceLineNo">302</span><a name="line.302"></a>
+<span class="sourceLineNo">303</span> /**<a name="line.303"></a>
+<span class="sourceLineNo">304</span> * Compare HRegionInfos in a way that has split parents sort BEFORE their<a name="line.304"></a>
+<span class="sourceLineNo">305</span> * daughters.<a name="line.305"></a>
+<span class="sourceLineNo">306</span> */<a name="line.306"></a>
+<span class="sourceLineNo">307</span> static class SplitParentFirstComparator implements Comparator<RegionInfo> {<a name="line.307"></a>
+<span class="sourceLineNo">308</span> Comparator<byte[]> rowEndKeyComparator = new Bytes.RowEndKeyComparator();<a name="line.308"></a>
+<span class="sourceLineNo">309</span> @Override<a name="line.309"></a>
+<span class="sourceLineNo">310</span> public int compare(RegionInfo left, RegionInfo right) {<a name="line.310"></a>
+<span class="sourceLineNo">311</span> // This comparator differs from the one RegionInfo in that it sorts<a name="line.311"></a>
+<span class="sourceLineNo">312</span> // parent before daughters.<a name="line.312"></a>
+<span class="sourceLineNo">313</span> if (left == null) return -1;<a name="line.313"></a>
+<span class="sourceLineNo">314</span> if (right == null) return 1;<a name="line.314"></a>
+<span class="sourceLineNo">315</span> // Same table name.<a name="line.315"></a>
+<span class="sourceLineNo">316</span> int result = left.getTable().compareTo(right.getTable());<a name="line.316"></a>
+<span class="sourceLineNo">317</span> if (result != 0) return result;<a name="line.317"></a>
+<span class="sourceLineNo">318</span> // Compare start keys.<a name="line.318"></a>
+<span class="sourceLineNo">319</span> result = Bytes.compareTo(left.getStartKey(), right.getStartKey());<a name="line.319"></a>
+<span class="sourceLineNo">320</span> if (result != 0) return result;<a name="line.320"></a>
+<span class="sourceLineNo">321</span> // Compare end keys, but flip the operands so parent comes first<a name="line.321"></a>
+<span class="sourceLineNo">322</span> result = rowEndKeyComparator.compare(right.getEndKey(), left.getEndKey());<a name="line.322"></a>
+<span class="sourceLineNo">323</span><a name="line.323"></a>
+<span class="sourceLineNo">324</span> return result;<a name="line.324"></a>
+<span class="sourceLineNo">325</span> }<a name="line.325"></a>
+<span class="sourceLineNo">326</span> }<a name="line.326"></a>
+<span class="sourceLineNo">327</span><a name="line.327"></a>
+<span class="sourceLineNo">328</span> /**<a name="line.328"></a>
+<span class="sourceLineNo">329</span> * If daughters no longer hold reference to the parents, delete the parent.<a name="line.329"></a>
+<span class="sourceLineNo">330</span> * @param parent RegionInfo of split offlined parent<a name="line.330"></a>
+<span class="sourceLineNo">331</span> * @param rowContent Content of <code>parent</code> row in<a name="line.331"></a>
+<span class="sourceLineNo">332</span> * <code>metaRegionName</code><a name="line.332"></a>
+<span class="sourceLineNo">333</span> * @return True if we removed <code>parent</code> from meta table and from<a name="line.333"></a>
+<span class="sourceLineNo">334</span> * the filesystem.<a name="line.334"></a>
+<span class="sourceLineNo">335</span> * @throws IOException<a name="line.335"></a>
+<span class="sourceLineNo">336</span> */<a name="line.336"></a>
+<span class="sourceLineNo">337</span> boolean cleanParent(final RegionInfo parent, Result rowContent)<a name="line.337"></a>
+<span class="sourceLineNo">338</span> throws IOException {<a name="line.338"></a>
+<span class="sourceLineNo">339</span> // Check whether it is a merged region and not clean reference<a name="line.339"></a>
+<span class="sourceLineNo">340</span> // No necessary to check MERGEB_QUALIFIER because these two qualifiers will<a name="line.340"></a>
+<span class="sourceLineNo">341</span> // be inserted/deleted together<a name="line.341"></a>
+<span class="sourceLineNo">342</span> if (rowContent.getValue(HConstants.CATALOG_FAMILY, HConstants.MERGEA_QUALIFIER) != null) {<a name="line.342"></a>
+<span class="sourceLineNo">343</span> // wait cleaning merge region first<a name="line.343"></a>
+<span class="sourceLineNo">344</span> return false;<a name="line.344"></a>
+<span class="sourceLineNo">345</span> }<a name="line.345"></a>
+<span class="sourceLineNo">346</span> // Run checks on each daughter split.<a name="line.346"></a>
+<span class="sourceLineNo">347</span> PairOfSameType<RegionInfo> daughters = MetaTableAccessor.getDaughterRegions(rowContent);<a name="line.347"></a>
+<span class="sourceLineNo">348</span> Pair<Boolean, Boolean> a = checkDaughterInFs(parent, daughters.getFirst());<a name="line.348"></a>
+<span class="sourceLineNo">349</span> Pair<Boolean, Boolean> b = checkDaughterInFs(parent, daughters.getSecond());<a name="line.349"></a>
+<span class="sourceLineNo">350</span> if (hasNoReferences(a) && hasNoReferences(b)) {<a name="line.350"></a>
+<span class="sourceLineNo">351</span> String daughterA = daughters.getFirst() != null?<a name="line.351"></a>
+<span class="sourceLineNo">352</span> daughters.getFirst().getShortNameToLog(): "null";<a name="line.352"></a>
+<span class="sourceLineNo">353</span> String daughterB = daughters.getSecond() != null?<a name="line.353"></a>
+<span class="sourceLineNo">354</span> daughters.getSecond().getShortNameToLog(): "null";<a name="line.354"></a>
+<span class="sourceLineNo">355</span> LOG.debug("Deleting region " + parent.getShortNameToLog() +<a name="line.355"></a>
+<span class="sourceLineNo">356</span> " because daughters -- " + daughterA + ", " + daughterB +<a name="line.356"></a>
+<span class="sourceLineNo">357</span> " -- no longer hold references");<a name="line.357"></a>
+<span class="sourceLineNo">358</span> ProcedureExecutor<MasterProcedureEnv> pe = this.services.getMasterProcedureExecutor();<a name="line.358"></a>
+<span class="sourceLineNo">359</span> pe.submitProcedure(new GCRegionProcedure(pe.getEnvironment(), parent));<a name="line.359"></a>
+<span class="sourceLineNo">360</span> // Remove from in-memory states<a name="line.360"></a>
+<span class="sourceLineNo">361</span> this.services.getAssignmentManager().getRegionStates().deleteRegion(parent);<a name="line.361"></a>
+<span class="sourceLineNo">362</span> this.services.getServerManager().removeRegion(parent);<a name="line.362"></a>
+<span class="sourceLineNo">363</span> return true;<a name="line.363"></a>
+<span class="sourceLineNo">364</span> }<a name="line.364"></a>
+<span class="sourceLineNo">365</span> return false;<a name="line.365"></a>
+<span class="sourceLineNo">366</span> }<a name="line.366"></a>
+<span class="sourceLineNo">367</span><a name="line.367"></a>
+<span class="sourceLineNo">368</span> /**<a name="line.368"></a>
+<span class="sourceLineNo">369</span> * @param p A pair where the first boolean says whether or not the daughter<a name="line.369"></a>
+<span class="sourceLineNo">370</span> * region directory exists in the filesystem and then the second boolean says<a name="line.370"></a>
+<span class="sourceLineNo">371</span> * whether the daughter has references to the parent.<a name="line.371"></a>
+<span class="sourceLineNo">372</span> * @return True the passed <code>p</code> signifies no references.<a name="line.372"></a>
+<span class="sourceLineNo">373</span> */<a name="line.373"></a>
+<span class="sourceLineNo">374</span> private boolean hasNoReferences(final Pair<Boolean, Boolean> p) {<a name="line.374"></a>
+<span class="sourceLineNo">375</span> return !p.getFirst() || !p.getSecond();<a name="line.375"></a>
+<span class="sourceLineNo">376</span> }<a name="line.376"></a>
+<span class="sourceLineNo">377</span><a name="line.377"></a>
+<span class="sourceLineNo">378</span> /**<a name="line.378"></a>
+<span class="sourceLineNo">379</span> * Checks if a daughter region -- either splitA or splitB -- still holds<a name="line.379"></a>
+<span class="sourceLineNo">380</span> * references to parent.<a name="line.380"></a>
+<span class="sourceLineNo">381</span> * @param parent Parent region<a name="line.381"></a>
+<span class="sourceLineNo">382</span> * @param daughter Daughter region<a name="line.382"></a>
+<span class="sourceLineNo">383</span> * @return A pair where the first boolean says whether or not the daughter<a name="line.383"></a>
+<span class="sourceLineNo">384</span> * region directory exists in the filesystem and then the second boolean says<a name="line.384"></a>
+<span class="sourceLineNo">385</span> * whether the daughter has references to the parent.<a name="line.385"></a>
+<span class="sourceLineNo">386</span> * @throws IOException<a name="line.386"></a>
+<span class="sourceLineNo">387</span> */<a name="line.387"></a>
+<span class="sourceLineNo">388</span> Pair<Boolean, Boolean> checkDaughterInFs(final RegionInfo parent, final RegionInfo daughter)<a name="line.388"></a>
+<span class="sourceLineNo">389</span> throws IOException {<a name="line.389"></a>
+<span class="sourceLineNo">390</span> if (daughter == null) {<a name="line.390"></a>
+<span class="sourceLineNo">391</span> return new Pair<>(Boolean.FALSE, Boolean.FALSE);<a name="line.391"></a>
+<span class="sourceLineNo">392</span> }<a name="line.392"></a>
+<span class="sourceLineNo">393</span><a name="line.393"></a>
+<span class="sourceLineNo">394</span> FileSystem fs = this.services.getMasterFileSystem().getFileSystem();<a name="line.394"></a>
+<span class="sourceLineNo">395</span> Path rootdir = this.services.getMasterFileSystem().getRootDir();<a name="line.395"></a>
+<span class="sourceLineNo">396</span> Path tabledir = FSUtils.getTableDir(rootdir, daughter.getTable());<a name="line.396"></a>
<span class="sourceLineNo">397</span><a name="line.397"></a>
-<span class="sourceLineNo">398</span> HRegionFileSystem regionFs = null;<a name="line.398"></a>
+<span class="sourceLineNo">398</span> Path daughterRegionDir = new Path(tabledir, daughter.getEncodedName());<a name="line.398"></a>
<span class="sourceLineNo">399</span><a name="line.399"></a>
-<span class="sourceLineNo">400</span> try {<a name="line.400"></a>
-<span class="sourceLineNo">401</span> if (!FSUtils.isExists(fs, daughterRegionDir)) {<a name="line.401"></a>
-<span class="sourceLineNo">402</span> return new Pair<>(Boolean.FALSE, Boolean.FALSE);<a name="line.402"></a>
-<span class="sourceLineNo">403</span> }<a name="line.403"></a>
-<span class="sourceLineNo">404</span> } catch (IOException ioe) {<a name="line.404"></a>
-<span class="sourceLineNo">405</span> LOG.error("Error trying to determine if daughter region exists, " +<a name="line.405"></a>
-<span class="sourceLineNo">406</span> "assuming exists and has references", ioe);<a name="line.406"></a>
-<span class="sourceLineNo">407</span> return new Pair<>(Boolean.TRUE, Boolean.TRUE);<a name="line.407"></a>
-<span class="sourceLineNo">408</span> }<a name="line.408"></a>
-<span class="sourceLineNo">409</span><a name="line.409"></a>
-<span class="sourceLineNo">410</span> boolean references = false;<a name="line.410"></a>
-<span class="sourceLineNo">411</span> TableDescriptor parentDescriptor = getTableDescriptor(parent.getTable());<a name="line.411"></a>
-<span class="sourceLineNo">412</span> try {<a name="line.412"></a>
-<span class="sourceLineNo">413</span> regionFs = HRegionFileSystem.openRegionFromFileSystem(<a name="line.413"></a>
-<span class="sourceLineNo">414</span> this.services.getConfiguration(), fs, tabledir, daughter, true);<a name="line.414"></a>
-<span class="sourceLineNo">415</span><a name="line.415"></a>
-<span class="sourceLineNo">416</span> for (ColumnFamilyDescriptor family: parentDescriptor.getColumnFamilies()) {<a name="line.416"></a>
-<span class="sourceLineNo">417</span> if ((references = regionFs.hasReferences(family.getNameAsString()))) {<a name="line.417"></a>
-<span class="sourceLineNo">418</span> break;<a name="line.418"></a>
-<span class="sourceLineNo">419</span> }<a name="line.419"></a>
-<span class="sourceLineNo">420</span> }<a name="line.420"></a>
-<span class="sourceLineNo">421</span> } catch (IOException e) {<a name="line.421"></a>
-<span class="sourceLineNo">422</span> LOG.error("Error trying to determine referenced files from : " + daughter.getEncodedName()<a name="line.422"></a>
-<span class="sourceLineNo">423</span> + ", to: " + parent.getEncodedName() + " assuming has references", e);<a name="line.423"></a>
-<span class="sourceLineNo">424</span> return new Pair<>(Boolean.TRUE, Boolean.TRUE);<a name="line.424"></a>
-<span class="sourceLineNo">425</span> }<a name="line.425"></a>
-<span class="sourceLineNo">426</span> return new Pair<>(Boolean.TRUE, Boolean.valueOf(references));<a name="line.426"></a>
-<span class="sourceLineNo">427</span> }<a name="line.427"></a>
-<span class="sourceLineNo">428</span><a name="line.428"></a>
-<span class="sourceLineNo">429</span> private TableDescriptor getTableDescriptor(final TableName tableName)<a name="line.429"></a>
-<span class="sourceLineNo">430</span> throws FileNotFoundException, IOException {<a name="line.430"></a>
-<span class="sourceLineNo">431</span> return this.services.getTableDescriptors().get(tableName);<a name="line.431"></a>
-<span class="sourceLineNo">432</span> }<a name="line.432"></a>
-<span class="sourceLineNo">433</span><a name="line.433"></a>
-<span class="sourceLineNo">434</span> /**<a name="line.434"></a>
-<span class="sourceLineNo">435</span> * Checks if the specified region has merge qualifiers, if so, try to clean<a name="line.435"></a>
-<span class="sourceLineNo">436</span> * them<a name="line.436"></a>
-<span class="sourceLineNo">437</span> * @param region<a name="line.437"></a>
-<span class="sourceLineNo">438</span> * @return true if the specified region doesn't have merge qualifier now<a name="line.438"></a>
-<span class="sourceLineNo">439</span> * @throws IOException<a name="line.439"></a>
-<span class="sourceLineNo">440</span> */<a name="line.440"></a>
-<span class="sourceLineNo">441</span> public boolean cleanMergeQualifier(final RegionInfo region)<a name="line.441"></a>
-<span class="sourceLineNo">442</span> throws IOException {<a name="line.442"></a>
-<span class="sourceLineNo">443</span> // Get merge regions if it is a merged region and already has merge<a name="line.443"></a>
-<span class="sourceLineNo">444</span> // qualifier<a name="line.444"></a>
-<span class="sourceLineNo">445</span> Pair<RegionInfo, RegionInfo> mergeRegions = MetaTableAccessor<a name="line.445"></a>
-<span class="sourceLineNo">446</span> .getRegionsFromMergeQualifier(this.services.getConnection(),<a name="line.446"></a>
-<span class="sourceLineNo">447</span> region.getRegionName());<a name="line.447"></a>
-<span class="sourceLineNo">448</span> if (mergeRegions == null<a name="line.448"></a>
-<span class="sourceLineNo">449</span> || (mergeRegions.getFirst() == null && mergeRegions.getSecond() == null)) {<a name="line.449"></a>
-<span class="sourceLineNo">450</span> // It doesn't have merge qualifier, no need to clean<a name="line.450"></a>
-<span class="sourceLineNo">451</span> return true;<a name="line.451"></a>
-<span class="sourceLineNo">452</span> }<a name="line.452"></a>
-<span class="sourceLineNo">453</span> // It shouldn't happen, we must insert/delete these two qualifiers together<a name="line.453"></a>
-<span class="sourceLineNo">454</span> if (mergeRegions.getFirst() == null || mergeRegions.getSecond() == null) {<a name="line.454"></a>
-<span class="sourceLineNo">455</span> LOG.error("Merged region " + region.getRegionNameAsString()<a name="line.455"></a>
-<span class="sourceLineNo">456</span> + " has only one merge qualifier in META.");<a name="line.456"></a>
-<span class="sourceLineNo">457</span> return false;<a name="line.457"></a>
-<span class="sourceLineNo">458</span> }<a name="line.458"></a>
-<span class="sourceLineNo">459</span> return cleanMergeRegion(region, mergeRegions.getFirst(),<a name="line.459"></a>
-<span class="sourceLineNo">460</span> mergeRegions.getSecond());<a name="line.460"></a>
-<span class="sourceLineNo">461</span> }<a name="line.461"></a>
-<span class="sourceLineNo">462</span>}<a name="line.462"></a>
+<span class="sourceLineNo">400</span> HRegionFileSystem regionFs = null;<a name="line.400"></a>
+<span class="sourceLineNo">401</span><a name="line.401"></a>
+<span class="sourceLineNo">402</span> try {<a name="line.402"></a>
+<span class="sourceLineNo">403</span> if (!FSUtils.isExists(fs, daughterRegionDir)) {<a name="line.403"></a>
+<span class="sourceLineNo">404</span> return new Pair<>(Boolean.FALSE, Boolean.FALSE);<a name="line.404"></a>
+<span class="sourceLineNo">405</span> }<a name="line.405"></a>
+<span class="sourceLineNo">406</span> } catch (IOException ioe) {<a name="line.406"></a>
+<span class="sourceLineNo">407</span> LOG.error("Error trying to determine if daughter region exists, " +<a name="line.407"></a>
+<span class="sourceLineNo">408</span> "assuming exists and has references", ioe);<a name="line.408"></a>
+<span class="sourceLineNo">409</span> return new Pair<>(Boolean.TRUE, Boolean.TRUE);<a name="line.409"></a>
+<span class="sourceLineNo">410</span> }<a name="line.410"></a>
+<span class="sourceLineNo">411</span><a name="line.411"></a>
+<span class="sourceLineNo">412</span> boolean references = false;<a name="line.412"></a>
+<span class="sourceLineNo">413</span> TableDescriptor parentDescriptor = getTableDescriptor(parent.getTable());<a name="line.413"></a>
+<span class="sourceLineNo">414</span> try {<a name="line.414"></a>
+<span class="sourceLineNo">415</span> regionFs = HRegionFileSystem.openRegionFromFileSystem(<a name="line.415"></a>
+<span class="sourceLineNo">416</span> this.services.getConfiguration(), fs, tabledir, daughter, true);<a name="line.416"></a>
+<span class="sourceLineNo">417</span><a name="line.417"></a>
+<span class="sourceLineNo">418</span> for (ColumnFamilyDescriptor family: parentDescriptor.getColumnFamilies()) {<a name="line.418"></a>
+<span class="sourceLineNo">419</span> if ((references = regionFs.hasReferences(family.getNameAsString()))) {<a name="line.419"></a>
+<span class="sourceLineNo">420</span> break;<a name="line.420"></a>
+<span class="sourceLineNo">421</span> }<a name="line.421"></a>
+<span class="sourceLineNo">422</span> }<a name="line.422"></a>
+<span class="sourceLineNo">423</span> } catch (IOException e) {<a name="line.423"></a>
+<span class="sourceLineNo">424</span> LOG.error("Error trying to determine referenced files from : " + daughter.getEncodedName()<a name="line.424"></a>
+<span class="sourceLineNo">425</span> + ", to: " + parent.getEncodedName() + " assuming has references", e);<a name="line.425"></a>
+<span class="sourceLineNo">426</span> return new Pair<>(Boolean.TRUE, Boolean.TRUE);<a name="line.426"></a>
+<span class="sourceLineNo">427</span> }<a name="line.427"></a>
+<span class="sourceLineNo">428</span> return new Pair<>(Boolean.TRUE, Boolean.valueOf(references));<a name="line.428"></a>
+<span class="sourceLineNo">429</span> }<a name="line.429"></a>
+<span class="sourceLineNo">430</span><a name="line.430"></a>
+<span class="sourceLineNo">431</span> private TableDescriptor getTableDescriptor(final TableName tableName)<a name="line.431"></a>
+<span class="sourceLineNo">432</span> throws FileNotFoundException, IOException {<a name="line.432"></a>
+<span class="sourceLineNo">433</span> return this.services.getTableDescriptors().get(tableName);<a name="line.433"></a>
+<span class="sourceLineNo">434</span> }<a name="line.434"></a>
+<span class="sourceLineNo">435</span><a name="line.435"></a>
+<span class="sourceLineNo">436</span> /**<a name="line.436"></a>
+<span class="sourceLineNo">437</span> * Checks if the specified region has merge qualifiers, if so, try to clean<a name="line.437"></a>
+<span class="sourceLineNo">438</span> * them<a name="line.438"></a>
+<span class="sourceLineNo">439</span> * @param region<a name="line.439"></a>
+<span class="sourceLineNo">440</span> * @return true if the specified region doesn't have merge qualifier now<a name="line.440"></a>
+<span class="sourceLineNo">441</span> * @throws IOException<a name="line.441"></a>
+<span class="sourceLineNo">442</span> */<a name="line.442"></a>
+<span class="sourceLineNo">443</span> public boolean cleanMergeQualifier(final RegionInfo region)<a name="line.443"></a>
+<span class="sourceLineNo">444</span> throws IOException {<a name="line.444"></a>
+<span class="sourceLineNo">445</span> // Get merge regions if it is a merged region and already has merge<a name="line.445"></a>
+<span class="sourceLineNo">446</span> // qualifier<a name="line.446"></a>
+<span class="sourceLineNo">447</span> Pair<RegionInfo, RegionInfo> mergeRegions = MetaTableAccessor<a name="line.447"></a>
+<span class="sourceLineNo">448</span> .getRegionsFromMergeQualifier(this.services.getConnection(),<a name="line.448"></a>
+<span class="sourceLineNo">449</span> region.getRegionName());<a name="line.449"></a>
+<span class="sourceLineNo">450</span> if (mergeRegions == null<a name="line.450"></a>
+<span class="sourceLineNo">451</span> || (mergeRegions.getFirst() == null && mergeRegions.getSecond() == null)) {<a name="line.451"></a>
+<span class="sourceLineNo">452</span> // It doesn't have merge qualifier, no need to clean<a name="line.452"></a>
+<span class="sourceLineNo">453</span> return true;<a name="line.453"></a>
+<span class="sourceLineNo">454</span> }<a name="line.454"></a>
+<span class="sourceLineNo">455</span> // It shouldn't happen, we must insert/delete these two qualifiers together<a name="line.455"></a>
+<span class="sourceLineNo">456</span> if (mergeRegions.getFirst() == null || mergeRegions.getSecond() == null) {<a name="line.456"></a>
+<span class="sourceLineNo">457</span> LOG.error("Merged region " + region.getRegionNameAsString()<a name="line.457"></a>
+<span class="sourceLineNo">458</span> + " has only one merge qualifier in META.");<a name="line.458"></a>
+<span class="sourceLineNo">459</span> return false;<a name="line.459"></a>
+<span class="sourceLineNo">460</span> }<a name="line.460"></a>
+<span class="sourceLineNo">461</span> return cleanMergeRegion(region, mergeRegions.getFirst(),<a name="line.461"></a>
+<span class="sourceLineNo">462</span> mergeRegions.getSecond());<a name="line.462"></a>
+<span class="sourceLineNo">463</span> }<a name="line.463"></a>
+<span class="sourceLineNo">464</span>}<a name="line.464"></a>