You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Totoro-qaq (via GitHub)" <gi...@apache.org> on 2026/09/08 06:52:37 UTC
[PR] refactor(runtime-host): extract Peer Mesh control message codecs [maka]
Totoro-qaq opened a new pull request, #5006:
URL: https://github.com/apache/maka/pull/5006
## Summary
Separate Peer Mesh control-message types and object decoding from node lifecycle orchestration. The internal codec owns the five decoder entry points and their bounds, while node retains stream framing, timeouts, connection admission and state changes. Existing signed-record decoders are reused, and pagination and decoding share one evidence-page limit.
`peer-mesh/node.ts` shrinks from 3,103 to 2,835 lines. The new codec is 317 lines, so aggregate production code increases by 49 lines for module headers/imports. The result is an independently testable boundary in a large module, not a net deletion or performance improvement. Public package exports and wire formats are unchanged.
Fixes #5005
Refs #4726, A9.
## Verification
Local macOS verification with Node 24.18.0 and npm 11.19.0:
- Original Peer Mesh suite: 28/28 on baseline and candidate; existing test source unchanged. New codec tests: 9/9. All are included in the full Host result below.
- Ten deliberate mutations were detected: one for each new test group, plus an existing public node join test with a removed response-decoder implementation. Candidate compiled output was restored byte-for-byte and the focused tests passed again.
- AST equivalence: all 24 moved declarations and all retained node declarations are unchanged apart from module exports/source metadata; node.d.ts is byte-identical. No new package export or dependency cycle is introduced.
- Full Runtime Host suite: 1,818 passed, 12 skipped, 0 failed or cancelled.
- Full build, typecheck, lint, format, Desktop/UI knip, renderer architecture, staged ASF/header/protocol checks and diff checks pass. Staged checks used a temporary index containing the exact three-file patch.
Not run: other workspace test suites, a Windows execution matrix, or a multi-host native Peer Mesh deployment. The existing Peer Mesh integration tests use their original in-memory transport and real cryptographic helpers.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex inspected the existing seam, extracted the implementation, added boundary tests, ran local equivalence and regression checks, and prepared these drafts. DSH performed a separate read-only source review and ran the codec tests. Submitted with contributor approval; upstream review is pending.
## Checklist
- [x] Tests cover the change and fail without the implementation they exercise
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [ ] Yes — described under Summary above
- [x] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] refactor(runtime-host): extract Peer Mesh control message codecs [maka]
Posted by "Totoro-qaq (via GitHub)" <gi...@apache.org>.
Totoro-qaq commented on PR #5006:
URL: https://github.com/apache/maka/pull/5006#issuecomment-5873311142
Thanks for the review. On the P3: `test` did report on 285a700f and passed ([run](https://github.com/apache/maka/actions/runs/34196622883)), but that run is from 09-08, and main has since touched peer-mesh in #4938 and #5153. I merged current main in be1569ec so `test` runs again on an up-to-date head. The merge was clean and the PR diff is unchanged. Locally, the peer-mesh suites pass (37/37) and the runtime-host suite has no failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] refactor(runtime-host): extract Peer Mesh control message codecs [maka]
Posted by "Totoro-qaq (via GitHub)" <gi...@apache.org>.
Totoro-qaq commented on PR #5006:
URL: https://github.com/apache/maka/pull/5006#issuecomment-5602707959
@Astro-Han Could you take a look when you have a chance? This extracts the Peer Mesh control message codecs into `peer-mesh/control-protocol.ts` (#5005): pure refactor, no wire-format change, 12/12 CI checks green at `285a700f`, and it still merges cleanly against current main (34 commits ahead, no overlapping files). Happy to rebase onto a fresh head if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] refactor(runtime-host): extract Peer Mesh control message codecs [maka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5006:
URL: https://github.com/apache/maka/pull/5006#issuecomment-6487280600
<!-- maka-lifecycle:stale-warning -->
This pull request has had no new commits for 30 days and has been marked stale. It will be closed in 7 days unless a new commit is pushed.
Comments do not reset this timer: only a new commit does. If the pull request is intentionally long-lived, a maintainer can apply the `pinned` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org