You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2015/12/08 18:57:35 UTC

Review Request 41092: Added CMake file for agent executable build.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

Added CMake file for agent executable build.


Diffs
-----

  src/slave/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
-------

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Alex Clemmer <cl...@gmail.com>.

> On Dec. 9, 2015, 3:30 a.m., Joseph Wu wrote:
> > src/slave/CMakeLists.txt, line 42
> > <https://reviews.apache.org/r/41092/diff/1/?file=1156046#file1156046line42>
> >
> >     The pre-commit hooks will complain about this line.

Ah, I didn't know this was true. I thought `mesos-style` only ran on `.cpp` files? Is that wrong?


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109357
-----------------------------------------------------------


On Dec. 9, 2015, 3:43 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Joseph Wu <jo...@mesosphere.io>.

> On Dec. 8, 2015, 7:30 p.m., Joseph Wu wrote:
> > src/slave/CMakeLists.txt, line 42
> > <https://reviews.apache.org/r/41092/diff/1/?file=1156046#file1156046line42>
> >
> >     The pre-commit hooks will complain about this line.
> 
> Alex Clemmer wrote:
>     Ah, I didn't know this was true. I thought `mesos-style` only ran on `.cpp` files? Is that wrong?

`.cpp` files are linted.  Most other (text) files are checked for whitespace, i.e. trailing whitespace, too many blank lines, 1 newline before EOF, etc.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109357
-----------------------------------------------------------


On Dec. 8, 2015, 7:43 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 7:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109357
-----------------------------------------------------------


Initial review.  I haven't run this code yet.

---

What do you think about using "agent" in the variable names and comments?


src/slave/CMakeLists.txt (line 39)
<https://reviews.apache.org/r/41092/#comment168847>

    Nit: trim this line.



src/slave/CMakeLists.txt (line 42)
<https://reviews.apache.org/r/41092/#comment168978>

    The pre-commit hooks will complain about this line.


- Joseph Wu


On Dec. 8, 2015, 9:57 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 9:57 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109544
-----------------------------------------------------------



src/slave/CMakeLists.txt (lines 17 - 19)
<https://reviews.apache.org/r/41092/#comment169109>

    Historically, we have put the `*_TARGET` inside the relevant `*Configure.cmake` files. I recommend we follow this convention and put this target inside the `SlaveConfigure.cmake`.
    
    Also, what do you think of calling it `AGENT_TARGET` instead of `AGENT_EXEC_TARGET`? I think the former is a lot clearer, personally, especially since we have exec directories in the project.



src/slave/CMakeLists.txt (line 21)
<https://reviews.apache.org/r/41092/#comment169121>

    Possibly there should be a space between `#` and `SOURCE`?



src/slave/CMakeLists.txt (line 22)
<https://reviews.apache.org/r/41092/#comment169122>

    Can we make the end of the line with `###` line up with the comment?



src/slave/CMakeLists.txt (line 24)
<https://reviews.apache.org/r/41092/#comment169108>

    In the `CMakeLists.txt` that already exists, we tend to refer to these as `AGENT_`, for example in `src/CMakeLists.txt`, we call it `AGENT_SRC`. I'd like to propose we use a similar naming scheme here.



src/slave/CMakeLists.txt (line 26)
<https://reviews.apache.org/r/41092/#comment169124>

    Alright, just to be clear: this will break the build, which is why we didn't `add_subdirectory(slave)`, right?
    
    That's fine, I just wanted to call this out on the review.



src/slave/CMakeLists.txt (line 30)
<https://reviews.apache.org/r/41092/#comment169123>

    My guess is that this is left over from the `CMakeLists.txt` in process? If so it seems like the `PROCESS` word on this line snuck in accidentally. :)



src/slave/CMakeLists.txt (line 32)
<https://reviews.apache.org/r/41092/#comment169117>

    My recollection is that, when called with an empty source list, `add_executable` will result in an error that claims you didn't pass it enough arguments.
    
    Therefore, I recommend that we actually just move the `if (NOT WIN32)` conditionals to just not `add_subdirectory` on the `slave/` directory.



src/slave/CMakeLists.txt (line 37)
<https://reviews.apache.org/r/41092/#comment169119>

    It seems like these should possibly be in alphabetical order?



src/slave/CMakeLists.txt (line 39)
<https://reviews.apache.org/r/41092/#comment169120>

    Can we remove the trailing whitespace? And add a period?


- Alex Clemmer


On Dec. 9, 2015, 3:43 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109679
-----------------------------------------------------------


Bad patch!

Reviews applied: [40951, 41090, 41092]

Failed command: ./support/apply-review.sh -n -r 41092

Error:
 2015-12-10 03:23:34 URL:https://reviews.apache.org/r/41092/diff/raw/ [1967/1967] -> "41092.patch" [1]
41092.patch:45: trailing whitespace.
# ADD LINKER FLAGS 
41092.patch:48: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Successfully applied: Added CMake file for agent executable build.

Added CMake file for agent executable build.


Review: https://reviews.apache.org/r/41092
src/slave/CMakeLists.txt:39: trailing whitespace.
+# ADD LINKER FLAGS 
src/slave/CMakeLists.txt:42: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On Dec. 9, 2015, 3:43 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 3:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review116371
-----------------------------------------------------------



Patch looks great!

Reviews applied: [40951, 41090, 41092]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 1:54 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review121005
-----------------------------------------------------------




src/slave/CMakeLists.txt (line 27)
<https://reviews.apache.org/r/41092/#comment182584>

    I liked what you did with the master -- there should be only a `main.cpp` file here, so what do you think of just making this `add_executable(${AGENT_TARGET} main.cpp)`?



src/slave/CMakeLists.txt (line 33)
<https://reviews.apache.org/r/41092/#comment182587>

    Same comment as the master review -- I recommend putting the `*_TARGET`s inside a single variable inside `SlaveConfigure.cmake`, and simply calling `add_dependencies(${AGENT_TARGET} ${AGENT_DEPENDENCIES})` or whatever. This should be very similar to the slave.



src/slave/CMakeLists.txt (line 37)
<https://reviews.apache.org/r/41092/#comment182588>

    See comment above and comment in the master review for my recommendations here -- thinking it woudl be better to just put this into a single variable in `SlaveConfigure.cmake`.


- Alex Clemmer


On Feb. 13, 2016, 4:23 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 4:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review119141
-----------------------------------------------------------



Patch looks great!

Reviews applied: [40951, 41090, 41092]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 13, 2016, 4:23 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 4:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
-----------------------------------------------------------

(Updated Feb. 13, 2016, 4:23 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Changes
-------

Rebase per Alex's request.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

Added CMake file for agent executable build.


Diffs (updated)
-----

  src/slave/CMakeLists.txt PRE-CREATION 
  src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
-------

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
-----------------------------------------------------------

(Updated Jan. 26, 2016, 1:54 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Changes
-------

Cleanup code.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

Added CMake file for agent executable build.


Diffs (updated)
-----

  src/slave/CMakeLists.txt PRE-CREATION 
  src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
-------

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review115685
-----------------------------------------------------------


I was expecting a `mesos-slave` executable, but I don't see any `add_executable` (or something that actually generates an executable) in this patch.  Was that intentional?


src/slave/CMakeLists.txt (lines 17 - 19)
<https://reviews.apache.org/r/41092/#comment176709>

    Clean this up?



src/slave/CMakeLists.txt (line 42)
<https://reviews.apache.org/r/41092/#comment176701>

    Nit: Pre-commit hooks complain about this line.  (Delete it)


- Joseph Wu


On Jan. 21, 2016, 8:58 a.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 8:58 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 4:58 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Changes
-------

Addressed latest review comments.


Summary (updated)
-----------------

CMake: Added CMake file for agent executable build.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

Added CMake file for agent executable build.


Diffs (updated)
-----

  src/slave/CMakeLists.txt PRE-CREATION 
  src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
-------

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
-----------------------------------------------------------

(Updated Dec. 9, 2015, 3:43 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.


Bugs: MESOS-3843
    https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
-------

Added CMake file for agent executable build.


Diffs (updated)
-----

  src/slave/CMakeLists.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
-------

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Re: Review Request 41092: Added CMake file for agent executable build.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review109377
-----------------------------------------------------------


Bad patch!

Reviews applied: [40951, 41090]

Failed command: ./support/apply-review.sh -n -r 41090

Error:
 2015-12-08 20:01:21 URL:https://reviews.apache.org/r/41090/diff/raw/ [4071/4071] -> "41090.patch" [1]
41090.patch:117: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Successfully applied: Second iteration of changes for cmake build on linux.

Second iteration of changes for cmake build on linux.


Review: https://reviews.apache.org/r/41090
src/slave/cmake/FindCurl.cmake:111: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On Dec. 8, 2015, 5:57 p.m., Diana Arroyo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
>     https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -----
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> -------
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>