You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Chris Goffinet (JIRA)" <ji...@apache.org> on 2009/06/27 00:53:47 UTC
[jira] Created: (CASSANDRA-262) get_slice needs to allow returning
all columns
get_slice needs to allow returning all columns
----------------------------------------------
Key: CASSANDRA-262
URL: https://issues.apache.org/jira/browse/CASSANDRA-262
Project: Cassandra
Issue Type: Bug
Reporter: Chris Goffinet
Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-262) get_slice needs to allow returning
all columns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-262.
--------------------------------------
Resolution: Fixed
Assignee: Jonathan Ellis (was: Eric Evans)
yes, that's the right idea.
I set the default for all the count parameters to 100 in cassandra.thrift. I don't know of any languages for which thrift actually generates working defaults but it's thrift's bug now. :)
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
> Assignee: Jonathan Ellis
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-262) get_slice needs to allow returning
all columns
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-262:
-------------------------------------
Component/s: Core
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Chris Goffinet
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "chris mckenzie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774697#action_12774697 ]
chris mckenzie commented on CASSANDRA-262:
------------------------------------------
FYI, The last link is now dead.
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Chris Goffinet
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727230#action_12727230 ]
Hudson commented on CASSANDRA-262:
----------------------------------
Integrated in Cassandra #128 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/128/])
default all count args to 100. patch by jbellis for
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
> Assignee: Jonathan Ellis
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "Evan Weaver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727167#action_12727167 ]
Evan Weaver commented on CASSANDRA-262:
---------------------------------------
For what it's worth, I'm having the Ruby client currently default to limit = 100...I couldn't really care less what the server thinks the limit is. I expect other clients would be similar.
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
> Assignee: Eric Evans
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726114#action_12726114 ]
Jonathan Ellis commented on CASSANDRA-262:
------------------------------------------
How about if we add a configuration parameter for "maximum columns to slice at once," that defaults to something high enough (1000?) that you really ought to page if you need more than that anyway, and low enough that it's in no danger of crashing your server from OOM?
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726117#action_12726117 ]
Chris Goffinet commented on CASSANDRA-262:
------------------------------------------
+1. I am okay with this.
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-262) get_slice needs to allow
returning all columns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726248#action_12726248 ]
Jonathan Ellis commented on CASSANDRA-262:
------------------------------------------
Actually, as with many of my "brilliant" ideas, this one looks worse given a little more time. :)
I don't see what purpose this would serve over the client just sending 1000 for the count, other than obfuscation.
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
> Assignee: Eric Evans
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-262) get_slice needs to allow returning
all columns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-262:
----------------------------------------
Assignee: Eric Evans
Eric, since you're already in the slice code for CASSANDRA-263, do you think you could take a stab at this too?
> get_slice needs to allow returning all columns
> ----------------------------------------------
>
> Key: CASSANDRA-262
> URL: https://issues.apache.org/jira/browse/CASSANDRA-262
> Project: Cassandra
> Issue Type: Bug
> Reporter: Chris Goffinet
> Assignee: Eric Evans
>
> Right now get_slice requires you to enter a 'large' value, -1 used to indicate 'all columns'. We should allow this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.