[jira] [Created] (SOLR-15628) SolrException.log doesn't pass Throwable to Logger correctly

["Chris M. Hostetter (Jira)" <ji...@apache.org>]

Chris M. Hostetter created SOLR-15628:
-----------------------------------------

             Summary: SolrException.log doesn't pass Throwable to Logger correctly
                 Key: SOLR-15628
                 URL: https://issues.apache.org/jira/browse/SOLR-15628
             Project: Solr
          Issue Type: Bug
      Security Level: Public (Default Security Level. Issues are Public)
            Reporter: Chris M. Hostetter


Having recently started using JSON based logging, I noticed that in many code paths situations where an error involving a "Throwable"  are logged isn't happening correctly (This is also noticeable using the default solr log4j2.xml configuration - but only subtly)

The problem is that {{SolrException.log(...)}} has some very old (pre Solr 1.0, certainly pre SLF4j/Log4j) and hackish logic/code in it to support {{SolrException.ignorePatterns}} (which was designed for tests that wanted "quieter" output when they were intentionally triggering error situations.  This logic "stringifies" the entire Throwable (including stack trace) to test against any {{ignorePatterns}} that exist (even if there are no ignore patterns) before handing the resulting string off to the {{loggger.error(...)}} call -- _as a log message string_ - w/o the normal "structure" context of the original Throwable instance.

This causes the full exception stack trace to come through as the log "message" -- even in log appenders that have been configured to only log partial stack trace details, or log them in special fields (ie: JSON Logging)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org