You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2010/03/10 10:09:29 UTC

[jira] Created: (JCR-2553) spi2davex: Batch fails to create/modify properties with non-ascii characters names

spi2davex: Batch fails to create/modify properties with non-ascii characters names
----------------------------------------------------------------------------------

                 Key: JCR-2553
                 URL: https://issues.apache.org/jira/browse/JCR-2553
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-jcr-servlet, jackrabbit-spi2dav
    Affects Versions: 2.0.0
            Reporter: angela
             Fix For: 2.1.0


the spi2davex batch implementation fails upon creation/modification of all property types that have their value sent as
separate stringpart or binarypart AND contain non-ascii characters in their property name.

from what i've seen this is due to a limitation in HttpClient 3.x Part#sendDispositionHeader that always writes the part name
as ascii-bytes. in a related discussion [1] specification compliance and usability were addressed.

looking at the server-side part revealed that org.apache.commons.fileupload.FileUploadBase#FileItemIteratorImpl
is prepared to receive non-ascii characters in a header value.
a simple test also showed that curl is perfectly able to send utf-8 part names.

based on this information and given the fact that spi2dav and the server-sided part are intended to communicate
with one other rather than with any kind of custom clients, i suggest to add a simple fix by patching the parts used
within spi2davex.

btw: in HttpClient 4.x there seems to be a workaround for this problem [2]

[1] http://www.mail-archive.com/httpclient-dev@jakarta.apache.org/msg04637.html
[2] https://issues.apache.org/jira/browse/HTTPCLIENT-293

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-2553) spi2davex: Batch fails to create/modify properties with non-ascii characters names

Posted by "angela (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843507#action_12843507 ] 

angela commented on JCR-2553:
-----------------------------

thanks to alex saar for the initial test-case (only slightly adjusted) and the issue reporting.

> spi2davex: Batch fails to create/modify properties with non-ascii characters names
> ----------------------------------------------------------------------------------
>
>                 Key: JCR-2553
>                 URL: https://issues.apache.org/jira/browse/JCR-2553
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-servlet, jackrabbit-spi2dav
>    Affects Versions: 2.0.0
>            Reporter: angela
>            Assignee: angela
>             Fix For: 2.1.0
>
>
> the spi2davex batch implementation fails upon creation/modification of all property types that have their value sent as
> separate stringpart or binarypart AND contain non-ascii characters in their property name.
> from what i've seen this is due to a limitation in HttpClient 3.x Part#sendDispositionHeader that always writes the part name
> as ascii-bytes. in a related discussion [1] specification compliance and usability were addressed.
> looking at the server-side part revealed that org.apache.commons.fileupload.FileUploadBase#FileItemIteratorImpl
> is prepared to receive non-ascii characters in a header value.
> a simple test also showed that curl is perfectly able to send utf-8 part names.
> based on this information and given the fact that spi2dav and the server-sided part are intended to communicate
> with one other rather than with any kind of custom clients, i suggest to add a simple fix by patching the parts used
> within spi2davex.
> btw: in HttpClient 4.x there seems to be a workaround for this problem [2]
> [1] http://www.mail-archive.com/httpclient-dev@jakarta.apache.org/msg04637.html
> [2] https://issues.apache.org/jira/browse/HTTPCLIENT-293

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (JCR-2553) spi2davex: Batch fails to create/modify properties with non-ascii characters names

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela reassigned JCR-2553:
---------------------------

    Assignee: angela

> spi2davex: Batch fails to create/modify properties with non-ascii characters names
> ----------------------------------------------------------------------------------
>
>                 Key: JCR-2553
>                 URL: https://issues.apache.org/jira/browse/JCR-2553
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-servlet, jackrabbit-spi2dav
>    Affects Versions: 2.0.0
>            Reporter: angela
>            Assignee: angela
>             Fix For: 2.1.0
>
>
> the spi2davex batch implementation fails upon creation/modification of all property types that have their value sent as
> separate stringpart or binarypart AND contain non-ascii characters in their property name.
> from what i've seen this is due to a limitation in HttpClient 3.x Part#sendDispositionHeader that always writes the part name
> as ascii-bytes. in a related discussion [1] specification compliance and usability were addressed.
> looking at the server-side part revealed that org.apache.commons.fileupload.FileUploadBase#FileItemIteratorImpl
> is prepared to receive non-ascii characters in a header value.
> a simple test also showed that curl is perfectly able to send utf-8 part names.
> based on this information and given the fact that spi2dav and the server-sided part are intended to communicate
> with one other rather than with any kind of custom clients, i suggest to add a simple fix by patching the parts used
> within spi2davex.
> btw: in HttpClient 4.x there seems to be a workaround for this problem [2]
> [1] http://www.mail-archive.com/httpclient-dev@jakarta.apache.org/msg04637.html
> [2] https://issues.apache.org/jira/browse/HTTPCLIENT-293

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-2553) spi2davex: Batch fails to create/modify properties with non-ascii characters names

Posted by "angela (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-2553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved JCR-2553.
-------------------------

    Resolution: Fixed

> spi2davex: Batch fails to create/modify properties with non-ascii characters names
> ----------------------------------------------------------------------------------
>
>                 Key: JCR-2553
>                 URL: https://issues.apache.org/jira/browse/JCR-2553
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-jcr-servlet, jackrabbit-spi2dav
>    Affects Versions: 2.0.0
>            Reporter: angela
>            Assignee: angela
>             Fix For: 2.1.0
>
>
> the spi2davex batch implementation fails upon creation/modification of all property types that have their value sent as
> separate stringpart or binarypart AND contain non-ascii characters in their property name.
> from what i've seen this is due to a limitation in HttpClient 3.x Part#sendDispositionHeader that always writes the part name
> as ascii-bytes. in a related discussion [1] specification compliance and usability were addressed.
> looking at the server-side part revealed that org.apache.commons.fileupload.FileUploadBase#FileItemIteratorImpl
> is prepared to receive non-ascii characters in a header value.
> a simple test also showed that curl is perfectly able to send utf-8 part names.
> based on this information and given the fact that spi2dav and the server-sided part are intended to communicate
> with one other rather than with any kind of custom clients, i suggest to add a simple fix by patching the parts used
> within spi2davex.
> btw: in HttpClient 4.x there seems to be a workaround for this problem [2]
> [1] http://www.mail-archive.com/httpclient-dev@jakarta.apache.org/msg04637.html
> [2] https://issues.apache.org/jira/browse/HTTPCLIENT-293

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.