You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/06 19:24:20 UTC
[jira] [Commented] (KARAF-4538) Cellar bundle regex is way too
"global" in command and MBean
[ https://issues.apache.org/jira/browse/KARAF-4538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468293#comment-15468293 ]
ASF GitHub Bot commented on KARAF-4538:
---------------------------------------
GitHub user shyrkov opened a pull request:
https://github.com/apache/karaf-cellar/pull/35
KARAF-4538 - use matches() instead of find() to make bundle matching strategy more predictable
The fix makes bundle selection more predictable as otherwise "cluster:bundle-start default dx" command is applied to all my bundles, whose name starts with "dx" (e.g. dx-core, dx-ext, dx-provider, etc.), which is not in line with how the org.apache.karaf.bundle.core.internal.BundleSelectorImpl is doing matching.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shyrkov/karaf-cellar KARAF-4538
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/karaf-cellar/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit 67f2366ed403b66f91c91e7fc1542fc70e0b5f31
Author: Sergiy Shyrkov <ss...@jahia.com>
Date: 2016-09-06T19:02:38Z
KARAF-4538 - use matches() instead of find() to make bundle matching
strategy more predictable
----
> Cellar bundle regex is way too "global" in command and MBean
> ------------------------------------------------------------
>
> Key: KARAF-4538
> URL: https://issues.apache.org/jira/browse/KARAF-4538
> Project: Karaf
> Issue Type: Bug
> Components: cellar-bundle, cellar-management, cellar-shell
> Affects Versions: cellar-4.0.0, cellar-3.0.3
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Fix For: cellar-4.0.1, cellar-3.0.5
>
>
> When you manipulate bundle (stop, start, etc) on the cluster (using CellarBundleMBean or cluster:bundle* commands), it expects a bundle ID name/version. However, the pattern.find() is too aggressive and take unexpected bundles.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)