You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/19 16:11:29 UTC
[GitHub] [apisix-website] foolwc opened a new pull request #488: feature: change plugin image to svg
foolwc opened a new pull request #488:
URL: https://github.com/apache/apisix-website/pull/488
Fixes: #484
Changes:
copied `iconfont.js` from project `apisix-dashboard` and load plugin icon SVG from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: c88e66979bead8b791e833dec0fc84f0dc82a205
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611efc40da5bdd0008acd58a](https://app.netlify.com/sites/apisix/deploys/611efc40da5bdd0008acd58a?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-488--apisix.netlify.app](https://deploy-preview-488--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#discussion_r692597251
##########
File path: website/src/pages/plugins.js
##########
@@ -124,20 +124,31 @@ const SectionTitle = styled.h2`
function Plugins(props) {
+ useEffect(() => {
+ const script = document.createElement('script');
+ script.type = 'text/javascript';
+ script.async = true;
+ script.src = '/js/plugin-icon.js';
+ document.head.appendChild(script);
+ }, []);
Review comment:
Is it possible to use this method?
https://docusaurus.io/docs/next/docusaurus.config.js/#scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #488: feature: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: b37b3cd3b2afe6203a7d762c345c74d9522d9541
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611e82a997eadd00075b0c3b](https://app.netlify.com/sites/apisix/deploys/611e82a997eadd00075b0c3b?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #488:
URL: https://github.com/apache/apisix-website/pull/488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: c88e66979bead8b791e833dec0fc84f0dc82a205
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611efc40da5bdd0008acd58a](https://app.netlify.com/sites/apisix/deploys/611efc40da5bdd0008acd58a?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] foolwc commented on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
foolwc commented on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902351105
> @foolwc, Are you going to center the icons in this PR only, given that this closes #484 ?
I will fix that in another PR and #484 maybe needs more discussion for design. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: ee11d0cdbba6d6374a3af895f86fe8ecef1b9815
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611e83f8336789000778b9f8](https://app.netlify.com/sites/apisix/deploys/611e83f8336789000778b9f8?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-488--apisix.netlify.app](https://deploy-preview-488--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: ee11d0cdbba6d6374a3af895f86fe8ecef1b9815
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611e83f8336789000778b9f8](https://app.netlify.com/sites/apisix/deploys/611e83f8336789000778b9f8?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902248718
thanks for your nice work, @foolwc
also cc @KishaniKandasamy @1502shivam-singh @Baoyuantop to have look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902274223
@foolwc, Are you going to center the icons in this PR only, given that this closes #484 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] liuxiran commented on a change in pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#discussion_r692475329
##########
File path: website/static/data/plugin.json
##########
@@ -184,56 +153,47 @@
"plugins": [
{
"name": "batch-requests",
- "description": "Batch-requests accepts multiple request and send them from apisix via http pipeline",
- "src": "/img/plugin/batch-requests.jpg"
+ "description": "Batch-requests accepts multiple request and send them from apisix via http pipeline"
},
{
"name": "grpc-transcode",
- "description": "Grpc-transcoding involves mapping HTTP/JSON requests and their parameters to gRPC methods and their parameters and return types",
- "src": "/img/plugin/grpc-transcode.jpg"
+ "description": "Grpc-transcoding involves mapping HTTP/JSON requests and their parameters to gRPC methods and their parameters and return types"
},
{
"name": "proxy-cache",
- "description": "The proxy-cache plugin provides the ability to cache upstream response data and can be used with other plugins",
- "src": "/img/plugin/proxy-cache.jpg"
+ "description": "The proxy-cache plugin provides the ability to cache upstream response data and can be used with other plugins"
},
{
"name": "proxy-mirror",
- "description": "TThe proxy-mirror plugin provides the ability to mirror client requests",
- "src": "/img/plugin/proxy-mirror.jpg"
+ "description": "TThe proxy-mirror plugin provides the ability to mirror client requests"
},
{
"name": "proxy-rewrite",
- "description": "The proxy-rewrite is an upstream proxy information rewriting plugin",
- "src": "/img/plugin/proxy-rewrite.jpg"
+ "description": "The proxy-rewrite is an upstream proxy information rewriting plugin"
},
{
"name": "response-rewrite",
- "description": "Response-rewrite rewrites the content returned by the upstream as well as Apache APISIX itself",
- "src": "/img/plugin/response-rewrite.jpg"
+ "description": "Response-rewrite rewrites the content returned by the upstream as well as Apache APISIX itself"
},
{
"name": "wolf-rbac",
- "description": "Wolf-rbac is an authentication and authorization (rbac) plugin where the rbac feature is provided by wolf",
- "src": "/img/plugin/wolf-rbac.jpg"
+ "description": "Wolf-rbac is an authentication and authorization (rbac) plugin where the rbac feature is provided by wolf"
},
{
"name": "client-control",
"description": "The client-control plugin dynamically controls the behavior of Nginx to handle the client request",
- "src": "/img/plugin/defaultPluginImg.jpg"
+ "useDefaultIcon": true
},
{
"name": "ext-plugin-pre-req",
"description": "The ext-plugin-pre-req runs specific external plugins in the plugin runner, before executing most of the builtin Lua plugins",
- "src": "/img/plugin/defaultPluginImg.jpg"
+ "useDefaultIcon": true
},
{
"name": "ext-plugin-post-req",
"description": "The ext-plugin-post-req runs after executing builtin Lua plugins and before proxying to the upstream",
- "src": "/img/plugin/defaultPluginImg.jpg"
+ "useDefaultIcon": true
}
]
}
-]
-
-
+]
Review comment:
```suggestion
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#issuecomment-902042999
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: b37b3cd3b2afe6203a7d762c345c74d9522d9541
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/611e82a997eadd00075b0c3b](https://app.netlify.com/sites/apisix/deploys/611e82a997eadd00075b0c3b?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-488--apisix.netlify.app](https://deploy-preview-488--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] foolwc commented on a change in pull request #488: chore: change plugin image to svg
Posted by GitBox <gi...@apache.org>.
foolwc commented on a change in pull request #488:
URL: https://github.com/apache/apisix-website/pull/488#discussion_r692607227
##########
File path: website/src/pages/plugins.js
##########
@@ -124,20 +124,31 @@ const SectionTitle = styled.h2`
function Plugins(props) {
+ useEffect(() => {
+ const script = document.createElement('script');
+ script.type = 'text/javascript';
+ script.async = true;
+ script.src = '/js/plugin-icon.js';
+ document.head.appendChild(script);
+ }, []);
Review comment:
Yes, it works. But it will load this JS globally and maybe reduce the loading speed of other page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org